From 038ec39143fb241907701fc4457a2eefc0dd0175 Mon Sep 17 00:00:00 2001
From: Andrew Kingston <aptkingston@ssl-mail.com>
Date: Thu, 18 Nov 2021 15:36:16 +0000
Subject: [PATCH 01/18] Add dynamic filter component

---
 .../design/AppPreview/componentStructure.json |   3 +-
 packages/client/manifest.json                 |  11 ++
 .../app/dynamic-filter/DynamicFilter.svelte   |  37 ++++
 .../app/dynamic-filter/FilterModal.svelte     | 176 ++++++++++++++++++
 .../components/app/dynamic-filter/index.js    |   1 +
 packages/client/src/components/app/index.js   |   1 +
 6 files changed, 228 insertions(+), 1 deletion(-)
 create mode 100644 packages/client/src/components/app/dynamic-filter/DynamicFilter.svelte
 create mode 100644 packages/client/src/components/app/dynamic-filter/FilterModal.svelte
 create mode 100644 packages/client/src/components/app/dynamic-filter/index.js

diff --git a/packages/builder/src/components/design/AppPreview/componentStructure.json b/packages/builder/src/components/design/AppPreview/componentStructure.json
index 357ea5a7be..b237347c44 100644
--- a/packages/builder/src/components/design/AppPreview/componentStructure.json
+++ b/packages/builder/src/components/design/AppPreview/componentStructure.json
@@ -67,6 +67,7 @@
       "icon",
       "embed"
     ]
-  }
+  },
+  "dynamicfilter"
 ]
 
diff --git a/packages/client/manifest.json b/packages/client/manifest.json
index 050ac4a63a..ba7f95e42e 100644
--- a/packages/client/manifest.json
+++ b/packages/client/manifest.json
@@ -2623,6 +2623,17 @@
       }
     ]
   },
+  "dynamicfilter": {
+    "name": "Dynamic Filter",
+    "icon": "FilterEdit",
+    "settings": [
+      {
+        "type": "dataProvider",
+        "label": "Provider",
+        "key": "dataProvider"
+      }
+    ]
+  },
   "tableblock": {
     "block": true,
     "name": "Table block",
diff --git a/packages/client/src/components/app/dynamic-filter/DynamicFilter.svelte b/packages/client/src/components/app/dynamic-filter/DynamicFilter.svelte
new file mode 100644
index 0000000000..6cd0d2be5b
--- /dev/null
+++ b/packages/client/src/components/app/dynamic-filter/DynamicFilter.svelte
@@ -0,0 +1,37 @@
+<script>
+  import { Button, ModalContent, Modal } from "@budibase/bbui"
+  import { getContext } from "svelte"
+  import FilterModal from "./FilterModal.svelte"
+
+  export let dataProvider
+
+  const component = getContext("component")
+  const { styleable } = getContext("sdk")
+
+  $: schema = dataProvider?.schema
+  $: schemaFields = Object.values(schema || {})
+
+  let modal
+  let tmpFilters = []
+  let filters = []
+
+  const openEditor = () => {
+    tmpFilters = [...filters]
+    modal.show()
+  }
+
+  const updateQuery = () => {
+    filters = [...tmpFilters]
+  }
+</script>
+
+<div use:styleable={$component.styles}>
+  <Button on:click={openEditor} secondary icon="FilterEdit">
+    Edit filters
+  </Button>
+  <Modal bind:this={modal}>
+    <ModalContent title="Edit filters" size="XL" onConfirm={updateQuery}>
+      <FilterModal bind:filters={tmpFilters} {schemaFields} />
+    </ModalContent>
+  </Modal>
+</div>
diff --git a/packages/client/src/components/app/dynamic-filter/FilterModal.svelte b/packages/client/src/components/app/dynamic-filter/FilterModal.svelte
new file mode 100644
index 0000000000..99b9a1a6f6
--- /dev/null
+++ b/packages/client/src/components/app/dynamic-filter/FilterModal.svelte
@@ -0,0 +1,176 @@
+<script>
+  import {
+    Body,
+    Button,
+    Combobox,
+    DatePicker,
+    DrawerContent,
+    Icon,
+    Input,
+    Layout,
+    Select,
+  } from "@budibase/bbui"
+  import { generate } from "shortid"
+  import {
+    getValidOperatorsForType,
+    OperatorOptions,
+  } from "builder/src/constants/lucene"
+
+  export let schemaFields
+  export let filters = []
+
+  const BannedTypes = ["link", "attachment", "formula"]
+
+  $: fieldOptions = (schemaFields ?? [])
+    .filter(field => !BannedTypes.includes(field.type))
+    .map(field => field.name)
+
+  const addFilter = () => {
+    filters = [
+      ...filters,
+      {
+        id: generate(),
+        field: null,
+        operator: OperatorOptions.Equals.value,
+        value: null,
+        valueType: "Value",
+      },
+    ]
+  }
+
+  const removeFilter = id => {
+    filters = filters.filter(field => field.id !== id)
+  }
+
+  const duplicateFilter = id => {
+    const existingFilter = filters.find(filter => filter.id === id)
+    const duplicate = { ...existingFilter, id: generate() }
+    filters = [...filters, duplicate]
+  }
+
+  const onFieldChange = (expression, field) => {
+    // Update the field type
+    expression.type = schemaFields.find(x => x.name === field)?.type
+
+    // Ensure a valid operator is set
+    const validOperators = getValidOperatorsForType(expression.type).map(
+      x => x.value
+    )
+    if (!validOperators.includes(expression.operator)) {
+      expression.operator = validOperators[0] ?? OperatorOptions.Equals.value
+      onOperatorChange(expression, expression.operator)
+    }
+
+    // if changed to an array, change default value to empty array
+    const idx = filters.findIndex(x => x.field === field)
+    if (expression.type === "array") {
+      filters[idx].value = []
+    } else {
+      filters[idx].value = null
+    }
+  }
+
+  const onOperatorChange = (expression, operator) => {
+    const noValueOptions = [
+      OperatorOptions.Empty.value,
+      OperatorOptions.NotEmpty.value,
+    ]
+    expression.noValue = noValueOptions.includes(operator)
+    if (expression.noValue) {
+      expression.value = null
+    }
+  }
+
+  const getFieldOptions = field => {
+    const schema = schemaFields.find(x => x.name === field)
+    return schema?.constraints?.inclusion || []
+  }
+</script>
+
+<DrawerContent>
+  <div class="container">
+    <Layout noPadding>
+      <Body size="S">
+        {#if !filters?.length}
+          Add your first filter expression.
+        {:else}
+          Results are filtered to only those which match all of the following
+          constraints.
+        {/if}
+      </Body>
+      {#if filters?.length}
+        <div class="fields">
+          {#each filters as filter, idx}
+            <Select
+              bind:value={filter.field}
+              options={fieldOptions}
+              on:change={e => onFieldChange(filter, e.detail)}
+              placeholder="Column"
+            />
+            <Select
+              disabled={!filter.field}
+              options={getValidOperatorsForType(filter.type)}
+              bind:value={filter.operator}
+              on:change={e => onOperatorChange(filter, e.detail)}
+              placeholder={null}
+            />
+            {#if ["string", "longform", "number"].includes(filter.type)}
+              <Input disabled={filter.noValue} bind:value={filter.value} />
+            {:else if ["options", "array"].includes(filter.type)}
+              <Combobox
+                disabled={filter.noValue}
+                options={getFieldOptions(filter.field)}
+                bind:value={filter.value}
+              />
+            {:else if filter.type === "boolean"}
+              <Combobox
+                disabled={filter.noValue}
+                options={[
+                  { label: "True", value: "true" },
+                  { label: "False", value: "false" },
+                ]}
+                bind:value={filter.value}
+              />
+            {:else if filter.type === "datetime"}
+              <DatePicker disabled={filter.noValue} bind:value={filter.value} />
+            {:else}
+              <Input disabled />
+            {/if}
+            <Icon
+              name="Duplicate"
+              hoverable
+              size="S"
+              on:click={() => duplicateFilter(filter.id)}
+            />
+            <Icon
+              name="Close"
+              hoverable
+              size="S"
+              on:click={() => removeFilter(filter.id)}
+            />
+          {/each}
+        </div>
+      {/if}
+      <div>
+        <Button icon="AddCircle" size="M" secondary on:click={addFilter}>
+          Add filter
+        </Button>
+      </div>
+    </Layout>
+  </div>
+</DrawerContent>
+
+<style>
+  .container {
+    width: 100%;
+    max-width: 1000px;
+    margin: 0 auto;
+  }
+  .fields {
+    display: grid;
+    column-gap: var(--spacing-l);
+    row-gap: var(--spacing-s);
+    align-items: center;
+    grid-template-columns: 1fr 120px 1fr auto auto;
+  }
+</style>
diff --git a/packages/client/src/components/app/dynamic-filter/index.js b/packages/client/src/components/app/dynamic-filter/index.js
new file mode 100644
index 0000000000..5ac7d31730
--- /dev/null
+++ b/packages/client/src/components/app/dynamic-filter/index.js
@@ -0,0 +1 @@
+export { default as dynamicfilter } from "./DynamicFilter.svelte"
diff --git a/packages/client/src/components/app/index.js b/packages/client/src/components/app/index.js
index 92725f0738..f5d085e97b 100644
--- a/packages/client/src/components/app/index.js
+++ b/packages/client/src/components/app/index.js
@@ -33,6 +33,7 @@ export * from "./charts"
 export * from "./forms"
 export * from "./table"
 export * from "./blocks"
+export * from "./dynamic-filter"
 
 // Deprecated component left for compatibility in old apps
 export { default as navigation } from "./deprecated/Navigation.svelte"

From b47a25a273c90f0fb0fcecf25a1f9bec121484b1 Mon Sep 17 00:00:00 2001
From: Andrew Kingston <aptkingston@ssl-mail.com>
Date: Thu, 18 Nov 2021 15:43:51 +0000
Subject: [PATCH 02/18] Add settings to dynamic filter to control button text
 and allowed filter fields

---
 packages/client/manifest.json                 | 12 +++++++++
 .../app/dynamic-filter/DynamicFilter.svelte   | 27 ++++++++++++++-----
 2 files changed, 33 insertions(+), 6 deletions(-)

diff --git a/packages/client/manifest.json b/packages/client/manifest.json
index ba7f95e42e..da1d87c5ab 100644
--- a/packages/client/manifest.json
+++ b/packages/client/manifest.json
@@ -2631,6 +2631,18 @@
         "type": "dataProvider",
         "label": "Provider",
         "key": "dataProvider"
+      },
+      {
+        "type": "multifield",
+        "label": "Allowed filter fields",
+        "key": "allowedFields",
+        "placeholder": "All fields"
+      },
+      {
+        "type": "text",
+        "label": "Button text",
+        "key": "buttonText",
+        "defaultValue": "Edit filters"
       }
     ]
   },
diff --git a/packages/client/src/components/app/dynamic-filter/DynamicFilter.svelte b/packages/client/src/components/app/dynamic-filter/DynamicFilter.svelte
index 6cd0d2be5b..80a1b919bb 100644
--- a/packages/client/src/components/app/dynamic-filter/DynamicFilter.svelte
+++ b/packages/client/src/components/app/dynamic-filter/DynamicFilter.svelte
@@ -4,17 +4,32 @@
   import FilterModal from "./FilterModal.svelte"
 
   export let dataProvider
+  export let allowedFields
+  export let buttonText
 
   const component = getContext("component")
   const { styleable } = getContext("sdk")
 
-  $: schema = dataProvider?.schema
-  $: schemaFields = Object.values(schema || {})
-
   let modal
   let tmpFilters = []
   let filters = []
 
+  $: schema = dataProvider?.schema
+  $: schemaFields = getSchemaFields(schema, allowedFields)
+  $: text = buttonText || "Edit filters"
+
+  const getSchemaFields = (schema, allowedFields) => {
+    let clonedSchema = {}
+    if (!allowedFields?.length) {
+      clonedSchema = schema
+    } else {
+      allowedFields?.forEach(field => {
+        clonedSchema[field] = schema[field]
+      })
+    }
+    return Object.values(clonedSchema || {})
+  }
+
   const openEditor = () => {
     tmpFilters = [...filters]
     modal.show()
@@ -26,11 +41,11 @@
 </script>
 
 <div use:styleable={$component.styles}>
-  <Button on:click={openEditor} secondary icon="FilterEdit">
-    Edit filters
+  <Button on:click={openEditor} secondary>
+    {text}
   </Button>
   <Modal bind:this={modal}>
-    <ModalContent title="Edit filters" size="XL" onConfirm={updateQuery}>
+    <ModalContent title={text} size="XL" onConfirm={updateQuery}>
       <FilterModal bind:filters={tmpFilters} {schemaFields} />
     </ModalContent>
   </Modal>

From e1021f429ce2ade90cfc5b68f078fb3d05e804fa Mon Sep 17 00:00:00 2001
From: Andrew Kingston <aptkingston@ssl-mail.com>
Date: Thu, 18 Nov 2021 18:41:37 +0000
Subject: [PATCH 03/18] Refactor how extending data provider queries works to
 support multiple extensions per key

---
 .../src/components/app/DataProvider.svelte    | 17 +++++----
 .../src/components/app/DateRangePicker.svelte | 38 ++++++++++++-------
 2 files changed, 34 insertions(+), 21 deletions(-)

diff --git a/packages/client/src/components/app/DataProvider.svelte b/packages/client/src/components/app/DataProvider.svelte
index 08f2fb06cd..e9d306cc3b 100644
--- a/packages/client/src/components/app/DataProvider.svelte
+++ b/packages/client/src/components/app/DataProvider.svelte
@@ -275,11 +275,10 @@
     allRows = res.rows
   }
 
-  const addQueryExtension = (key, operator, field, value) => {
-    if (!key || !operator || !field) {
+  const addQueryExtension = (key, extension) => {
+    if (!key || !extension) {
       return
     }
-    const extension = { operator, field, value }
     queryExtensions = { ...queryExtensions, [key]: extension }
   }
 
@@ -295,11 +294,13 @@
   const extendQuery = (defaultQuery, extensions) => {
     const extensionValues = Object.values(extensions || {})
     let extendedQuery = { ...defaultQuery }
-    extensionValues.forEach(({ operator, field, value }) => {
-      extendedQuery[operator] = {
-        ...extendedQuery[operator],
-        [field]: value,
-      }
+    extensionValues.forEach(extension => {
+      Object.entries(extension || {}).forEach(([operator, fields]) => {
+        extendedQuery[operator] = {
+          ...extendedQuery[operator],
+          ...fields,
+        }
+      })
     })
 
     if (JSON.stringify(query) !== JSON.stringify(extendedQuery)) {
diff --git a/packages/client/src/components/app/DateRangePicker.svelte b/packages/client/src/components/app/DateRangePicker.svelte
index 651a19abc4..9f3207d4d2 100644
--- a/packages/client/src/components/app/DateRangePicker.svelte
+++ b/packages/client/src/components/app/DateRangePicker.svelte
@@ -13,15 +13,6 @@
 
   const component = getContext("component")
   const { styleable, ActionTypes, getAction } = getContext("sdk")
-
-  $: addExtension = getAction(
-    dataProvider?.id,
-    ActionTypes.AddDataProviderQueryExtension
-  )
-  $: removeExtension = getAction(
-    dataProvider?.id,
-    ActionTypes.RemoveDataProviderQueryExtension
-  )
   const options = [
     "Last 1 day",
     "Last 7 days",
@@ -32,10 +23,24 @@
   ]
   let value = options.includes(defaultValue) ? defaultValue : "Last 30 days"
 
-  $: queryExtension = getQueryExtension(value)
-  $: addExtension?.($component.id, "range", field, queryExtension)
+  $: dataProviderId = dataProvider?.id
+  $: addExtension = getAction(
+    dataProviderId,
+    ActionTypes.AddDataProviderQueryExtension
+  )
+  $: removeExtension = getAction(
+    dataProviderId,
+    ActionTypes.RemoveDataProviderQueryExtension
+  )
+  $: queryExtension = getQueryExtension(field, value)
+  $: addExtension?.($component.id, queryExtension)
+
+  const getQueryExtension = (field, value) => {
+    if (!field || !value) {
+      return null
+    }
+    console.log("getting extension for " + value)
 
-  const getQueryExtension = value => {
     let low = dayjs.utc().subtract(1, "year")
     let high = dayjs.utc().add(1, "day")
 
@@ -51,7 +56,14 @@
       low = dayjs.utc().subtract(6, "months")
     }
 
-    return { low: low.format(), high: high.format() }
+    return {
+      range: {
+        [field]: {
+          low: low.format(),
+          high: high.format(),
+        },
+      },
+    }
   }
 
   onDestroy(() => {

From c432c86419a4702e7de2a130e89297ede1cecefb Mon Sep 17 00:00:00 2001
From: Andrew Kingston <aptkingston@ssl-mail.com>
Date: Thu, 18 Nov 2021 20:31:00 +0000
Subject: [PATCH 04/18] Add modal container to top level of client apps

---
 packages/client/src/components/ClientApp.svelte | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/packages/client/src/components/ClientApp.svelte b/packages/client/src/components/ClientApp.svelte
index 119a26800f..98dec9667b 100644
--- a/packages/client/src/components/ClientApp.svelte
+++ b/packages/client/src/components/ClientApp.svelte
@@ -121,6 +121,9 @@
                   -->
                   <div id="flatpickr-root" />
 
+                  <!-- Modal container to ensure they sit on top -->
+                  <div class="modal-container" />
+
                   <!-- Layers on top of app -->
                   <NotificationDisplay />
                   <ConfirmationDisplay />

From b2a58d1c355117a07657e20c99b7a4ab8c265a3e Mon Sep 17 00:00:00 2001
From: Andrew Kingston <aptkingston@ssl-mail.com>
Date: Thu, 18 Nov 2021 20:31:25 +0000
Subject: [PATCH 05/18] Ensure important builder store variables do not get
 unassigned when setting the builder store state

---
 packages/client/src/stores/builder.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/packages/client/src/stores/builder.js b/packages/client/src/stores/builder.js
index 08ac6ba906..35fb3edae2 100644
--- a/packages/client/src/stores/builder.js
+++ b/packages/client/src/stores/builder.js
@@ -10,7 +10,6 @@ const dispatchEvent = (type, data = {}) => {
 const createBuilderStore = () => {
   const initialState = {
     inBuilder: false,
-    appId: null,
     layout: null,
     screen: null,
     selectedComponentId: null,
@@ -94,6 +93,7 @@ const createBuilderStore = () => {
   }
   return {
     ...writableStore,
+    set: state => writableStore.set({ ...initialState, ...state }),
     subscribe: derivedStore.subscribe,
     actions,
   }

From 0aa0f6a07db38c7ed7db465edb02416edb0d4c0d Mon Sep 17 00:00:00 2001
From: Andrew Kingston <aptkingston@ssl-mail.com>
Date: Thu, 18 Nov 2021 20:32:00 +0000
Subject: [PATCH 06/18] Enable dynamic filter component to update data provider
 queries

---
 .../app/dynamic-filter/DynamicFilter.svelte   | 60 ++++++++++++++-----
 1 file changed, 46 insertions(+), 14 deletions(-)

diff --git a/packages/client/src/components/app/dynamic-filter/DynamicFilter.svelte b/packages/client/src/components/app/dynamic-filter/DynamicFilter.svelte
index 80a1b919bb..d471b3a021 100644
--- a/packages/client/src/components/app/dynamic-filter/DynamicFilter.svelte
+++ b/packages/client/src/components/app/dynamic-filter/DynamicFilter.svelte
@@ -1,22 +1,50 @@
 <script>
-  import { Button, ModalContent, Modal } from "@budibase/bbui"
-  import { getContext } from "svelte"
+  import { get } from "svelte/store"
+  import { getContext, onDestroy } from "svelte"
+  import { ModalContent, Modal } from "@budibase/bbui"
   import FilterModal from "./FilterModal.svelte"
+  import { buildLuceneQuery } from "builder/src/helpers/lucene"
+  import Button from "../Button.svelte"
 
   export let dataProvider
   export let allowedFields
   export let buttonText
 
   const component = getContext("component")
-  const { styleable } = getContext("sdk")
+  const { builderStore, ActionTypes, getAction } = getContext("sdk")
 
   let modal
   let tmpFilters = []
   let filters = []
 
+  $: dataProviderId = dataProvider?.id
+  $: addExtension = getAction(
+    dataProviderId,
+    ActionTypes.AddDataProviderQueryExtension
+  )
+  $: removeExtension = getAction(
+    dataProviderId,
+    ActionTypes.RemoveDataProviderQueryExtension
+  )
   $: schema = dataProvider?.schema
   $: schemaFields = getSchemaFields(schema, allowedFields)
-  $: text = buttonText || "Edit filters"
+  $: text = getText(buttonText, filters)
+
+  // Add query extension to data provider
+  $: {
+    if (filters?.length) {
+      const queryExtension = buildLuceneQuery(filters)
+      addExtension?.($component.id, queryExtension)
+    }
+  }
+
+  const getText = (buttonText, filters) => {
+    let text = buttonText || "Edit filters"
+    if (filters?.length) {
+      text += ` (${filters.length})`
+    }
+    return text
+  }
 
   const getSchemaFields = (schema, allowedFields) => {
     let clonedSchema = {}
@@ -31,6 +59,9 @@
   }
 
   const openEditor = () => {
+    if (get(builderStore).inBuilder) {
+      return
+    }
     tmpFilters = [...filters]
     modal.show()
   }
@@ -38,15 +69,16 @@
   const updateQuery = () => {
     filters = [...tmpFilters]
   }
+
+  onDestroy(() => {
+    removeExtension?.($component.id)
+  })
 </script>
 
-<div use:styleable={$component.styles}>
-  <Button on:click={openEditor} secondary>
-    {text}
-  </Button>
-  <Modal bind:this={modal}>
-    <ModalContent title={text} size="XL" onConfirm={updateQuery}>
-      <FilterModal bind:filters={tmpFilters} {schemaFields} />
-    </ModalContent>
-  </Modal>
-</div>
+<Button onClick={openEditor} {text} />
+
+<Modal bind:this={modal}>
+  <ModalContent title={text} size="XL" onConfirm={updateQuery}>
+    <FilterModal bind:filters={tmpFilters} {schemaFields} />
+  </ModalContent>
+</Modal>

From df29ad109257c0c9020df8797b778e4592533a6e Mon Sep 17 00:00:00 2001
From: Andrew Kingston <aptkingston@ssl-mail.com>
Date: Thu, 18 Nov 2021 20:32:42 +0000
Subject: [PATCH 07/18] Be more explicit about the boolean nature of component
 settings in the manifest and add back in a render key to fix toggling
 contenteditable attribute on dom elements

---
 .../client/src/components/Component.svelte    | 76 +++++++++++--------
 1 file changed, 46 insertions(+), 30 deletions(-)

diff --git a/packages/client/src/components/Component.svelte b/packages/client/src/components/Component.svelte
index a4ee290028..b248ee1277 100644
--- a/packages/client/src/components/Component.svelte
+++ b/packages/client/src/components/Component.svelte
@@ -72,13 +72,18 @@
   $: inSelectedPath = $builderStore.selectedComponentPath?.includes(id)
   $: inDragPath = inSelectedPath && $builderStore.editMode
 
+  // Derive definition properties which can all be optional, so need to be
+  // coerced to booleans
+  $: editable = !!definition?.editable
+  $: hasChildren = !!definition?.hasChildren
+  $: showEmptyState = !!definition?.showEmptyState
+
   // Interactive components can be selected, dragged and highlighted inside
   // the builder preview
   $: interactive =
     $builderStore.inBuilder &&
     ($builderStore.previewType === "layout" || insideScreenslot) &&
     !isBlock
-  $: editable = definition?.editable
   $: editing = editable && selected && $builderStore.editMode
   $: draggable = !inDragPath && interactive && !isLayout && !isScreen
   $: droppable = interactive && !isLayout && !isScreen
@@ -86,8 +91,8 @@
   // Empty components are those which accept children but do not have any.
   // Empty states can be shown for these components, but can be disabled
   // in the component manifest.
-  $: empty = interactive && !children.length && definition?.hasChildren
-  $: emptyState = empty && definition?.showEmptyState !== false
+  $: empty = interactive && !children.length && hasChildren
+  $: emptyState = empty && showEmptyState
 
   // Raw settings are all settings excluding internal props and children
   $: rawSettings = getRawSettings(instance)
@@ -103,6 +108,9 @@
   // Build up the final settings object to be passed to the component
   $: cacheSettings(enrichedSettings, nestedSettings, conditionalSettings)
 
+  // Render key is used to determine when components need to fully remount
+  $: renderKey = getRenderKey(id, editing)
+
   // Update component context
   $: componentStore.set({
     id,
@@ -268,35 +276,43 @@
       })
     }
   }
+
+  // Generates a key used to determine when components need to fully remount.
+  // Currently only toggling editing requires remounting.
+  const getRenderKey = (id, editing) => {
+    return hashString(`${id}-${editing}`)
+  }
 </script>
 
-{#if constructor && cachedSettings && (visible || inSelectedPath)}
-  <!-- The ID is used as a class because getElementsByClassName is O(1) -->
-  <!-- and the performance matters for the selection indicators -->
-  <div
-    class={`component ${id}`}
-    class:draggable
-    class:droppable
-    class:empty
-    class:interactive
-    class:editing
-    class:block={isBlock}
-    data-id={id}
-    data-name={name}
-  >
-    <svelte:component this={constructor} {...cachedSettings}>
-      {#if children.length}
-        {#each children as child (child._id)}
-          <svelte:self instance={child} />
-        {/each}
-      {:else if emptyState}
-        <Placeholder />
-      {:else if isBlock}
-        <slot />
-      {/if}
-    </svelte:component>
-  </div>
-{/if}
+{#key renderKey}
+  {#if constructor && cachedSettings && (visible || inSelectedPath)}
+    <!-- The ID is used as a class because getElementsByClassName is O(1) -->
+    <!-- and the performance matters for the selection indicators -->
+    <div
+      class={`component ${id}`}
+      class:draggable
+      class:droppable
+      class:empty
+      class:interactive
+      class:editing
+      class:block={isBlock}
+      data-id={id}
+      data-name={name}
+    >
+      <svelte:component this={constructor} {...cachedSettings}>
+        {#if children.length}
+          {#each children as child (child._id)}
+            <svelte:self instance={child} />
+          {/each}
+        {:else if emptyState}
+          <Placeholder />
+        {:else if isBlock}
+          <slot />
+        {/if}
+      </svelte:component>
+    </div>
+  {/if}
+{/key}
 
 <style>
   .component {

From 90b3e2a16d419139ef405b02f5f4966ccf22ea03 Mon Sep 17 00:00:00 2001
From: Andrew Kingston <aptkingston@ssl-mail.com>
Date: Thu, 18 Nov 2021 20:32:57 +0000
Subject: [PATCH 08/18] Update editable components to trim whitespace when
 editing inline

---
 packages/client/src/components/app/Button.svelte      | 2 +-
 packages/client/src/components/app/Heading.svelte     | 2 +-
 packages/client/src/components/app/Link.svelte        | 2 +-
 packages/client/src/components/app/Text.svelte        | 2 +-
 packages/client/src/components/app/forms/Field.svelte | 2 +-
 5 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/packages/client/src/components/app/Button.svelte b/packages/client/src/components/app/Button.svelte
index f00b114b2b..5b06475b30 100644
--- a/packages/client/src/components/app/Button.svelte
+++ b/packages/client/src/components/app/Button.svelte
@@ -25,7 +25,7 @@
   }
 
   const updateText = e => {
-    builderStore.actions.updateProp("text", e.target.textContent)
+    builderStore.actions.updateProp("text", e.target.textContent.trim())
   }
 </script>
 
diff --git a/packages/client/src/components/app/Heading.svelte b/packages/client/src/components/app/Heading.svelte
index 0450d2d11d..b27862f164 100644
--- a/packages/client/src/components/app/Heading.svelte
+++ b/packages/client/src/components/app/Heading.svelte
@@ -47,7 +47,7 @@
 
   // Convert contenteditable HTML to text and save
   const updateText = e => {
-    const sanitized = e.target.innerHTML.replace(/<br>/gi, "\n")
+    const sanitized = e.target.innerHTML.replace(/<br>/gi, "\n").trim()
     builderStore.actions.updateProp("text", sanitized)
   }
 </script>
diff --git a/packages/client/src/components/app/Link.svelte b/packages/client/src/components/app/Link.svelte
index 9587b34f11..851b2f0b66 100644
--- a/packages/client/src/components/app/Link.svelte
+++ b/packages/client/src/components/app/Link.svelte
@@ -47,7 +47,7 @@
   }
 
   const updateText = e => {
-    builderStore.actions.updateProp("text", e.target.textContent)
+    builderStore.actions.updateProp("text", e.target.textContent.trim())
   }
 </script>
 
diff --git a/packages/client/src/components/app/Text.svelte b/packages/client/src/components/app/Text.svelte
index 14681ebbaf..679434edeb 100644
--- a/packages/client/src/components/app/Text.svelte
+++ b/packages/client/src/components/app/Text.svelte
@@ -46,7 +46,7 @@
 
   // Convert contenteditable HTML to text and save
   const updateText = e => {
-    const sanitized = e.target.innerHTML.replace(/<br>/gi, "\n")
+    const sanitized = e.target.innerHTML.replace(/<br>/gi, "\n").trim()
     builderStore.actions.updateProp("text", sanitized)
   }
 </script>
diff --git a/packages/client/src/components/app/forms/Field.svelte b/packages/client/src/components/app/forms/Field.svelte
index 3ef184c4a9..79de01351a 100644
--- a/packages/client/src/components/app/forms/Field.svelte
+++ b/packages/client/src/components/app/forms/Field.svelte
@@ -49,7 +49,7 @@
   $: labelClass = labelPos === "above" ? "" : `spectrum-FieldLabel--${labelPos}`
 
   const updateLabel = e => {
-    builderStore.actions.updateProp("label", e.target.textContent)
+    builderStore.actions.updateProp("label", e.target.textContent.trim())
   }
 </script>
 

From 2ab40d51dc4dfafe40d0fdfafc55dba6db6e0507 Mon Sep 17 00:00:00 2001
From: Andrew Kingston <aptkingston@ssl-mail.com>
Date: Thu, 18 Nov 2021 20:38:55 +0000
Subject: [PATCH 09/18] Update logic for determining whether to show empty
 state or not

---
 packages/client/src/components/Component.svelte | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/packages/client/src/components/Component.svelte b/packages/client/src/components/Component.svelte
index b248ee1277..d8cdbd3f53 100644
--- a/packages/client/src/components/Component.svelte
+++ b/packages/client/src/components/Component.svelte
@@ -76,7 +76,7 @@
   // coerced to booleans
   $: editable = !!definition?.editable
   $: hasChildren = !!definition?.hasChildren
-  $: showEmptyState = !!definition?.showEmptyState
+  $: showEmptyState = definition?.showEmptyState !== false
 
   // Interactive components can be selected, dragged and highlighted inside
   // the builder preview

From 3c7f3ee694063fe34a254a1d513bc26c370505d0 Mon Sep 17 00:00:00 2001
From: Andrew Kingston <aptkingston@ssl-mail.com>
Date: Mon, 22 Nov 2021 13:34:28 +0000
Subject: [PATCH 10/18] Update default button text of dynamic filter component

---
 packages/client/manifest.json | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/packages/client/manifest.json b/packages/client/manifest.json
index b9252d076b..7bf9b77bda 100644
--- a/packages/client/manifest.json
+++ b/packages/client/manifest.json
@@ -2666,7 +2666,7 @@
         "type": "text",
         "label": "Button text",
         "key": "buttonText",
-        "defaultValue": "Edit filters"
+        "defaultValue": "Filter"
       }
     ]
   },

From 6f37fc27e1303c362f298ca5e33010e5660c001a Mon Sep 17 00:00:00 2001
From: Andrew Kingston <aptkingston@ssl-mail.com>
Date: Mon, 22 Nov 2021 13:42:09 +0000
Subject: [PATCH 11/18] Fix issue with not correctly removing dynamic filters
 when clearing all filters

---
 .../src/components/app/dynamic-filter/DynamicFilter.svelte      | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/packages/client/src/components/app/dynamic-filter/DynamicFilter.svelte b/packages/client/src/components/app/dynamic-filter/DynamicFilter.svelte
index d471b3a021..92b78905ef 100644
--- a/packages/client/src/components/app/dynamic-filter/DynamicFilter.svelte
+++ b/packages/client/src/components/app/dynamic-filter/DynamicFilter.svelte
@@ -35,6 +35,8 @@
     if (filters?.length) {
       const queryExtension = buildLuceneQuery(filters)
       addExtension?.($component.id, queryExtension)
+    } else {
+      removeExtension?.($component.id)
     }
   }
 

From 067e5d3a7d6f2d676a867a93db582c5339f09f3f Mon Sep 17 00:00:00 2001
From: Andrew Kingston <aptkingston@ssl-mail.com>
Date: Mon, 22 Nov 2021 14:09:54 +0000
Subject: [PATCH 12/18] Removing log statement

---
 packages/client/src/components/app/DateRangePicker.svelte | 1 -
 1 file changed, 1 deletion(-)

diff --git a/packages/client/src/components/app/DateRangePicker.svelte b/packages/client/src/components/app/DateRangePicker.svelte
index 9f3207d4d2..0246b68198 100644
--- a/packages/client/src/components/app/DateRangePicker.svelte
+++ b/packages/client/src/components/app/DateRangePicker.svelte
@@ -39,7 +39,6 @@
     if (!field || !value) {
       return null
     }
-    console.log("getting extension for " + value)
 
     let low = dayjs.utc().subtract(1, "year")
     let high = dayjs.utc().add(1, "day")

From 74289a45882670fc427ad866cd302475e0493fc8 Mon Sep 17 00:00:00 2001
From: Andrew Kingston <aptkingston@ssl-mail.com>
Date: Mon, 22 Nov 2021 14:48:04 +0000
Subject: [PATCH 13/18] Reorganise component structure

---
 .../design/AppPreview/componentStructure.json | 28 +++++++++++++------
 1 file changed, 20 insertions(+), 8 deletions(-)

diff --git a/packages/builder/src/components/design/AppPreview/componentStructure.json b/packages/builder/src/components/design/AppPreview/componentStructure.json
index b237347c44..240de3ea6c 100644
--- a/packages/builder/src/components/design/AppPreview/componentStructure.json
+++ b/packages/builder/src/components/design/AppPreview/componentStructure.json
@@ -8,12 +8,24 @@
       "repeaterblock"
     ]
   },
-  "section",
-  "container",
-  "dataprovider",
-  "table",
-  "repeater",
-  "button",
+  {
+    "name": "Layout",
+    "icon": "ClassicGridView",
+    "children": [
+      "container",
+      "section"
+    ]
+  },
+  {
+    "name": "Data",
+    "icon": "Data",
+    "children": [
+      "dataprovider",
+      "repeater",
+      "table",
+      "dynamicfilter"
+    ]
+  },
   {
     "name": "Form",
     "icon": "Form",
@@ -60,6 +72,7 @@
     "children": [
       "heading",
       "text",
+      "button",
       "divider",
       "image",
       "backgroundimage",
@@ -67,7 +80,6 @@
       "icon",
       "embed"
     ]
-  },
-  "dynamicfilter"
+  }
 ]
 

From ae19581288499dca7314e3357e4b0da3765f778a Mon Sep 17 00:00:00 2001
From: Andrew Kingston <aptkingston@ssl-mail.com>
Date: Mon, 22 Nov 2021 14:48:34 +0000
Subject: [PATCH 14/18] Add button variant, size and quiet settings to dynamic
 filter. Allow dyanmic filter button text to be edited inline

---
 packages/client/manifest.json                 | 66 ++++++++++++++++++-
 .../app/dynamic-filter/DynamicFilter.svelte   | 17 +++--
 2 files changed, 74 insertions(+), 9 deletions(-)

diff --git a/packages/client/manifest.json b/packages/client/manifest.json
index 7bf9b77bda..25e7840a66 100644
--- a/packages/client/manifest.json
+++ b/packages/client/manifest.json
@@ -247,7 +247,6 @@
     "description": "A basic html button that is ready for styling",
     "icon": "Button",
     "editable": true,
-    "illegalChildren": ["section"],
     "showSettingsBar": true,
     "settings": [
       {
@@ -2650,6 +2649,8 @@
   "dynamicfilter": {
     "name": "Dynamic Filter",
     "icon": "FilterEdit",
+    "showSettingsBar": true,
+    "editable": true,
     "settings": [
       {
         "type": "dataProvider",
@@ -2665,8 +2666,69 @@
       {
         "type": "text",
         "label": "Button text",
-        "key": "buttonText",
+        "key": "text",
         "defaultValue": "Filter"
+      },
+      {
+        "type": "select",
+        "showInBar": true,
+        "label": "Button variant",
+        "key": "type",
+        "options": [
+          {
+            "label": "Primary",
+            "value": "primary"
+          }, {
+            "label": "Secondary",
+            "value": "secondary"
+          },
+          {
+            "label": "Action",
+            "value": "cta"
+          },
+          {
+            "label": "Warning",
+            "value": "warning"
+          },
+          {
+            "label": "Over Background",
+            "value": "overBackground"
+          }
+        ],
+        "defaultValue": "primary"
+      },
+      {
+        "type": "select",
+        "label": "Button size",
+        "showInBar": true,
+        "key": "size",
+        "options": [
+          {
+            "label": "Small",
+            "value": "S"
+          },
+          {
+            "label": "Medium",
+            "value": "M"
+          },
+          {
+            "label": "Large",
+            "value": "L"
+          },
+          {
+            "label": "Extra large",
+            "value": "XL"
+          }
+        ],
+        "defaultValue": "M"
+      },
+      {
+        "type": "boolean",
+        "label": "Quiet button",
+        "key": "quiet",
+        "showInBar": true,
+        "barIcon": "VisibilityOff",
+        "barTitle": "Quiet variant"
       }
     ]
   },
diff --git a/packages/client/src/components/app/dynamic-filter/DynamicFilter.svelte b/packages/client/src/components/app/dynamic-filter/DynamicFilter.svelte
index 92b78905ef..f85fe7bedd 100644
--- a/packages/client/src/components/app/dynamic-filter/DynamicFilter.svelte
+++ b/packages/client/src/components/app/dynamic-filter/DynamicFilter.svelte
@@ -8,7 +8,10 @@
 
   export let dataProvider
   export let allowedFields
-  export let buttonText
+  export let text = ""
+  export let size = "M"
+  export let type = "primary"
+  export let quiet = false
 
   const component = getContext("component")
   const { builderStore, ActionTypes, getAction } = getContext("sdk")
@@ -28,7 +31,7 @@
   )
   $: schema = dataProvider?.schema
   $: schemaFields = getSchemaFields(schema, allowedFields)
-  $: text = getText(buttonText, filters)
+  $: buttonText = getButtonText(text, filters)
 
   // Add query extension to data provider
   $: {
@@ -40,12 +43,12 @@
     }
   }
 
-  const getText = (buttonText, filters) => {
-    let text = buttonText || "Edit filters"
+  const getButtonText = (text, filters) => {
+    let buttonText = text || "Filter"
     if (filters?.length) {
-      text += ` (${filters.length})`
+      buttonText += ` (${filters.length})`
     }
-    return text
+    return buttonText
   }
 
   const getSchemaFields = (schema, allowedFields) => {
@@ -77,7 +80,7 @@
   })
 </script>
 
-<Button onClick={openEditor} {text} />
+<Button onClick={openEditor} text={buttonText} {size} {type} {quiet} />
 
 <Modal bind:this={modal}>
   <ModalContent title={text} size="XL" onConfirm={updateQuery}>

From 5cf682e1f0a3503cd14e9d8fd2feed548f24d5bd Mon Sep 17 00:00:00 2001
From: Andrew Kingston <aptkingston@ssl-mail.com>
Date: Mon, 22 Nov 2021 15:26:41 +0000
Subject: [PATCH 15/18] Update cypress tests to account for component
 restructuring

---
 .../addMultiOptionDatatype.spec.js            | 74 ++++++++++---------
 1 file changed, 38 insertions(+), 36 deletions(-)

diff --git a/packages/builder/cypress/integration/addMultiOptionDatatype.spec.js b/packages/builder/cypress/integration/addMultiOptionDatatype.spec.js
index bc2619c53d..1b9fee8cbc 100644
--- a/packages/builder/cypress/integration/addMultiOptionDatatype.spec.js
+++ b/packages/builder/cypress/integration/addMultiOptionDatatype.spec.js
@@ -1,41 +1,43 @@
 context("Add Multi-Option Datatype", () => {
-    before(() => {
-      cy.login()
-      cy.createTestApp()
-    })
+  before(() => {
+    cy.login()
+    cy.createTestApp()
+  })
 
-    it("should create a new table, with data", () => {
-        cy.createTable("Multi Data")
-        cy.addColumn("Multi Data", "Test Data", "Multi-select", "1\n2\n3\n4\n5")
-        cy.addRowMultiValue(["1", "2", "3", "4", "5"])
-    })
+  it("should create a new table, with data", () => {
+    cy.createTable("Multi Data")
+    cy.addColumn("Multi Data", "Test Data", "Multi-select", "1\n2\n3\n4\n5")
+    cy.addRowMultiValue(["1", "2", "3", "4", "5"])
+  })
 
-    it ("should add form with multi select picker, containing 5 options", () => {
-        cy.navigateToFrontend()
-        cy.wait(500)
-        // Add data provider
-        cy.get(`[data-cy="category-Data Provider"]`).click()
-        cy.get('[data-cy="dataSource-prop-control"]').click()
-        cy.get(".dropdown").contains("Multi Data").click()
-        cy.wait(500)
-        // Add Form with schema to match table
-        cy.addComponent("Form", "Form")
-        cy.get('[data-cy="dataSource-prop-control"').click()
-        cy.get(".dropdown").contains("Multi Data").click()
-        cy.wait(500)
-        // Add multi-select picker to form
-        cy.addComponent("Form", "Multi-select Picker").then((componentId) => {
-            cy.get('[data-cy="field-prop-control"]').type("Test Data").type('{enter}')
-            cy.wait(1000)
-            cy.getComponent(componentId).contains("Choose some options").click()
-            // Check picker has 5 items
-            cy.getComponent(componentId).find('li').should('have.length', 5)
-            // Select all items
-            for (let i = 1; i < 6; i++) {
-                cy.getComponent(componentId).find('li').contains(i).click()
-            }
-            // Check items have been selected
-            cy.getComponent(componentId).find('.spectrum-Picker-label').contains("(5)")
-        })
+  it("should add form with multi select picker, containing 5 options", () => {
+    cy.navigateToFrontend()
+    cy.wait(500)
+    // Add data provider
+    cy.get(`[data-cy="component-Data Provider"]`).click()
+    cy.get('[data-cy="dataSource-prop-control"]').click()
+    cy.get(".dropdown").contains("Multi Data").click()
+    cy.wait(500)
+    // Add Form with schema to match table
+    cy.addComponent("Form", "Form")
+    cy.get('[data-cy="dataSource-prop-control"').click()
+    cy.get(".dropdown").contains("Multi Data").click()
+    cy.wait(500)
+    // Add multi-select picker to form
+    cy.addComponent("Form", "Multi-select Picker").then(componentId => {
+      cy.get('[data-cy="field-prop-control"]').type("Test Data").type("{enter}")
+      cy.wait(1000)
+      cy.getComponent(componentId).contains("Choose some options").click()
+      // Check picker has 5 items
+      cy.getComponent(componentId).find("li").should("have.length", 5)
+      // Select all items
+      for (let i = 1; i < 6; i++) {
+        cy.getComponent(componentId).find("li").contains(i).click()
+      }
+      // Check items have been selected
+      cy.getComponent(componentId)
+        .find(".spectrum-Picker-label")
+        .contains("(5)")
     })
+  })
 })

From 1e360d6873e86c05c779c991b00ca99ca5b42cb3 Mon Sep 17 00:00:00 2001
From: Andrew Kingston <aptkingston@ssl-mail.com>
Date: Mon, 22 Nov 2021 16:29:03 +0000
Subject: [PATCH 16/18] Fix cypress tests

---
 .../builder/cypress/integration/addMultiOptionDatatype.spec.js   | 1 +
 1 file changed, 1 insertion(+)

diff --git a/packages/builder/cypress/integration/addMultiOptionDatatype.spec.js b/packages/builder/cypress/integration/addMultiOptionDatatype.spec.js
index 1b9fee8cbc..b3e0f413f8 100644
--- a/packages/builder/cypress/integration/addMultiOptionDatatype.spec.js
+++ b/packages/builder/cypress/integration/addMultiOptionDatatype.spec.js
@@ -14,6 +14,7 @@ context("Add Multi-Option Datatype", () => {
     cy.navigateToFrontend()
     cy.wait(500)
     // Add data provider
+    cy.get(`[data-cy="category-Data"]`).click()
     cy.get(`[data-cy="component-Data Provider"]`).click()
     cy.get('[data-cy="dataSource-prop-control"]').click()
     cy.get(".dropdown").contains("Multi Data").click()

From 07d45d8039b6e2a243c39d0093d852ef5c1d23e4 Mon Sep 17 00:00:00 2001
From: Andrew Kingston <aptkingston@ssl-mail.com>
Date: Tue, 23 Nov 2021 17:40:49 +0000
Subject: [PATCH 17/18] Update dynamic filter component styles and remove lots
 of settings

---
 packages/client/manifest.json                 | 37 -------------------
 .../client/src/components/app/Button.svelte   | 24 +++++++++++-
 .../app/dynamic-filter/DynamicFilter.svelte   | 24 ++++++------
 3 files changed, 34 insertions(+), 51 deletions(-)

diff --git a/packages/client/manifest.json b/packages/client/manifest.json
index 25e7840a66..26ccbb760e 100644
--- a/packages/client/manifest.json
+++ b/packages/client/manifest.json
@@ -2650,7 +2650,6 @@
     "name": "Dynamic Filter",
     "icon": "FilterEdit",
     "showSettingsBar": true,
-    "editable": true,
     "settings": [
       {
         "type": "dataProvider",
@@ -2669,34 +2668,6 @@
         "key": "text",
         "defaultValue": "Filter"
       },
-      {
-        "type": "select",
-        "showInBar": true,
-        "label": "Button variant",
-        "key": "type",
-        "options": [
-          {
-            "label": "Primary",
-            "value": "primary"
-          }, {
-            "label": "Secondary",
-            "value": "secondary"
-          },
-          {
-            "label": "Action",
-            "value": "cta"
-          },
-          {
-            "label": "Warning",
-            "value": "warning"
-          },
-          {
-            "label": "Over Background",
-            "value": "overBackground"
-          }
-        ],
-        "defaultValue": "primary"
-      },
       {
         "type": "select",
         "label": "Button size",
@@ -2721,14 +2692,6 @@
           }
         ],
         "defaultValue": "M"
-      },
-      {
-        "type": "boolean",
-        "label": "Quiet button",
-        "key": "quiet",
-        "showInBar": true,
-        "barIcon": "VisibilityOff",
-        "barTitle": "Quiet variant"
       }
     ]
   },
diff --git a/packages/client/src/components/app/Button.svelte b/packages/client/src/components/app/Button.svelte
index 5b06475b30..18bb935edb 100644
--- a/packages/client/src/components/app/Button.svelte
+++ b/packages/client/src/components/app/Button.svelte
@@ -12,6 +12,10 @@
   export let type = "primary"
   export let quiet = false
 
+  // For internal use only for now - not defined in the manifest
+  export let icon = null
+  export let active = false
+
   let node
 
   $: $component.editing && node?.focus()
@@ -35,10 +39,22 @@
   {disabled}
   use:styleable={$component.styles}
   on:click={onClick}
-  contenteditable={$component.editing}
+  contenteditable={$component.editing && !icon}
   on:blur={$component.editing ? updateText : null}
   bind:this={node}
+  class:active
 >
+  {#if icon}
+    <svg
+      class:hasText={componentText?.length > 0}
+      class="spectrum-Icon spectrum-Icon--size{size.toUpperCase()}"
+      focusable="false"
+      aria-hidden="true"
+      aria-label={icon}
+    >
+      <use xlink:href="#spectrum-icon-18-{icon}" />
+    </svg>
+  {/if}
   {componentText}
 </button>
 
@@ -56,4 +72,10 @@
   .spectrum-Button::after {
     display: none;
   }
+  .spectrum-Icon.hasText {
+    margin-right: var(--spectrum-button-primary-icon-gap);
+  }
+  .active {
+    color: var(--spectrum-global-color-blue-600);
+  }
 </style>
diff --git a/packages/client/src/components/app/dynamic-filter/DynamicFilter.svelte b/packages/client/src/components/app/dynamic-filter/DynamicFilter.svelte
index f85fe7bedd..9c12cdb658 100644
--- a/packages/client/src/components/app/dynamic-filter/DynamicFilter.svelte
+++ b/packages/client/src/components/app/dynamic-filter/DynamicFilter.svelte
@@ -10,8 +10,6 @@
   export let allowedFields
   export let text = ""
   export let size = "M"
-  export let type = "primary"
-  export let quiet = false
 
   const component = getContext("component")
   const { builderStore, ActionTypes, getAction } = getContext("sdk")
@@ -31,7 +29,7 @@
   )
   $: schema = dataProvider?.schema
   $: schemaFields = getSchemaFields(schema, allowedFields)
-  $: buttonText = getButtonText(text, filters)
+  $: buttonText = text || "Filter"
 
   // Add query extension to data provider
   $: {
@@ -43,14 +41,6 @@
     }
   }
 
-  const getButtonText = (text, filters) => {
-    let buttonText = text || "Filter"
-    if (filters?.length) {
-      buttonText += ` (${filters.length})`
-    }
-    return buttonText
-  }
-
   const getSchemaFields = (schema, allowedFields) => {
     let clonedSchema = {}
     if (!allowedFields?.length) {
@@ -80,10 +70,18 @@
   })
 </script>
 
-<Button onClick={openEditor} text={buttonText} {size} {type} {quiet} />
+<Button
+  onClick={openEditor}
+  icon="Properties"
+  text={buttonText}
+  {size}
+  type="secondary"
+  quiet
+  active={filters?.length > 0}
+/>
 
 <Modal bind:this={modal}>
-  <ModalContent title={text} size="XL" onConfirm={updateQuery}>
+  <ModalContent title={buttonText} size="XL" onConfirm={updateQuery}>
     <FilterModal bind:filters={tmpFilters} {schemaFields} />
   </ModalContent>
 </Modal>

From 837e70c9a8e130e3d28b5ba35b6435deb61fd417 Mon Sep 17 00:00:00 2001
From: Andrew Kingston <aptkingston@ssl-mail.com>
Date: Wed, 24 Nov 2021 08:20:23 +0000
Subject: [PATCH 18/18] Remove text setting from dynamic filter component

---
 packages/client/manifest.json                               | 6 ------
 .../src/components/app/dynamic-filter/DynamicFilter.svelte  | 6 ++----
 2 files changed, 2 insertions(+), 10 deletions(-)

diff --git a/packages/client/manifest.json b/packages/client/manifest.json
index 26ccbb760e..d16b117215 100644
--- a/packages/client/manifest.json
+++ b/packages/client/manifest.json
@@ -2662,12 +2662,6 @@
         "key": "allowedFields",
         "placeholder": "All fields"
       },
-      {
-        "type": "text",
-        "label": "Button text",
-        "key": "text",
-        "defaultValue": "Filter"
-      },
       {
         "type": "select",
         "label": "Button size",
diff --git a/packages/client/src/components/app/dynamic-filter/DynamicFilter.svelte b/packages/client/src/components/app/dynamic-filter/DynamicFilter.svelte
index 9c12cdb658..20909d011c 100644
--- a/packages/client/src/components/app/dynamic-filter/DynamicFilter.svelte
+++ b/packages/client/src/components/app/dynamic-filter/DynamicFilter.svelte
@@ -8,7 +8,6 @@
 
   export let dataProvider
   export let allowedFields
-  export let text = ""
   export let size = "M"
 
   const component = getContext("component")
@@ -29,7 +28,6 @@
   )
   $: schema = dataProvider?.schema
   $: schemaFields = getSchemaFields(schema, allowedFields)
-  $: buttonText = text || "Filter"
 
   // Add query extension to data provider
   $: {
@@ -73,7 +71,7 @@
 <Button
   onClick={openEditor}
   icon="Properties"
-  text={buttonText}
+  text="Filter"
   {size}
   type="secondary"
   quiet
@@ -81,7 +79,7 @@
 />
 
 <Modal bind:this={modal}>
-  <ModalContent title={buttonText} size="XL" onConfirm={updateQuery}>
+  <ModalContent title="Edit filters" size="XL" onConfirm={updateQuery}>
     <FilterModal bind:filters={tmpFilters} {schemaFields} />
   </ModalContent>
 </Modal>