From 062149af7e71799828dadf30de3ac6c9e2d201d9 Mon Sep 17 00:00:00 2001
From: Adria Navarro <adria@budibase.com>
Date: Tue, 21 Jan 2025 14:12:31 +0100
Subject: [PATCH] Move from store to utils

---
 .../DataSourceSelect/DataSourceSelect.svelte  |  8 ++-
 .../settings/controls/TableSelect.svelte      | 11 ++-
 packages/builder/src/helpers/data/format.js   | 36 ++++++++++
 .../src/stores/builder/friendlyNames.ts       | 71 -------------------
 packages/builder/src/stores/builder/index.js  |  3 -
 5 files changed, 49 insertions(+), 80 deletions(-)
 delete mode 100644 packages/builder/src/stores/builder/friendlyNames.ts

diff --git a/packages/builder/src/components/design/settings/controls/DataSourceSelect/DataSourceSelect.svelte b/packages/builder/src/components/design/settings/controls/DataSourceSelect/DataSourceSelect.svelte
index f5f7c3ed9d..e47cf1df3e 100644
--- a/packages/builder/src/components/design/settings/controls/DataSourceSelect/DataSourceSelect.svelte
+++ b/packages/builder/src/components/design/settings/controls/DataSourceSelect/DataSourceSelect.svelte
@@ -18,13 +18,14 @@
   } from "@budibase/bbui"
   import { createEventDispatcher } from "svelte"
   import {
+    tables as tablesStore,
     queries as queriesStore,
+    viewsV2 as viewsV2Store,
     views as viewsStore,
     selectedScreen,
     componentStore,
     datasources,
     integrations,
-    friendlyNamesStore,
   } from "@/stores/builder"
   import BindingBuilder from "@/components/integration/QueryBindingBuilder.svelte"
   import IntegrationQueryEditor from "@/components/integration/index.svelte"
@@ -33,6 +34,7 @@
   import ClientBindingPanel from "@/components/common/bindings/ClientBindingPanel.svelte"
   import DataSourceCategory from "@/components/design/settings/controls/DataSourceSelect/DataSourceCategory.svelte"
   import { API } from "@/api"
+  import { sortAndFormat } from "@/helpers/data/format"
 
   export let value = {}
   export let otherSources
@@ -49,13 +51,13 @@
   let modal
 
   $: text = value?.label ?? "Choose an option"
-  $: tables = $friendlyNamesStore.tables
+  $: tables = sortAndFormat.tables($tablesStore.list, $datasources.list)
   $: viewsV1 = $viewsStore.list.map(view => ({
     ...view,
     label: view.name,
     type: "view",
   }))
-  $: viewsV2 = $friendlyNamesStore.viewsV2
+  $: viewsV2 = sortAndFormat.viewsV2($viewsV2Store.list, $datasources.list)
   $: views = [...(viewsV1 || []), ...(viewsV2 || [])]
   $: queries = $queriesStore.list
     .filter(q => showAllQueries || q.queryVerb === "read" || q.readable)
diff --git a/packages/builder/src/components/design/settings/controls/TableSelect.svelte b/packages/builder/src/components/design/settings/controls/TableSelect.svelte
index 067b34a38f..146decda91 100644
--- a/packages/builder/src/components/design/settings/controls/TableSelect.svelte
+++ b/packages/builder/src/components/design/settings/controls/TableSelect.svelte
@@ -1,8 +1,13 @@
 <script>
   import { Popover, Select } from "@budibase/bbui"
   import { createEventDispatcher, onMount } from "svelte"
-  import { friendlyNamesStore } from "@/stores/builder"
+  import {
+    tables as tableStore,
+    datasources as datasourceStore,
+    viewsV2 as viewsV2Store,
+  } from "@/stores/builder"
   import DataSourceCategory from "./DataSourceSelect/DataSourceCategory.svelte"
+  import { sortAndFormat } from "@/helpers/data/format"
 
   export let value
 
@@ -10,8 +15,8 @@
 
   const dispatch = createEventDispatcher()
 
-  $: tables = $friendlyNamesStore.tables
-  $: views = $friendlyNamesStore.viewsV2
+  $: tables = sortAndFormat.tables($tableStore.list, $datasourceStore.list)
+  $: views = sortAndFormat.viewsV2($viewsV2Store.list, $datasourceStore.list)
   $: options = [...(tables || []), ...(views || [])]
 
   $: text = value?.label ?? "Choose an option"
diff --git a/packages/builder/src/helpers/data/format.js b/packages/builder/src/helpers/data/format.js
index d6df36a337..a756558196 100644
--- a/packages/builder/src/helpers/data/format.js
+++ b/packages/builder/src/helpers/data/format.js
@@ -38,3 +38,39 @@ export const tableSelect = {
     resourceId: view.id,
   }),
 }
+
+export const sortAndFormat = {
+  tables: (tables, datasources) => {
+    return tables
+      .map(table => {
+        const formatted = datasourceSelect.table(table, datasources)
+        return {
+          ...formatted,
+          label: formatted.label,
+          datasourceName: formatted.datasourceName,
+          resourceId: table._id,
+        }
+      })
+      .sort((a, b) => {
+        // sort tables alphabetically, grouped by datasource
+        const dsA = a.datasourceName ?? ""
+        const dsB = b.datasourceName ?? ""
+
+        const dsComparison = dsA.localeCompare(dsB)
+        if (dsComparison !== 0) {
+          return dsComparison
+        }
+        return a.label.localeCompare(b.label)
+      })
+  },
+  viewsV2: (views, datasources) => {
+    return views.map(view => {
+      const formatted = datasourceSelect.viewV2(view, datasources)
+      return {
+        label: formatted.label,
+        datasourceName: formatted.datasourceName,
+        resourceId: view.id,
+      }
+    })
+  },
+}
diff --git a/packages/builder/src/stores/builder/friendlyNames.ts b/packages/builder/src/stores/builder/friendlyNames.ts
deleted file mode 100644
index bc97b68687..0000000000
--- a/packages/builder/src/stores/builder/friendlyNames.ts
+++ /dev/null
@@ -1,71 +0,0 @@
-import { derived } from "svelte/store"
-import { Socket } from "socket.io-client"
-import { DerivedBudiStore } from "../BudiStore.js"
-import { datasourceSelect as format } from "@/helpers/data/format"
-import { tables } from "./tables.js"
-import { datasources } from "./datasources.js"
-import { viewsV2 } from "./viewsV2.js"
-
-interface FriendlyNamesState {}
-
-interface DerivedFriendlyNamesState {
-  tables: {
-    label: string
-    resourceId: string
-    datasourceName: string
-  }[]
-  viewsV2: {
-    label: string
-    resourceId: string
-    datasourceName: string
-  }[]
-}
-
-export class FriendlyNamesStore extends DerivedBudiStore<
-  FriendlyNamesState,
-  DerivedFriendlyNamesState
-> {
-  websocket?: Socket
-
-  constructor() {
-    const makeDerivedStore = () => {
-      return derived(
-        [tables, datasources, viewsV2],
-        ([$tables, $datasources, $viewsV2]) => ({
-          tables: $tables.list
-            .map(table => {
-              const formatted = format.table(table, $datasources.list)
-              return {
-                label: formatted.label,
-                datasourceName: formatted.datasourceName,
-                resourceId: table._id!,
-              }
-            })
-            .sort((a, b) => {
-              // sort tables alphabetically, grouped by datasource
-              const dsA = a.datasourceName ?? ""
-              const dsB = b.datasourceName ?? ""
-
-              const dsComparison = dsA.localeCompare(dsB)
-              if (dsComparison !== 0) {
-                return dsComparison
-              }
-              return a.label.localeCompare(b.label)
-            }),
-          viewsV2: $viewsV2.list.map(view => {
-            const formatted = format.viewV2(view, $datasources.list)
-            return {
-              label: formatted.label,
-              datasourceName: formatted.datasourceName,
-              resourceId: view.id,
-            }
-          }),
-        })
-      )
-    }
-
-    super({}, makeDerivedStore)
-  }
-}
-
-export const friendlyNamesStore = new FriendlyNamesStore()
diff --git a/packages/builder/src/stores/builder/index.js b/packages/builder/src/stores/builder/index.js
index 5701a5add0..08d87bebf5 100644
--- a/packages/builder/src/stores/builder/index.js
+++ b/packages/builder/src/stores/builder/index.js
@@ -32,8 +32,6 @@ import { rowActions } from "./rowActions"
 import componentTreeNodesStore from "./componentTreeNodes"
 import { appPublished } from "./published"
 
-import { friendlyNamesStore } from "./friendlyNames"
-
 export {
   componentTreeNodesStore,
   layoutStore,
@@ -69,7 +67,6 @@ export {
   snippets,
   rowActions,
   appPublished,
-  friendlyNamesStore,
 }
 
 export const reset = () => {