diff --git a/packages/builder/src/components/design/PropertiesPanel/PropertyControls/FilterEditor/FilterDrawer.svelte b/packages/builder/src/components/design/PropertiesPanel/PropertyControls/FilterEditor/FilterDrawer.svelte index 95a5f54e32..aa191ce0ea 100644 --- a/packages/builder/src/components/design/PropertiesPanel/PropertyControls/FilterEditor/FilterDrawer.svelte +++ b/packages/builder/src/components/design/PropertiesPanel/PropertyControls/FilterEditor/FilterDrawer.svelte @@ -54,8 +54,9 @@ } const onFieldChange = (expression, field) => { - // Update the field type + // Update the field types expression.type = enrichedSchemaFields.find(x => x.name === field)?.type + expression.externalType = getSchema(expression)?.externalType // Ensure a valid operator is set const validOperators = LuceneUtils.getValidOperatorsForType( diff --git a/packages/frontend-core/src/constants.js b/packages/frontend-core/src/constants.js index 33cf1b7d1c..9ca47de23f 100644 --- a/packages/frontend-core/src/constants.js +++ b/packages/frontend-core/src/constants.js @@ -63,3 +63,25 @@ export const TableNames = { * - Coerce types for search endpoint */ export const ApiVersion = "1" + +/** + * Maximum minimum range for SQL number values + */ +export const SqlNumberTypeRangeMap = { + integer: { + max: 2147483647, + min: -2147483648, + }, + int: { + max: 2147483647, + min: -2147483648, + }, + smallint: { + max: 32767, + min: -32768, + }, + mediumint: { + max: 8388607, + min: -8388608, + }, +} diff --git a/packages/frontend-core/src/utils/lucene.js b/packages/frontend-core/src/utils/lucene.js index eaf681a78b..8f59a2bd9d 100644 --- a/packages/frontend-core/src/utils/lucene.js +++ b/packages/frontend-core/src/utils/lucene.js @@ -1,5 +1,5 @@ import { Helpers } from "@budibase/bbui" -import { OperatorOptions } from "../constants" +import { OperatorOptions, SqlNumberTypeRangeMap } from "../constants" /** * Returns the valid operator options for a certain data type @@ -94,7 +94,7 @@ export const buildLuceneQuery = filter => { } if (Array.isArray(filter)) { filter.forEach(expression => { - let { operator, field, type, value } = expression + let { operator, field, type, value, externalType } = expression // Parse all values into correct types if (type === "datetime" && value) { value = new Date(value).toISOString() @@ -106,16 +106,14 @@ export const buildLuceneQuery = filter => { value = `${value}`?.toLowerCase() === "true" } if (operator.startsWith("range")) { + const minint = + SqlNumberTypeRangeMap[externalType]?.min || Number.MIN_SAFE_INTEGER + const maxint = + SqlNumberTypeRangeMap[externalType]?.max || Number.MAX_SAFE_INTEGER if (!query.range[field]) { query.range[field] = { - low: - type === "number" - ? Number.MIN_SAFE_INTEGER - : "0000-00-00T00:00:00.000Z", - high: - type === "number" - ? Number.MAX_SAFE_INTEGER - : "9999-00-00T00:00:00.000Z", + low: type === "number" ? minint : "0000-00-00T00:00:00.000Z", + high: type === "number" ? maxint : "9999-00-00T00:00:00.000Z", } } if (operator === "rangeLow" && value != null && value !== "") { diff --git a/packages/server/src/integrations/microsoftSqlServer.ts b/packages/server/src/integrations/microsoftSqlServer.ts index a7b9906481..530e569405 100644 --- a/packages/server/src/integrations/microsoftSqlServer.ts +++ b/packages/server/src/integrations/microsoftSqlServer.ts @@ -246,6 +246,7 @@ module MSSQLModule { autocolumn: !!autoColumns.find((col: string) => col === name), name: name, ...convertSqlType(def.DATA_TYPE), + externalType: def.DATA_TYPE, } } tables[tableName] = { diff --git a/packages/server/src/integrations/mysql.ts b/packages/server/src/integrations/mysql.ts index 7a06592ef7..287817ef27 100644 --- a/packages/server/src/integrations/mysql.ts +++ b/packages/server/src/integrations/mysql.ts @@ -232,6 +232,7 @@ module MySQLModule { autocolumn: isAuto, constraints, ...convertSqlType(column.Type), + externalType: column.Type, } } if (!tables[tableName]) { diff --git a/packages/server/src/integrations/postgres.ts b/packages/server/src/integrations/postgres.ts index f0c5911476..0ac55a9cd0 100644 --- a/packages/server/src/integrations/postgres.ts +++ b/packages/server/src/integrations/postgres.ts @@ -271,6 +271,7 @@ module PostgresModule { autocolumn: isAuto, name: columnName, ...convertSqlType(column.data_type), + externalType: column.data_type, } }