From 1067f06fd60310b7960910cc607851e0e05bd5b9 Mon Sep 17 00:00:00 2001 From: Andrew Kingston Date: Thu, 2 Mar 2023 13:39:47 +0000 Subject: [PATCH] Improve performance by removing keyed each blocks and fix reorder target styling --- .../frontend-core/src/components/sheet/SheetCell.svelte | 2 +- .../src/components/sheet/cells/OptionsCell.svelte | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/frontend-core/src/components/sheet/SheetCell.svelte b/packages/frontend-core/src/components/sheet/SheetCell.svelte index 0e2415200d..cdc078befc 100644 --- a/packages/frontend-core/src/components/sheet/SheetCell.svelte +++ b/packages/frontend-core/src/components/sheet/SheetCell.svelte @@ -93,7 +93,7 @@ right: 0; background: var(--spectrum-global-color-blue-400); width: 2px; - height: calc(var(--cell-height) + 1px); + height: calc(var(--cell-height) + 2px); } /* Label cells */ diff --git a/packages/frontend-core/src/components/sheet/cells/OptionsCell.svelte b/packages/frontend-core/src/components/sheet/cells/OptionsCell.svelte index 6f4e3dea42..8754105c61 100644 --- a/packages/frontend-core/src/components/sheet/cells/OptionsCell.svelte +++ b/packages/frontend-core/src/components/sheet/cells/OptionsCell.svelte @@ -57,7 +57,7 @@ on:click={editable ? toggleOpen : null} >
- {#each values as val (val)} + {#each values as val} {@const color = getOptionColor(val)} {#if color}
@@ -77,7 +77,7 @@ {/if} {#if open}
- {#each values as val (val)} + {#each values as val} {@const color = getOptionColor(val)}
toggleOption(val)}>
@@ -89,7 +89,7 @@ />
{/each} - {#each unselectedOptions as option (option)} + {#each unselectedOptions as option}
toggleOption(option)}>
{option}