From 10f77c83b6ef08522da14181f1aabda05f213cca Mon Sep 17 00:00:00 2001
From: Adria Navarro <adria@budibase.com>
Date: Mon, 3 Jun 2024 17:24:30 +0200
Subject: [PATCH] Don't allow selecting required columns

---
 .../grid/controls/ColumnsSettingButton.svelte     | 15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)

diff --git a/packages/frontend-core/src/components/grid/controls/ColumnsSettingButton.svelte b/packages/frontend-core/src/components/grid/controls/ColumnsSettingButton.svelte
index 43efda80fa..d4ae71280b 100644
--- a/packages/frontend-core/src/components/grid/controls/ColumnsSettingButton.svelte
+++ b/packages/frontend-core/src/components/grid/controls/ColumnsSettingButton.svelte
@@ -3,6 +3,7 @@
   import { ActionButton, Popover, Icon, notifications } from "@budibase/bbui"
   import { getColumnIcon } from "../lib/utils"
   import ToggleActionButtonGroup from "./ToggleActionButtonGroup.svelte"
+  import { helpers } from "@budibase/shared-core"
 
   export let allowViewReadonlyColumns = false
 
@@ -37,13 +38,17 @@
   }
 
   $: displayColumns = allColumns.map(c => {
+    const isRequired = helpers.schema.isRequired(c.schema.constraints)
     const isDisplayColumn = $stickyColumn === c
 
+    const requiredTooltip = isRequired && "Required columns must be writable"
+
     const options = [
       {
         icon: "Edit",
         value: PERMISSION_OPTIONS.WRITABLE,
-        tooltip: "Writable",
+        tooltip: requiredTooltip || "Writable",
+        disabled: isRequired,
       },
     ]
     if ($datasource.type === "viewV2") {
@@ -51,17 +56,17 @@
         icon: "Visibility",
         value: PERMISSION_OPTIONS.READONLY,
         tooltip: allowViewReadonlyColumns
-          ? "Read only"
+          ? requiredTooltip || "Read only"
           : "Read only (premium feature)",
-        disabled: !allowViewReadonlyColumns,
+        disabled: !allowViewReadonlyColumns || isRequired,
       })
     }
 
     options.push({
       icon: "VisibilityOff",
       value: PERMISSION_OPTIONS.HIDDEN,
-      tooltip: "Hidden",
-      disabled: isDisplayColumn,
+      tooltip: requiredTooltip || "Hidden",
+      disabled: isDisplayColumn || isRequired,
       tooltip: isDisplayColumn && "Display column cannot be hidden",
     })