MirrorSave
/
budibase
mirror of https://github.com/Budibase/budibase.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix

This commit is contained in:
Adria Navarro 2024-10-17 11:52:03 +02:00
parent 15bb730c59
commit 1155be4530
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
packages/backend-core/src/security/roles.ts
View File

@ -336,7 +336,7 @@ export async function getAllRoles(appId?: string): Promise<RoleDoc[]> {
// exclude internal roles like builder // exclude internal roles like builder
let externalBuiltinRoles = [] let externalBuiltinRoles = []
if (db && !(await shouldIncludePowerRole(db))) { if (!db || (await shouldIncludePowerRole(db))) {
externalBuiltinRoles = [ externalBuiltinRoles = [
BUILTIN_IDS.ADMIN, BUILTIN_IDS.ADMIN,
BUILTIN_IDS.POWER, BUILTIN_IDS.POWER,
@ -386,11 +386,13 @@ export async function getAllRoles(appId?: string): Promise<RoleDoc[]> {
async function shouldIncludePowerRole(db: Database) { async function shouldIncludePowerRole(db: Database) {
const app = await db.get<App>(DocumentType.APP_METADATA) const app = await db.get<App>(DocumentType.APP_METADATA)
const { creationVersion } = app const { creationVersion } = app
if (semver.gte(creationVersion || "", "3.0.0")) { if (!creationVersion) {
// Old apps don't have creationVersion, so we should include it for backward compatibility
return true return true
} }
return false const isGreaterThan3x = semver.gte(creationVersion, "3.0.0")
return !isGreaterThan3x
} }
export class AccessController { export class AccessController {