From 7ef07b61ee19cc766cd4b6ee4b35fd370e2f5420 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Keviin=20=C3=85berg=20Kultalahti?= Date: Mon, 1 Mar 2021 17:33:52 +0100 Subject: [PATCH 1/6] removes unused code in automation and backend sections --- .../AutomationPanel/AutomationPanel.svelte | 12 --------- .../CreateAutomationModal.svelte | 7 ------ .../EditAutomationPopover.svelte | 25 ------------------- .../Shared/CreateWebhookModal.svelte | 3 --- .../components/backend/DataTable/Table.svelte | 4 --- .../backend/DataTable/modals/DeleteRow.svelte | 4 --- .../popovers/CalculatePopover.svelte | 2 +- .../popovers/CreateViewPopover.svelte | 2 +- .../DataTable/popovers/ExportPopover.svelte | 1 - .../DataTable/popovers/GroupByPopover.svelte | 2 +- .../popovers/ManageAccessPopover.svelte | 3 --- .../DatasourceNavigator.svelte | 6 ----- .../TableIntegrationMenu/index.svelte | 3 --- .../modals/CreateDatasourceModal.svelte | 3 --- .../popovers/EditTablePopover.svelte | 2 -- 15 files changed, 3 insertions(+), 76 deletions(-) diff --git a/packages/builder/src/components/automation/AutomationPanel/AutomationPanel.svelte b/packages/builder/src/components/automation/AutomationPanel/AutomationPanel.svelte index e09803e130..7d56867d03 100644 --- a/packages/builder/src/components/automation/AutomationPanel/AutomationPanel.svelte +++ b/packages/builder/src/components/automation/AutomationPanel/AutomationPanel.svelte @@ -2,10 +2,6 @@ import AutomationList from "./AutomationList.svelte" import CreateAutomationModal from "./CreateAutomationModal.svelte" import { Modal } from "@budibase/bbui" - import { automationStore, backendUiStore } from "builderStore" - import { notifier } from "builderStore/store/notifications" - - let selectedTab = "AUTOMATIONS" let modal @@ -40,12 +36,4 @@ cursor: pointer; color: var(--blue); } - - span:not(.selected) { - color: var(--grey-5); - } - - span:not(.selected):hover { - color: var(--ink); - } diff --git a/packages/builder/src/components/automation/AutomationPanel/CreateAutomationModal.svelte b/packages/builder/src/components/automation/AutomationPanel/CreateAutomationModal.svelte index 5bd535087d..804dceec87 100644 --- a/packages/builder/src/components/automation/AutomationPanel/CreateAutomationModal.svelte +++ b/packages/builder/src/components/automation/AutomationPanel/CreateAutomationModal.svelte @@ -8,13 +8,6 @@ $: valid = !!name $: instanceId = $backendUiStore.selectedDatabase._id - $: appId = $store.appId - - function sleep(ms) { - return new Promise(resolve => { - setTimeout(resolve, ms) - }) - } async function createAutomation() { await automationStore.actions.create({ diff --git a/packages/builder/src/components/automation/AutomationPanel/EditAutomationPopover.svelte b/packages/builder/src/components/automation/AutomationPanel/EditAutomationPopover.svelte index a3ec5b2ae5..eb983dc948 100644 --- a/packages/builder/src/components/automation/AutomationPanel/EditAutomationPopover.svelte +++ b/packages/builder/src/components/automation/AutomationPanel/EditAutomationPopover.svelte @@ -60,29 +60,4 @@ div.icon i { font-size: 16px; } - - ul { - list-style: none; - margin: 0; - padding: var(--spacing-s) 0; - } - - li { - display: flex; - font-family: var(--font-sans); - font-size: var(--font-size-xs); - color: var(--ink); - padding: var(--spacing-s) var(--spacing-m); - margin: auto 0; - align-items: center; - cursor: pointer; - } - - li:hover { - background-color: var(--grey-2); - } - - li:active { - color: var(--blue); - } diff --git a/packages/builder/src/components/automation/Shared/CreateWebhookModal.svelte b/packages/builder/src/components/automation/Shared/CreateWebhookModal.svelte index 8be9400caf..a1cb81ab29 100644 --- a/packages/builder/src/components/automation/Shared/CreateWebhookModal.svelte +++ b/packages/builder/src/components/automation/Shared/CreateWebhookModal.svelte @@ -92,9 +92,6 @@ text-align: center; color: var(--blue); } - h5 { - margin: 0; - } code { padding: 1px 4px 1px 4px; font-size: 14px; diff --git a/packages/builder/src/components/backend/DataTable/Table.svelte b/packages/builder/src/components/backend/DataTable/Table.svelte index ae5b7d1dbb..61fa01c09d 100644 --- a/packages/builder/src/components/backend/DataTable/Table.svelte +++ b/packages/builder/src/components/backend/DataTable/Table.svelte @@ -246,10 +246,6 @@ color: var(--ink); } - tbody tr:hover { - background: var(--grey-1); - } - :global(.ag-filter) { background: var(--background); padding: var(--spacing-s); diff --git a/packages/builder/src/components/backend/DataTable/modals/DeleteRow.svelte b/packages/builder/src/components/backend/DataTable/modals/DeleteRow.svelte index b9f9cf32e1..a28d90de0c 100644 --- a/packages/builder/src/components/backend/DataTable/modals/DeleteRow.svelte +++ b/packages/builder/src/components/backend/DataTable/modals/DeleteRow.svelte @@ -28,10 +28,6 @@ title="Confirm Deletion" /> From ff2b0fb5df462eb58f5df1ca62f1f8b039f72a9b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Keviin=20=C3=85berg=20Kultalahti?= Date: Mon, 1 Mar 2021 17:49:29 +0100 Subject: [PATCH 6/6] remove unused code in routes --- .../src/pages/[application]/_reset.svelte | 5 ---- .../[selectedDatasource]/[query]/index.svelte | 3 --- .../[selectedDatasource]/index.svelte | 5 ---- .../design/[assetType]/_layout.svelte | 27 ------------------- packages/builder/src/pages/index.svelte | 1 - 5 files changed, 41 deletions(-) diff --git a/packages/builder/src/pages/[application]/_reset.svelte b/packages/builder/src/pages/[application]/_reset.svelte index 71a0e918f2..2411fad0c9 100644 --- a/packages/builder/src/pages/[application]/_reset.svelte +++ b/packages/builder/src/pages/[application]/_reset.svelte @@ -130,11 +130,6 @@ border-bottom: 1px solid var(--grey-2); } - .content > div { - height: 100%; - width: 100%; - } - .toprightnav { display: flex; flex-direction: row; diff --git a/packages/builder/src/pages/[application]/data/datasource/[selectedDatasource]/[query]/index.svelte b/packages/builder/src/pages/[application]/data/datasource/[selectedDatasource]/[query]/index.svelte index 3a51a3a75f..2080480fce 100644 --- a/packages/builder/src/pages/[application]/data/datasource/[selectedDatasource]/[query]/index.svelte +++ b/packages/builder/src/pages/[application]/data/datasource/[selectedDatasource]/[query]/index.svelte @@ -1,11 +1,8 @@