From 12961806ff621aaae4725ac910daf860831db3e1 Mon Sep 17 00:00:00 2001
From: Andrew Kingston <andrew@kingston.dev>
Date: Thu, 9 Jun 2022 15:33:41 +0100
Subject: [PATCH] Invalidate cached API responses when bad response statuses
 are recevied and invalidate entire API cache when switching role

---
 packages/client/src/api/api.js          | 6 +++++-
 packages/client/src/stores/devTools.js  | 2 ++
 packages/frontend-core/src/api/index.js | 8 +++++++-
 3 files changed, 14 insertions(+), 2 deletions(-)

diff --git a/packages/client/src/api/api.js b/packages/client/src/api/api.js
index fdd83bd963..b96ad9c9e7 100644
--- a/packages/client/src/api/api.js
+++ b/packages/client/src/api/api.js
@@ -34,7 +34,11 @@ export const API = createAPIClient({
   // Or we could check error.status and redirect to login on a 403 etc.
   onError: error => {
     const { status, method, url, message, handled } = error || {}
-    const ignoreErrorUrls = ["bbtel", "/api/global/self"]
+    const ignoreErrorUrls = [
+      "bbtel",
+      "/api/global/self",
+      "/api/tables/ta_users",
+    ]
 
     // Log any errors that we haven't manually handled
     if (!handled) {
diff --git a/packages/client/src/stores/devTools.js b/packages/client/src/stores/devTools.js
index 3db46af608..1558f54862 100644
--- a/packages/client/src/stores/devTools.js
+++ b/packages/client/src/stores/devTools.js
@@ -3,6 +3,7 @@ import { createLocalStorageStore } from "@budibase/frontend-core"
 import { appStore } from "./app"
 import { initialise } from "./initialise"
 import { authStore } from "./auth"
+import { API } from "../api"
 
 const initialState = {
   enabled: false,
@@ -41,6 +42,7 @@ const createDevToolStore = () => {
       ...state,
       role: role === "self" ? null : role,
     }))
+    API.invalidateCache()
     await authStore.actions.fetchUser()
     await initialise()
   }
diff --git a/packages/frontend-core/src/api/index.js b/packages/frontend-core/src/api/index.js
index 164f51aae5..fddbffde4a 100644
--- a/packages/frontend-core/src/api/index.js
+++ b/packages/frontend-core/src/api/index.js
@@ -57,6 +57,7 @@ export const createAPIClient = config => {
     ...defaultAPIClientConfig,
     ...config,
   }
+  let cache = {}
 
   // Generates an error object from an API response
   const makeErrorFromResponse = async (response, method) => {
@@ -139,6 +140,7 @@ export const createAPIClient = config => {
         credentials: "same-origin",
       })
     } catch (error) {
+      delete cache[url]
       throw makeError("Failed to send request", { url, method })
     }
 
@@ -151,9 +153,11 @@ export const createAPIClient = config => {
           return await response.json()
         }
       } catch (error) {
+        delete cache[url]
         return null
       }
     } else {
+      delete cache[url]
       throw await makeErrorFromResponse(response, method)
     }
   }
@@ -161,7 +165,6 @@ export const createAPIClient = config => {
   // Performs an API call to the server and caches the response.
   // Future invocation for this URL will return the cached result instead of
   // hitting the server again.
-  let cache = {}
   const makeCachedApiCall = async params => {
     const identifier = params.url
     if (!identifier) {
@@ -206,6 +209,9 @@ export const createAPIClient = config => {
     error: message => {
       throw makeError(message)
     },
+    invalidateCache: () => {
+      cache = {}
+    },
   }
 
   // Attach all endpoints