Minor fixes after testing manual backup system.

packages/backend-core/src/context/index.ts

@@ -53,6 +53,9 @@ export const getTenantIDFromAppID = (appId: string) => {
   if (!appId) {
     return null
   }
+  if (!isMultiTenant()) {
+    return DEFAULT_TENANT_ID
+  }
   const split = appId.split(SEPARATOR)
   const hasDev = split[1] === DocumentType.DEV
   if ((hasDev && split.length === 3) || (!hasDev && split.length === 2)) {

packages/server/src/api/routes/index.ts

@@ -34,6 +34,8 @@ export { default as publicRoutes } from "./public"
 const appBackupRoutes = api.appBackups
 const scheduleRoutes = api.schedules
 export const mainRoutes: Router[] = [
+  appBackupRoutes,
+  backupRoutes,
   authRoutes,
   deployRoutes,
   layoutRoutes,
@@ -53,16 +55,14 @@ export const mainRoutes: Router[] = [
   permissionRoutes,
   datasourceRoutes,
   queryRoutes,
-  backupRoutes,
   metadataRoutes,
   devRoutes,
   cloudRoutes,
-  // these need to be handled last as they still use /api/:tableId
-  // this could be breaking as koa may recognise other routes as this
-  tableRoutes,
   rowRoutes,
   migrationRoutes,
   pluginRoutes,
-  appBackupRoutes,
   scheduleRoutes,
+  // these need to be handled last as they still use /api/:tableId
+  // this could be breaking as koa may recognise other routes as this
+  tableRoutes,
 ]

packages/server/src/sdk/app/backups/backup.ts

@@ -10,30 +10,32 @@ export async function init() {
     const appId = job.data.appId,
       trigger = job.data.trigger,
       name = job.data.name
-    const createdAt = new Date().toISOString()
+    const tenantId = tenancy.getTenantIDFromAppID(appId)
-    const tarPath = await exportApp(appId, { tar: true })
+    await tenancy.doInTenant(tenantId, async () => {
-    let filename = `${appId}/backup-${createdAt}.tar.gz`
+      const createdAt = new Date().toISOString()
-    // add the tenant to the bucket path if backing up within a multi-tenant environment
+      const tarPath = await exportApp(appId, { tar: true })
-    if (env.MULTI_TENANCY) {
+      let filename = `${appId}/backup-${createdAt}.tar.gz`
-      const tenantId = tenancy.getTenantIDFromAppID(appId)
+      // add the tenant to the bucket path if backing up within a multi-tenant environment
-      filename = `${tenantId}/${filename}`
+      if (env.MULTI_TENANCY) {
-    }
+        filename = `${tenantId}/${filename}`
-    const bucket = objectStore.ObjectStoreBuckets.BACKUPS
+      }
-    const metadata = {
+      const bucket = objectStore.ObjectStoreBuckets.BACKUPS
-      appId,
+      const metadata = {
-      createdAt,
+        appId,
-      trigger,
+        createdAt,
-      name,
+        trigger,
-    }
+        name,
-    await objectStore.upload({
+      }
-      path: tarPath,
+      await objectStore.upload({
-      type: "application/gzip",
+        path: tarPath,
-      bucket,
+        type: "application/gzip",
-      filename,
+        bucket,
-      metadata,
+        filename,
+        metadata,
+      })
+      await backups.storeAppBackupMetadata(filename, metadata)
+      // clear up the tarball after uploading it
+      fs.rmSync(tarPath)
     })
-    await backups.storeAppBackupMetadata(filename, metadata)
-    // clear up the tarball after uploading it
-    fs.rmSync(tarPath)
   })
 }

packages/types/src/sdk/koa.ts

@@ -7,7 +7,12 @@ export interface ContextUser extends User {
   license: License
 }
 
-export interface BBContext extends Context {
+export interface BBContext {
   user?: ContextUser
-  body: any
+  request: {
+    body: any
+  }
+  params: any
+  body?: any
+  redirect?: any
 }