Merge pull request #238 from Budibase/fix-reload-performance-issue

fix builder component library loading issue
This commit is contained in:
Martin McKeaveney 2020-05-18 15:17:44 +01:00 committed by GitHub
commit 13a18c72f3
6 changed files with 4 additions and 18 deletions

View File

@ -11,10 +11,7 @@ import {
makePropsSafe, makePropsSafe,
getBuiltin, getBuiltin,
} from "components/userInterface/pagesParsing/createProps" } from "components/userInterface/pagesParsing/createProps"
import { import { fetchComponentLibDefinitions } from "../loadComponentLibraries"
fetchComponentLibModules,
fetchComponentLibDefinitions,
} from "../loadComponentLibraries"
import { buildCodeForScreens } from "../buildCodeForScreens" import { buildCodeForScreens } from "../buildCodeForScreens"
import { generate_screen_css } from "../generate_css" import { generate_screen_css } from "../generate_css"
import { insertCodeMetadata } from "../insertCodeMetadata" import { insertCodeMetadata } from "../insertCodeMetadata"
@ -93,7 +90,7 @@ const setPackage = (store, initial) => async pkg => {
}, },
} }
initial.libraries = await fetchComponentLibModules(pkg.application) initial.libraries = pkg.application.componentLibraries
initial.components = await fetchComponentLibDefinitions(pkg.application._id) initial.components = await fetchComponentLibDefinitions(pkg.application._id)
initial.appname = pkg.application.name initial.appname = pkg.application.name
initial.appId = pkg.application._id initial.appId = pkg.application._id

View File

@ -46,7 +46,7 @@
$: frontendDefinition = { $: frontendDefinition = {
appId: $store.appId, appId: $store.appId,
libraries: Object.keys($store.libraries), libraries: $store.libraries,
page: $store.currentPreviewItem, page: $store.currentPreviewItem,
screens: screensExist screens: screensExist
? $store.currentPreviewItem._screens ? $store.currentPreviewItem._screens

View File

@ -36,11 +36,6 @@
sortBy("title"), sortBy("title"),
]) ])
const isScreenSelected = component =>
component.component &&
$store.currentPreviewItem &&
component.component.name === $store.currentPreviewItem.name
const confirmDeleteComponent = component => { const confirmDeleteComponent = component => {
componentToDelete = component componentToDelete = component
confirmDeleteDialog.show() confirmDeleteDialog.show()

View File

@ -34,11 +34,6 @@
title: lastPartOfName(layout), title: lastPartOfName(layout),
} }
const isScreenSelected = component =>
component.component &&
$store.currentPreviewItem &&
component.component.name === $store.currentPreviewItem.name
const confirmDeleteComponent = async component => { const confirmDeleteComponent = async component => {
componentToDelete = component componentToDelete = component
confirmDeleteDialog.show() confirmDeleteDialog.show()

View File

@ -49,8 +49,6 @@
{/if} {/if}
{/each} {/each}
</select> </select>
{:else if type === 'colour'}
<Colorpicker {onChanged} {value} />
{:else} {:else}
<PropertyCascader {onChanged} {value} /> <PropertyCascader {onChanged} {value} />
{/if} {/if}

View File

@ -30,6 +30,7 @@ router
deflate: { deflate: {
flush: zlib.Z_SYNC_FLUSH, flush: zlib.Z_SYNC_FLUSH,
}, },
br: false,
}) })
) )
.use(async (ctx, next) => { .use(async (ctx, next) => {