From 142fb18c177b1063076c98852643094299cb1137 Mon Sep 17 00:00:00 2001
From: Adria Navarro <adria@budibase.com>
Date: Wed, 13 Sep 2023 14:09:48 +0200
Subject: [PATCH] Fix tests

---
 .../server/src/api/routes/tests/row.spec.ts   | 33 +++++++++++--------
 .../src/db/tests/linkController.spec.js       |  2 +-
 .../src/tests/utilities/TestConfiguration.ts  |  4 +--
 3 files changed, 22 insertions(+), 17 deletions(-)

diff --git a/packages/server/src/api/routes/tests/row.spec.ts b/packages/server/src/api/routes/tests/row.spec.ts
index 09cc2d1888..e3bfc32320 100644
--- a/packages/server/src/api/routes/tests/row.spec.ts
+++ b/packages/server/src/api/routes/tests/row.spec.ts
@@ -10,6 +10,7 @@ import {
   MonthlyQuotaName,
   PermissionLevel,
   QuotaUsageType,
+  RelationshipType,
   Row,
   SaveTableRequest,
   SortOrder,
@@ -737,22 +738,26 @@ describe.each([
       const { linkedTable, firstRow, secondRow } = await tenancy.doInTenant(
         config.getTenantId(),
         async () => {
-          const linkedTable = await config.createLinkedTable({
-            name: generator.word(),
-            type: "table",
-            primary: ["id"],
-            primaryDisplay: "id",
-            schema: {
-              id: {
-                type: FieldType.AUTO,
-                name: "id",
-                autocolumn: true,
-                constraints: {
-                  presence: true,
+          const linkedTable = await config.createLinkedTable(
+            RelationshipType.ONE_TO_MANY,
+            ["link"],
+            {
+              name: generator.word(),
+              type: "table",
+              primary: ["id"],
+              primaryDisplay: "id",
+              schema: {
+                id: {
+                  type: FieldType.AUTO,
+                  name: "id",
+                  autocolumn: true,
+                  constraints: {
+                    presence: true,
+                  },
                 },
               },
-            },
-          })
+            }
+          )
           const firstRow = await config.createRow({
             name: "Test Contact",
             description: "original description",
diff --git a/packages/server/src/db/tests/linkController.spec.js b/packages/server/src/db/tests/linkController.spec.js
index 1c50142871..59d0f3f983 100644
--- a/packages/server/src/db/tests/linkController.spec.js
+++ b/packages/server/src/db/tests/linkController.spec.js
@@ -6,7 +6,7 @@ const { RelationshipType } = require("../../constants")
 const { cloneDeep } = require("lodash/fp")
 
 describe("test the link controller", () => {
-  let config = new TestConfig(false)
+  let config = new TestConfig()
   let table1, table2, appId
 
   beforeAll(async () => {
diff --git a/packages/server/src/tests/utilities/TestConfiguration.ts b/packages/server/src/tests/utilities/TestConfiguration.ts
index e521a5a6a6..94896932ad 100644
--- a/packages/server/src/tests/utilities/TestConfiguration.ts
+++ b/packages/server/src/tests/utilities/TestConfiguration.ts
@@ -563,9 +563,9 @@ class TestConfiguration {
   }
 
   async createLinkedTable(
-    config?: Table,
     relationshipType = RelationshipType.ONE_TO_MANY,
-    links: any = ["link"]
+    links: any = ["link"],
+    config?: Table
   ) {
     if (!this.table) {
       throw "Must have created a table first."