MirrorSave
/
budibase
mirror of https://github.com/Budibase/budibase.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Added error handling for export row front end and fixed row export backend behaviour

This commit is contained in:
Dean 2023-05-25 17:50:52 +01:00
parent 82ac46e5eb
commit 146940f6ae
2 changed files with 21 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
packages/builder/src/components/backend/DataTable/modals/ExportModal.svelte
View File

@ -113,7 +113,9 @@
}) })
download(data, `export.${exportFormat}`) download(data, `export.${exportFormat}`)
} else if (filters || sorting) { } else if (filters || sorting) {
const data = await API.exportRows({ let response
try {
response = await API.exportRows({
tableId: view, tableId: view,
format: exportFormat, format: exportFormat,
search: { search: {
@ -123,7 +125,14 @@
paginate: false, paginate: false,
}, },
}) })
download(data, `export.${exportFormat}`) } catch (e) {
console.error("Failed to export", e)
notifications.error("Export Failed")
}
if (response) {
download(response, `export.${exportFormat}`)
notifications.success("Export Successful")
}
} else { } else {
await exportView() await exportView()
} }

2
packages/server/src/api/controllers/row/internal.ts
View File

@ -415,7 +415,7 @@ export async function exportRows(ctx: UserCtx) {
result = await outputProcessing(table, response) result = await outputProcessing(table, response)
} else if (query) { } else if (query) {
let searchResponse = await exports.search(ctx) let searchResponse = await search(ctx)
result = searchResponse.rows result = searchResponse.rows
} }