From 5266d80afe559a3f964ee8e65a926c0e2dffcf1a Mon Sep 17 00:00:00 2001 From: Dean Date: Thu, 26 Oct 2023 16:09:01 +0100 Subject: [PATCH 01/21] Fix to ensure single integer ids are parsed correctly --- packages/client/src/utils/buttonActions.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/packages/client/src/utils/buttonActions.js b/packages/client/src/utils/buttonActions.js index 18d6b3de3c..9b4640dbb4 100644 --- a/packages/client/src/utils/buttonActions.js +++ b/packages/client/src/utils/buttonActions.js @@ -103,7 +103,6 @@ const fetchRowHandler = async action => { const deleteRowHandler = async action => { const { tableId, rowId: rowConfig, notificationOverride } = action.parameters - if (tableId && rowConfig) { try { let requestConfig @@ -129,9 +128,11 @@ const deleteRowHandler = async action => { requestConfig = [parsedRowConfig] } else if (Array.isArray(parsedRowConfig)) { requestConfig = parsedRowConfig + } else if (Number.isInteger(parsedRowConfig)) { + requestConfig = [String(parsedRowConfig)] } - if (!requestConfig.length) { + if (!requestConfig && !parsedRowConfig) { notificationStore.actions.warning("No valid rows were supplied") return false } From 2160f4e5e205729e1af2afce6cf586c3f537e6f0 Mon Sep 17 00:00:00 2001 From: Sam Rose Date: Fri, 27 Oct 2023 16:24:02 +0100 Subject: [PATCH 02/21] Add valid extension list to shared-core. --- packages/shared-core/src/constants.ts | 43 +++++++++++++++++++++++++++ 1 file changed, 43 insertions(+) diff --git a/packages/shared-core/src/constants.ts b/packages/shared-core/src/constants.ts index 725c246e2f..312e69c896 100644 --- a/packages/shared-core/src/constants.ts +++ b/packages/shared-core/src/constants.ts @@ -96,3 +96,46 @@ export enum BuilderSocketEvent { export const SocketSessionTTL = 60 export const ValidQueryNameRegex = /^[^()]*$/ export const ValidColumnNameRegex = /^[_a-zA-Z0-9\s]*$/g + +export const ValidFileExtensions = [ + "avif", + "css", + "csv", + "docx", + "drawio", + "editorconfig", + "edl", + "enc", + "export", + "geojson", + "gif", + "htm", + "html", + "ics", + "iqy", + "jfif", + "jpeg", + "jpg", + "json", + "log", + "md", + "mid", + "odt", + "pdf", + "png", + "ris", + "rtf", + "svg", + "tex", + "toml", + "twig", + "txt", + "url", + "wav", + "webp", + "xls", + "xlsx", + "xml", + "yaml", + "yml", +] From 6bb6f106d53ee3e1f866e4317e73f62cba1d207b Mon Sep 17 00:00:00 2001 From: Sam Rose Date: Fri, 27 Oct 2023 16:46:30 +0100 Subject: [PATCH 03/21] Apply valid file types to AttachmentCell. --- packages/bbui/src/Form/Dropzone.svelte | 2 ++ .../src/components/grid/cells/AttachmentCell.svelte | 3 +++ packages/shared-core/src/constants.ts | 1 - 3 files changed, 5 insertions(+), 1 deletion(-) diff --git a/packages/bbui/src/Form/Dropzone.svelte b/packages/bbui/src/Form/Dropzone.svelte index 2a6fa1c57b..94742ea08d 100644 --- a/packages/bbui/src/Form/Dropzone.svelte +++ b/packages/bbui/src/Form/Dropzone.svelte @@ -17,6 +17,7 @@ export let fileTags = [] export let maximum = undefined export let compact = false + export let extensions = undefined const dispatch = createEventDispatcher() const onChange = e => { @@ -39,6 +40,7 @@ {fileTags} {maximum} {compact} + {extensions} on:change={onChange} /> diff --git a/packages/frontend-core/src/components/grid/cells/AttachmentCell.svelte b/packages/frontend-core/src/components/grid/cells/AttachmentCell.svelte index a27c31bbe5..4e2a6025e5 100644 --- a/packages/frontend-core/src/components/grid/cells/AttachmentCell.svelte +++ b/packages/frontend-core/src/components/grid/cells/AttachmentCell.svelte @@ -2,6 +2,7 @@ import { onMount } from "svelte" import { getContext } from "svelte" import { Dropzone } from "@budibase/bbui" + import { ValidFileExtensions } from "@budibase/shared-core" export let value export let focused = false @@ -13,6 +14,7 @@ const { API, notifications } = getContext("grid") const imageExtensions = ["png", "tiff", "gif", "raw", "jpg", "jpeg"] + const validExtensions = ValidFileExtensions.map(ext => `.${ext}`).join(", ") let isOpen = false @@ -96,6 +98,7 @@ {value} compact on:change={e => onChange(e.detail)} + extensions={validExtensions} {processFiles} {deleteAttachments} {handleFileTooLarge} diff --git a/packages/shared-core/src/constants.ts b/packages/shared-core/src/constants.ts index 312e69c896..e7c6feb20a 100644 --- a/packages/shared-core/src/constants.ts +++ b/packages/shared-core/src/constants.ts @@ -96,7 +96,6 @@ export enum BuilderSocketEvent { export const SocketSessionTTL = 60 export const ValidQueryNameRegex = /^[^()]*$/ export const ValidColumnNameRegex = /^[_a-zA-Z0-9\s]*$/g - export const ValidFileExtensions = [ "avif", "css", From 5539ff9c9ce292d844c7d88b4a8384e45310b259 Mon Sep 17 00:00:00 2001 From: Sam Rose Date: Fri, 27 Oct 2023 16:53:32 +0100 Subject: [PATCH 04/21] Apply valid file types to RowFieldControl and AttackmentField. --- .../src/components/backend/DataTable/RowFieldControl.svelte | 5 ++++- .../client/src/components/app/forms/AttachmentField.svelte | 3 ++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/packages/builder/src/components/backend/DataTable/RowFieldControl.svelte b/packages/builder/src/components/backend/DataTable/RowFieldControl.svelte index 61b706e28e..9d52cb815e 100644 --- a/packages/builder/src/components/backend/DataTable/RowFieldControl.svelte +++ b/packages/builder/src/components/backend/DataTable/RowFieldControl.svelte @@ -13,6 +13,7 @@ import { capitalise } from "helpers" import LinkedRowSelector from "components/common/LinkedRowSelector.svelte" import Editor from "../../integration/QueryEditor.svelte" + import { ValidFileExtensions } from "@budibase/shared-core" export let defaultValue export let meta @@ -20,6 +21,8 @@ export let readonly export let error + let validExtensions = ValidFileExtensions.map(ext => `.${ext}`).join(", ") + const resolveTimeStamp = timestamp => { if (!timestamp) { return null @@ -59,7 +62,7 @@ bind:value /> {:else if type === "attachment"} - + {:else if type === "boolean"} {:else if type === "array" && meta.constraints.inclusion.length !== 0} diff --git a/packages/client/src/components/app/forms/AttachmentField.svelte b/packages/client/src/components/app/forms/AttachmentField.svelte index e24115ebc0..2effe607ae 100644 --- a/packages/client/src/components/app/forms/AttachmentField.svelte +++ b/packages/client/src/components/app/forms/AttachmentField.svelte @@ -2,13 +2,14 @@ import Field from "./Field.svelte" import { CoreDropzone } from "@budibase/bbui" import { getContext } from "svelte" + import { ValidFileExtensions } from "@budibase/shared-core" export let field export let label export let disabled = false export let compact = false export let validation - export let extensions + export let extensions = ValidFileExtensions.map(ext => `.${ext}`).join(", ") export let onChange export let maximum = undefined From f1aa32e4461b604c551915953940a990f0670404 Mon Sep 17 00:00:00 2001 From: Sam Rose Date: Fri, 27 Oct 2023 17:19:39 +0100 Subject: [PATCH 05/21] Truncate file size on the grid, validate extension in the attachment API. --- packages/bbui/src/Form/Core/Dropzone.svelte | 10 ++++++---- .../backend/DataTable/RowFieldControl.svelte | 5 ++++- .../server/src/api/controllers/static/index.ts | 14 ++++++++++++++ 3 files changed, 24 insertions(+), 5 deletions(-) diff --git a/packages/bbui/src/Form/Core/Dropzone.svelte b/packages/bbui/src/Form/Core/Dropzone.svelte index e9ee75bd8b..0b6a9bb94f 100644 --- a/packages/bbui/src/Form/Core/Dropzone.svelte +++ b/packages/bbui/src/Form/Core/Dropzone.svelte @@ -159,8 +159,10 @@ {#if selectedImage.size}
{#if selectedImage.size <= BYTES_IN_MB} - {`${selectedImage.size / BYTES_IN_KB} KB`} - {:else}{`${selectedImage.size / BYTES_IN_MB} MB`}{/if} + {`${(selectedImage.size / BYTES_IN_KB).toFixed(1)} KB`} + {:else}{`${(selectedImage.size / BYTES_IN_MB).toFixed( + 1 + )} MB`}{/if}
{/if} {#if !disabled} @@ -203,8 +205,8 @@ {#if file.size}
{#if file.size <= BYTES_IN_MB} - {`${file.size / BYTES_IN_KB} KB`} - {:else}{`${file.size / BYTES_IN_MB} MB`}{/if} + {`${(file.size / BYTES_IN_KB).toFixed(1)} KB`} + {:else}{`${(file.size / BYTES_IN_MB).toFixed(1)} MB`}{/if}
{/if} {#if !disabled} diff --git a/packages/builder/src/components/backend/DataTable/RowFieldControl.svelte b/packages/builder/src/components/backend/DataTable/RowFieldControl.svelte index 9d52cb815e..ea1161fe9b 100644 --- a/packages/builder/src/components/backend/DataTable/RowFieldControl.svelte +++ b/packages/builder/src/components/backend/DataTable/RowFieldControl.svelte @@ -14,6 +14,7 @@ import LinkedRowSelector from "components/common/LinkedRowSelector.svelte" import Editor from "../../integration/QueryEditor.svelte" import { ValidFileExtensions } from "@budibase/shared-core" + import { admin } from "stores/portal" export let defaultValue export let meta @@ -21,7 +22,9 @@ export let readonly export let error - let validExtensions = ValidFileExtensions.map(ext => `.${ext}`).join(", ") + let validExtensions = $admin.cloud + ? ValidFileExtensions.map(ext => `.${ext}`).join(", ") + : "*" const resolveTimeStamp = timestamp => { if (!timestamp) { diff --git a/packages/server/src/api/controllers/static/index.ts b/packages/server/src/api/controllers/static/index.ts index 984cb16c06..e8d403ad12 100644 --- a/packages/server/src/api/controllers/static/index.ts +++ b/packages/server/src/api/controllers/static/index.ts @@ -1,3 +1,5 @@ +import { ValidFileExtensions } from "@budibase/shared-core" + require("svelte/register") import { join } from "../../../utilities/centralPath" @@ -17,6 +19,7 @@ import fs from "fs" import sdk from "../../../sdk" import * as pro from "@budibase/pro" import { App, Ctx } from "@budibase/types" +import environment from "../../../environment" const send = require("koa-send") @@ -78,6 +81,17 @@ export const uploadFile = async function (ctx: Ctx) { const uploads = files.map(async (file: any) => { const fileExtension = [...file.name.split(".")].pop() + if ( + !environment.SELF_HOSTED && + !ValidFileExtensions.includes(fileExtension) + ) { + ctx.throw( + 400, + `Invalid file extension. Valid extensions are: ${ValidFileExtensions.join( + ", " + )}` + ) + } // filenames converted to UUIDs so they are unique const processedFileName = `${uuid.v4()}.${fileExtension}` From 84ba840dbcfea6e059c3872999f6ac716783eee5 Mon Sep 17 00:00:00 2001 From: Sam Rose Date: Fri, 27 Oct 2023 17:29:05 +0100 Subject: [PATCH 06/21] Apply valid file type change to AttachmentField in cloud only. --- .../client/src/components/app/forms/AttachmentField.svelte | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/packages/client/src/components/app/forms/AttachmentField.svelte b/packages/client/src/components/app/forms/AttachmentField.svelte index 2effe607ae..e57510c770 100644 --- a/packages/client/src/components/app/forms/AttachmentField.svelte +++ b/packages/client/src/components/app/forms/AttachmentField.svelte @@ -3,13 +3,16 @@ import { CoreDropzone } from "@budibase/bbui" import { getContext } from "svelte" import { ValidFileExtensions } from "@budibase/shared-core" + import { environmentStore } from "../../../stores/index.js" export let field export let label export let disabled = false export let compact = false export let validation - export let extensions = ValidFileExtensions.map(ext => `.${ext}`).join(", ") + export let extensions = $environmentStore.cloud + ? ValidFileExtensions.map(ext => `.${ext}`).join(", ") + : "*" export let onChange export let maximum = undefined From a141598a1cb269ab5deb2b939a861a753d8b236d Mon Sep 17 00:00:00 2001 From: Adria Navarro Date: Mon, 30 Oct 2023 14:26:28 +0100 Subject: [PATCH 07/21] Remove unused scripts --- package.json | 2 -- 1 file changed, 2 deletions(-) diff --git a/package.json b/package.json index d3f4903e6c..03257d2d06 100644 --- a/package.json +++ b/package.json @@ -56,8 +56,6 @@ "build:specs": "lerna run --stream specs", "build:docker": "lerna run --stream build:docker && yarn build:docker:proxy && cd hosting/scripts/linux/ && ./release-to-docker-hub.sh $BUDIBASE_RELEASE_VERSION && cd -", "build:docker:proxy": "docker build hosting/proxy -t proxy-service", - "build:docker:selfhost": "lerna run --stream build:docker && cd hosting/scripts/linux/ && ./release-to-docker-hub.sh latest && cd -", - "build:docker:develop": "node scripts/pinVersions && lerna run --stream build:docker && yarn build:docker:proxy && cd hosting/scripts/linux/ && ./release-to-docker-hub.sh develop && cd -", "build:docker:airgap": "node hosting/scripts/airgapped/airgappedDockerBuild", "build:docker:airgap:single": "SINGLE_IMAGE=1 node hosting/scripts/airgapped/airgappedDockerBuild", "build:digitalocean": "cd hosting/digitalocean && ./build.sh && cd -", From 6631a7a11d8704a075bec9fc7516ccfb08aac141 Mon Sep 17 00:00:00 2001 From: Adria Navarro Date: Mon, 30 Oct 2023 14:34:55 +0100 Subject: [PATCH 08/21] Push docker images via docker/build-push-action --- .github/workflows/release-master.yml | 39 +++++++++++++++++++++++++--- 1 file changed, 36 insertions(+), 3 deletions(-) diff --git a/.github/workflows/release-master.yml b/.github/workflows/release-master.yml index 4c5a3f4a1e..a8af6a4da1 100644 --- a/.github/workflows/release-master.yml +++ b/.github/workflows/release-master.yml @@ -66,14 +66,47 @@ jobs: - name: Setup Docker Buildx id: buildx uses: docker/setup-buildx-action@v1 - - name: Build/release Docker images + + - name: Docker login run: | docker login -u $DOCKER_USER -p $DOCKER_PASSWORD - yarn build:docker env: DOCKER_USER: ${{ secrets.DOCKER_USERNAME }} DOCKER_PASSWORD: ${{ secrets.DOCKER_API_KEY }} - BUDIBASE_RELEASE_VERSION: ${{ steps.currenttag.outputs.version }} + + - name: Build docker (budibase/worker) + uses: docker/build-push-action@v5 + with: + context: . + push: true + platforms: linux/amd64,linux/arm64 + build-args: | + BUDIBASE_VERSION=${{ env.BUDIBASE_VERSION }} + tags: ${{ env.IMAGE_NAME }}:${{ env.IMAGE_TAG }} + file: ./packages/worker/Dockerfile.v2 + cache-from: type=registry,ref=${{ env.IMAGE_NAME }}:latest + cache-to: type=inline + env: + IMAGE_NAME: budibase/worker + IMAGE_TAG: ${{ inputs.image_tag }} + BUDIBASE_VERSION: ${{ steps.currenttag.outputs.version }} + + - name: Build docker (budibase/apps) + uses: docker/build-push-action@v5 + with: + context: . + push: true + platforms: linux/amd64,linux/arm64 + build-args: | + BUDIBASE_VERSION=${{ env.BUDIBASE_VERSION }} + tags: ${{ env.IMAGE_NAME }}:${{ env.IMAGE_TAG }} + file: ./packages/server/Dockerfile.v2 + cache-from: type=registry,ref=${{ env.IMAGE_NAME }}:latest + cache-to: type=inline + env: + IMAGE_NAME: budibase/apps + IMAGE_TAG: ${{ inputs.image_tag }} + BUDIBASE_VERSION: ${{ steps.currenttag.outputs.version }} release-helm-chart: needs: [release-images] From 0cc978f86050ffb40082013fb788fd07e81fb9b5 Mon Sep 17 00:00:00 2001 From: Adria Navarro Date: Mon, 30 Oct 2023 14:37:33 +0100 Subject: [PATCH 09/21] Push proxy dockerfile --- .github/workflows/release-master.yml | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/.github/workflows/release-master.yml b/.github/workflows/release-master.yml index a8af6a4da1..4a89d8462f 100644 --- a/.github/workflows/release-master.yml +++ b/.github/workflows/release-master.yml @@ -74,7 +74,7 @@ jobs: DOCKER_USER: ${{ secrets.DOCKER_USERNAME }} DOCKER_PASSWORD: ${{ secrets.DOCKER_API_KEY }} - - name: Build docker (budibase/worker) + - name: Build worker docker uses: docker/build-push-action@v5 with: context: . @@ -91,7 +91,7 @@ jobs: IMAGE_TAG: ${{ inputs.image_tag }} BUDIBASE_VERSION: ${{ steps.currenttag.outputs.version }} - - name: Build docker (budibase/apps) + - name: Build server docker uses: docker/build-push-action@v5 with: context: . @@ -108,6 +108,19 @@ jobs: IMAGE_TAG: ${{ inputs.image_tag }} BUDIBASE_VERSION: ${{ steps.currenttag.outputs.version }} + - name: Build proxy docker + uses: docker/build-push-action@v5 + with: + context: . + push: true + tags: ${{ env.IMAGE_NAME }}:${{ env.IMAGE_TAG }} + file: ./hosting/proxy/Dockerfile + cache-from: type=registry,ref=${{ env.IMAGE_NAME }}:latest + cache-to: type=inline + env: + IMAGE_NAME: proxy-service + IMAGE_TAG: ${{ inputs.image_tag }} + release-helm-chart: needs: [release-images] runs-on: ubuntu-latest From a80ea2f2c05747fe4607e1bcafac5506b6d5b4f7 Mon Sep 17 00:00:00 2001 From: Adria Navarro Date: Mon, 30 Oct 2023 14:38:26 +0100 Subject: [PATCH 10/21] Clean scripts --- package.json | 2 -- packages/server/package.json | 1 - packages/worker/package.json | 1 - 3 files changed, 4 deletions(-) diff --git a/package.json b/package.json index 03257d2d06..417fb31e0e 100644 --- a/package.json +++ b/package.json @@ -54,8 +54,6 @@ "lint:fix:prettier": "prettier --write \"packages/**/*.{js,ts,svelte}\" && prettier --write \"examples/**/*.{js,ts,svelte}\" && prettier --write \"qa-core/**/*.{js,ts,svelte}\"", "lint:fix": "yarn run lint:fix:prettier && yarn run lint:fix:eslint", "build:specs": "lerna run --stream specs", - "build:docker": "lerna run --stream build:docker && yarn build:docker:proxy && cd hosting/scripts/linux/ && ./release-to-docker-hub.sh $BUDIBASE_RELEASE_VERSION && cd -", - "build:docker:proxy": "docker build hosting/proxy -t proxy-service", "build:docker:airgap": "node hosting/scripts/airgapped/airgappedDockerBuild", "build:docker:airgap:single": "SINGLE_IMAGE=1 node hosting/scripts/airgapped/airgappedDockerBuild", "build:digitalocean": "cd hosting/digitalocean && ./build.sh && cd -", diff --git a/packages/server/package.json b/packages/server/package.json index c37959d33d..c845f7889d 100644 --- a/packages/server/package.json +++ b/packages/server/package.json @@ -18,7 +18,6 @@ "test": "bash scripts/test.sh", "test:memory": "jest --maxWorkers=2 --logHeapUsage --forceExit", "test:watch": "jest --watch", - "build:docker": "yarn nx build && docker buildx build ../.. -t app-service --label version=$BUDIBASE_RELEASE_VERSION --build-arg BUDIBASE_VERSION=$BUDIBASE_RELEASE_VERSION -f Dockerfile.v2 --platform linux/amd64,linux/arm64", "run:docker": "node dist/index.js", "run:docker:cluster": "pm2-runtime start pm2.config.js", "dev:stack:up": "node scripts/dev/manage.js up", diff --git a/packages/worker/package.json b/packages/worker/package.json index a391db533b..ec86575395 100644 --- a/packages/worker/package.json +++ b/packages/worker/package.json @@ -20,7 +20,6 @@ "run:docker": "node dist/index.js", "debug": "yarn build && node --expose-gc --inspect=9223 dist/index.js", "run:docker:cluster": "pm2-runtime start pm2.config.js", - "build:docker": "yarn nx build && docker buildx build ../.. -t worker-service --label version=$BUDIBASE_RELEASE_VERSION --build-arg BUDIBASE_VERSION=$BUDIBASE_RELEASE_VERSION -f Dockerfile.v2 --platform linux/amd64,linux/arm64", "dev:stack:init": "node ./scripts/dev/manage.js init", "dev:builder": "npm run dev:stack:init && nodemon", "dev:built": "yarn run dev:stack:init && yarn run run:docker", From 0dd655e75dec40415c0e660af74dc2ee72c0802b Mon Sep 17 00:00:00 2001 From: Adria Navarro Date: Mon, 30 Oct 2023 14:39:03 +0100 Subject: [PATCH 11/21] Remove sh --- .github/workflows/release-master.yml | 2 +- hosting/scripts/linux/release-to-docker-hub.sh | 18 ------------------ 2 files changed, 1 insertion(+), 19 deletions(-) delete mode 100755 hosting/scripts/linux/release-to-docker-hub.sh diff --git a/.github/workflows/release-master.yml b/.github/workflows/release-master.yml index 4a89d8462f..24d71a35a6 100644 --- a/.github/workflows/release-master.yml +++ b/.github/workflows/release-master.yml @@ -118,7 +118,7 @@ jobs: cache-from: type=registry,ref=${{ env.IMAGE_NAME }}:latest cache-to: type=inline env: - IMAGE_NAME: proxy-service + IMAGE_NAME: budibase/proxy-service IMAGE_TAG: ${{ inputs.image_tag }} release-helm-chart: diff --git a/hosting/scripts/linux/release-to-docker-hub.sh b/hosting/scripts/linux/release-to-docker-hub.sh deleted file mode 100755 index 599a10f914..0000000000 --- a/hosting/scripts/linux/release-to-docker-hub.sh +++ /dev/null @@ -1,18 +0,0 @@ -#!/bin/bash - -tag=$1 - -if [[ ! "$tag" ]]; then - echo "No tag present. You must pass a tag to this script" - exit 1 -fi - -echo "Tagging images with tag: $tag" - -docker tag proxy-service budibase/proxy:$tag -docker tag app-service budibase/apps:$tag -docker tag worker-service budibase/worker:$tag - -docker push --all-tags budibase/apps -docker push --all-tags budibase/worker -docker push --all-tags budibase/proxy From 469114823600edb7f156fae9eef9514efed9b981 Mon Sep 17 00:00:00 2001 From: Adria Navarro Date: Mon, 30 Oct 2023 14:44:48 +0100 Subject: [PATCH 12/21] Cache yarn --- .github/workflows/release-master.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/release-master.yml b/.github/workflows/release-master.yml index 24d71a35a6..c2bee8da40 100644 --- a/.github/workflows/release-master.yml +++ b/.github/workflows/release-master.yml @@ -36,6 +36,7 @@ jobs: - uses: actions/setup-node@v1 with: node-version: 18.x + cache: yarn - run: yarn install --frozen-lockfile - name: Update versions From b74f11e0e2d23a67c6c6f30d404b2f719d4cbd32 Mon Sep 17 00:00:00 2001 From: Adria Navarro Date: Mon, 30 Oct 2023 14:53:14 +0100 Subject: [PATCH 13/21] Fix proxy image name --- .github/workflows/release-master.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/release-master.yml b/.github/workflows/release-master.yml index c2bee8da40..5d67101f4e 100644 --- a/.github/workflows/release-master.yml +++ b/.github/workflows/release-master.yml @@ -119,7 +119,7 @@ jobs: cache-from: type=registry,ref=${{ env.IMAGE_NAME }}:latest cache-to: type=inline env: - IMAGE_NAME: budibase/proxy-service + IMAGE_NAME: budibase/proxy IMAGE_TAG: ${{ inputs.image_tag }} release-helm-chart: From ac3c9a374cbefa12e51e7dc2354128cc344f5240 Mon Sep 17 00:00:00 2001 From: Adria Navarro Date: Mon, 30 Oct 2023 15:02:36 +0100 Subject: [PATCH 14/21] Fix image tag --- .github/workflows/release-master.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/release-master.yml b/.github/workflows/release-master.yml index 5d67101f4e..e0adddc6a8 100644 --- a/.github/workflows/release-master.yml +++ b/.github/workflows/release-master.yml @@ -89,7 +89,7 @@ jobs: cache-to: type=inline env: IMAGE_NAME: budibase/worker - IMAGE_TAG: ${{ inputs.image_tag }} + IMAGE_TAG: ${{ steps.currenttag.outputs.version }} BUDIBASE_VERSION: ${{ steps.currenttag.outputs.version }} - name: Build server docker @@ -106,7 +106,7 @@ jobs: cache-to: type=inline env: IMAGE_NAME: budibase/apps - IMAGE_TAG: ${{ inputs.image_tag }} + IMAGE_TAG: ${{ steps.currenttag.outputs.version }} BUDIBASE_VERSION: ${{ steps.currenttag.outputs.version }} - name: Build proxy docker @@ -120,7 +120,7 @@ jobs: cache-to: type=inline env: IMAGE_NAME: budibase/proxy - IMAGE_TAG: ${{ inputs.image_tag }} + IMAGE_TAG: ${{ steps.currenttag.outputs.version }} release-helm-chart: needs: [release-images] From 436d6a1585a9d904b0339e7331d24a43e3ba135f Mon Sep 17 00:00:00 2001 From: Sam Rose Date: Mon, 30 Oct 2023 14:39:12 +0000 Subject: [PATCH 15/21] Revert frontend changes to filter out file extensions in the upload box. --- packages/bbui/src/Form/Dropzone.svelte | 2 -- .../components/backend/DataTable/RowFieldControl.svelte | 8 +------- .../src/components/app/forms/AttachmentField.svelte | 6 +----- .../src/components/grid/cells/AttachmentCell.svelte | 3 --- 4 files changed, 2 insertions(+), 17 deletions(-) diff --git a/packages/bbui/src/Form/Dropzone.svelte b/packages/bbui/src/Form/Dropzone.svelte index 94742ea08d..2a6fa1c57b 100644 --- a/packages/bbui/src/Form/Dropzone.svelte +++ b/packages/bbui/src/Form/Dropzone.svelte @@ -17,7 +17,6 @@ export let fileTags = [] export let maximum = undefined export let compact = false - export let extensions = undefined const dispatch = createEventDispatcher() const onChange = e => { @@ -40,7 +39,6 @@ {fileTags} {maximum} {compact} - {extensions} on:change={onChange} /> diff --git a/packages/builder/src/components/backend/DataTable/RowFieldControl.svelte b/packages/builder/src/components/backend/DataTable/RowFieldControl.svelte index ea1161fe9b..61b706e28e 100644 --- a/packages/builder/src/components/backend/DataTable/RowFieldControl.svelte +++ b/packages/builder/src/components/backend/DataTable/RowFieldControl.svelte @@ -13,8 +13,6 @@ import { capitalise } from "helpers" import LinkedRowSelector from "components/common/LinkedRowSelector.svelte" import Editor from "../../integration/QueryEditor.svelte" - import { ValidFileExtensions } from "@budibase/shared-core" - import { admin } from "stores/portal" export let defaultValue export let meta @@ -22,10 +20,6 @@ export let readonly export let error - let validExtensions = $admin.cloud - ? ValidFileExtensions.map(ext => `.${ext}`).join(", ") - : "*" - const resolveTimeStamp = timestamp => { if (!timestamp) { return null @@ -65,7 +59,7 @@ bind:value /> {:else if type === "attachment"} - + {:else if type === "boolean"} {:else if type === "array" && meta.constraints.inclusion.length !== 0} diff --git a/packages/client/src/components/app/forms/AttachmentField.svelte b/packages/client/src/components/app/forms/AttachmentField.svelte index e57510c770..e24115ebc0 100644 --- a/packages/client/src/components/app/forms/AttachmentField.svelte +++ b/packages/client/src/components/app/forms/AttachmentField.svelte @@ -2,17 +2,13 @@ import Field from "./Field.svelte" import { CoreDropzone } from "@budibase/bbui" import { getContext } from "svelte" - import { ValidFileExtensions } from "@budibase/shared-core" - import { environmentStore } from "../../../stores/index.js" export let field export let label export let disabled = false export let compact = false export let validation - export let extensions = $environmentStore.cloud - ? ValidFileExtensions.map(ext => `.${ext}`).join(", ") - : "*" + export let extensions export let onChange export let maximum = undefined diff --git a/packages/frontend-core/src/components/grid/cells/AttachmentCell.svelte b/packages/frontend-core/src/components/grid/cells/AttachmentCell.svelte index 4e2a6025e5..a27c31bbe5 100644 --- a/packages/frontend-core/src/components/grid/cells/AttachmentCell.svelte +++ b/packages/frontend-core/src/components/grid/cells/AttachmentCell.svelte @@ -2,7 +2,6 @@ import { onMount } from "svelte" import { getContext } from "svelte" import { Dropzone } from "@budibase/bbui" - import { ValidFileExtensions } from "@budibase/shared-core" export let value export let focused = false @@ -14,7 +13,6 @@ const { API, notifications } = getContext("grid") const imageExtensions = ["png", "tiff", "gif", "raw", "jpg", "jpeg"] - const validExtensions = ValidFileExtensions.map(ext => `.${ext}`).join(", ") let isOpen = false @@ -98,7 +96,6 @@ {value} compact on:change={e => onChange(e.detail)} - extensions={validExtensions} {processFiles} {deleteAttachments} {handleFileTooLarge} From 344256a80588543427987e93b32c67d25766783e Mon Sep 17 00:00:00 2001 From: Adria Navarro Date: Mon, 30 Oct 2023 15:57:40 +0100 Subject: [PATCH 16/21] Fix proxy build --- .github/workflows/release-master.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/release-master.yml b/.github/workflows/release-master.yml index e0adddc6a8..e1feaa1e7c 100644 --- a/.github/workflows/release-master.yml +++ b/.github/workflows/release-master.yml @@ -112,7 +112,7 @@ jobs: - name: Build proxy docker uses: docker/build-push-action@v5 with: - context: . + context: ./hosting/proxy push: true tags: ${{ env.IMAGE_NAME }}:${{ env.IMAGE_TAG }} file: ./hosting/proxy/Dockerfile From 674f40a06ee49dc1ffa7d56e8b79466e8dab7903 Mon Sep 17 00:00:00 2001 From: Samuel-Martineau Date: Fri, 27 Oct 2023 17:21:30 -0400 Subject: [PATCH 17/21] Fix how attachment URLs are handled --- packages/server/src/utilities/rowProcessor/index.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/server/src/utilities/rowProcessor/index.ts b/packages/server/src/utilities/rowProcessor/index.ts index cf3875b2ea..604f872c81 100644 --- a/packages/server/src/utilities/rowProcessor/index.ts +++ b/packages/server/src/utilities/rowProcessor/index.ts @@ -241,7 +241,7 @@ export async function outputProcessing( continue } row[property].forEach((attachment: RowAttachment) => { - attachment.url = objectStore.getAppFileUrl(attachment.key) + attachment.url ??= objectStore.getAppFileUrl(attachment.key) }) } } else if ( From b3a4a921aa195aacf68c5dd8dfd84f27b45e1cf1 Mon Sep 17 00:00:00 2001 From: Adria Navarro Date: Mon, 30 Oct 2023 16:47:47 +0100 Subject: [PATCH 18/21] Build multi platform proxy --- .github/workflows/release-master.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/release-master.yml b/.github/workflows/release-master.yml index e1feaa1e7c..df25182cd6 100644 --- a/.github/workflows/release-master.yml +++ b/.github/workflows/release-master.yml @@ -114,6 +114,7 @@ jobs: with: context: ./hosting/proxy push: true + platforms: linux/amd64,linux/arm64 tags: ${{ env.IMAGE_NAME }}:${{ env.IMAGE_TAG }} file: ./hosting/proxy/Dockerfile cache-from: type=registry,ref=${{ env.IMAGE_NAME }}:latest From af59039d1c8a5735f0325c73c1c0da846c845c31 Mon Sep 17 00:00:00 2001 From: Sam Rose Date: Mon, 30 Oct 2023 16:46:27 +0000 Subject: [PATCH 19/21] Add tests for attachment processing endpoint. --- .../src/api/controllers/static/index.ts | 100 ++++++++++-------- .../src/api/routes/tests/attachment.spec.ts | 49 +++++++++ .../src/api/routes/tests/static.spec.js | 8 +- .../src/api/routes/tests/webhook.spec.ts | 8 +- .../integrations/tests/googlesheets.spec.ts | 9 +- .../src/tests/utilities/TestConfiguration.ts | 47 ++++---- .../src/tests/utilities/api/attachment.ts | 35 ++++++ .../server/src/tests/utilities/api/index.ts | 3 + packages/types/src/api/web/app/attachment.ts | 9 ++ packages/types/src/api/web/app/index.ts | 1 + 10 files changed, 199 insertions(+), 70 deletions(-) create mode 100644 packages/server/src/api/routes/tests/attachment.spec.ts create mode 100644 packages/server/src/tests/utilities/api/attachment.ts create mode 100644 packages/types/src/api/web/app/attachment.ts diff --git a/packages/server/src/api/controllers/static/index.ts b/packages/server/src/api/controllers/static/index.ts index e8d403ad12..8fbc0db910 100644 --- a/packages/server/src/api/controllers/static/index.ts +++ b/packages/server/src/api/controllers/static/index.ts @@ -13,35 +13,21 @@ import { } from "../../../utilities/fileSystem" import env from "../../../environment" import { DocumentType } from "../../../db/utils" -import { context, objectStore, utils, configs } from "@budibase/backend-core" +import { + context, + objectStore, + utils, + configs, + BadRequestError, +} from "@budibase/backend-core" import AWS from "aws-sdk" import fs from "fs" import sdk from "../../../sdk" import * as pro from "@budibase/pro" -import { App, Ctx } from "@budibase/types" -import environment from "../../../environment" +import { App, Ctx, ProcessAttachmentResponse, Upload } from "@budibase/types" const send = require("koa-send") -async function prepareUpload({ s3Key, bucket, metadata, file }: any) { - const response = await objectStore.upload({ - bucket, - metadata, - filename: s3Key, - path: file.path, - type: file.type, - }) - - // don't store a URL, work this out on the way out as the URL could change - return { - size: file.size, - name: file.name, - url: objectStore.getAppFileUrl(s3Key), - extension: [...file.name.split(".")].pop(), - key: response.Key, - } -} - export const toggleBetaUiFeature = async function (ctx: Ctx) { const cookieName = `beta:${ctx.params.feature}` @@ -75,34 +61,58 @@ export const serveBuilder = async function (ctx: Ctx) { await send(ctx, ctx.file, { root: builderPath }) } -export const uploadFile = async function (ctx: Ctx) { +export const uploadFile = async function ( + ctx: Ctx<{}, ProcessAttachmentResponse> +) { const file = ctx.request?.files?.file + if (!file) { + throw new BadRequestError("No file provided") + } + let files = file && Array.isArray(file) ? Array.from(file) : [file] - const uploads = files.map(async (file: any) => { - const fileExtension = [...file.name.split(".")].pop() - if ( - !environment.SELF_HOSTED && - !ValidFileExtensions.includes(fileExtension) - ) { - ctx.throw( - 400, - `Invalid file extension. Valid extensions are: ${ValidFileExtensions.join( - ", " - )}` - ) - } - // filenames converted to UUIDs so they are unique - const processedFileName = `${uuid.v4()}.${fileExtension}` + ctx.body = await Promise.all( + files.map(async file => { + if (!file.name) { + throw new BadRequestError( + "Attempted to upload a file without a filename" + ) + } - return prepareUpload({ - file, - s3Key: `${context.getProdAppId()}/attachments/${processedFileName}`, - bucket: ObjectStoreBuckets.APPS, + const extension = [...file.name.split(".")].pop() + if (!extension) { + throw new BadRequestError( + `File "${file.name}" has no extension, an extension is required to upload a file` + ) + } + + if (!env.SELF_HOSTED && !ValidFileExtensions.includes(extension)) { + throw new BadRequestError( + `File "${file.name}" has an invalid extension: "${extension}"` + ) + } + + // filenames converted to UUIDs so they are unique + const processedFileName = `${uuid.v4()}.${extension}` + + const s3Key = `${context.getProdAppId()}/attachments/${processedFileName}` + + const response = await objectStore.upload({ + bucket: ObjectStoreBuckets.APPS, + filename: s3Key, + path: file.path, + type: file.type, + }) + + return { + size: file.size, + name: file.name, + url: objectStore.getAppFileUrl(s3Key), + extension, + key: response.Key, + } }) - }) - - ctx.body = await Promise.all(uploads) + ) } export const deleteObjects = async function (ctx: Ctx) { diff --git a/packages/server/src/api/routes/tests/attachment.spec.ts b/packages/server/src/api/routes/tests/attachment.spec.ts new file mode 100644 index 0000000000..14d2e845f6 --- /dev/null +++ b/packages/server/src/api/routes/tests/attachment.spec.ts @@ -0,0 +1,49 @@ +import * as setup from "./utilities" +import { APIError } from "@budibase/types" + +describe("/api/applications/:appId/sync", () => { + let config = setup.getConfig() + + afterAll(setup.afterAll) + beforeAll(async () => { + await config.init() + }) + + describe("/api/attachments/process", () => { + it("should accept an image file upload", async () => { + let resp = await config.api.attachment.process( + "1px.jpg", + Buffer.from([0]) + ) + expect(resp.length).toBe(1) + + let upload = resp[0] + expect(upload.url.endsWith(".jpg")).toBe(true) + expect(upload.extension).toBe("jpg") + expect(upload.size).toBe(1) + expect(upload.name).toBe("1px.jpg") + }) + + it("should reject an upload with a malicious file extension", async () => { + await config.withEnv({ SELF_HOSTED: undefined }, async () => { + let resp = (await config.api.attachment.process( + "ohno.exe", + Buffer.from([0]), + { expectStatus: 400 } + )) as unknown as APIError + expect(resp.message).toContain("invalid extension") + }) + }) + + it("should reject an upload with no file", async () => { + let resp = (await config.api.attachment.process( + undefined as any, + undefined as any, + { + expectStatus: 400, + } + )) as unknown as APIError + expect(resp.message).toContain("No file provided") + }) + }) +}) diff --git a/packages/server/src/api/routes/tests/static.spec.js b/packages/server/src/api/routes/tests/static.spec.js index 13d963d057..a28d9ecd79 100644 --- a/packages/server/src/api/routes/tests/static.spec.js +++ b/packages/server/src/api/routes/tests/static.spec.js @@ -5,11 +5,15 @@ describe("/static", () => { let request = setup.getRequest() let config = setup.getConfig() let app + let cleanupEnv - afterAll(setup.afterAll) + afterAll(() => { + setup.afterAll() + cleanupEnv() + }) beforeAll(async () => { - config.modeSelf() + cleanupEnv = config.setEnv({ SELF_HOSTED: "true" }) app = await config.init() }) diff --git a/packages/server/src/api/routes/tests/webhook.spec.ts b/packages/server/src/api/routes/tests/webhook.spec.ts index e7046d07c8..118bfca95f 100644 --- a/packages/server/src/api/routes/tests/webhook.spec.ts +++ b/packages/server/src/api/routes/tests/webhook.spec.ts @@ -8,11 +8,15 @@ describe("/webhooks", () => { let request = setup.getRequest() let config = setup.getConfig() let webhook: Webhook + let cleanupEnv: () => void - afterAll(setup.afterAll) + afterAll(() => { + setup.afterAll() + cleanupEnv() + }) const setupTest = async () => { - config.modeSelf() + cleanupEnv = config.setEnv({ SELF_HOSTED: "true" }) await config.init() const autoConfig = basicAutomation() autoConfig.definition.trigger.schema = { diff --git a/packages/server/src/integrations/tests/googlesheets.spec.ts b/packages/server/src/integrations/tests/googlesheets.spec.ts index 748baddc39..a38c6bda45 100644 --- a/packages/server/src/integrations/tests/googlesheets.spec.ts +++ b/packages/server/src/integrations/tests/googlesheets.spec.ts @@ -35,13 +35,18 @@ import { FieldType, Table, TableSchema } from "@budibase/types" describe("Google Sheets Integration", () => { let integration: any, config = new TestConfiguration() + let cleanupEnv: () => void beforeAll(() => { - config.setGoogleAuth("test") + cleanupEnv = config.setEnv({ + GOOGLE_CLIENT_ID: "test", + GOOGLE_CLIENT_SECRET: "test", + }) }) afterAll(async () => { - await config.end() + cleanupEnv() + config.end() }) beforeEach(async () => { diff --git a/packages/server/src/tests/utilities/TestConfiguration.ts b/packages/server/src/tests/utilities/TestConfiguration.ts index cec8c8aa12..5096b054a6 100644 --- a/packages/server/src/tests/utilities/TestConfiguration.ts +++ b/packages/server/src/tests/utilities/TestConfiguration.ts @@ -58,6 +58,7 @@ import { } from "@budibase/types" import API from "./api" +import { cloneDeep } from "lodash" type DefaultUserValues = { globalUserId: string @@ -188,30 +189,38 @@ class TestConfiguration { } } - // MODES - setMultiTenancy = (value: boolean) => { - env._set("MULTI_TENANCY", value) - coreEnv._set("MULTI_TENANCY", value) + async withEnv(newEnvVars: Partial, f: () => Promise) { + let cleanup = this.setEnv(newEnvVars) + try { + await f() + } finally { + cleanup() + } } - setSelfHosted = (value: boolean) => { - env._set("SELF_HOSTED", value) - coreEnv._set("SELF_HOSTED", value) - } + /* + * Sets the environment variables to the given values and returns a function + * that can be called to reset the environment variables to their original values. + */ + setEnv(newEnvVars: Partial): () => void { + const oldEnv = cloneDeep(env) + const oldCoreEnv = cloneDeep(coreEnv) - setGoogleAuth = (value: string) => { - env._set("GOOGLE_CLIENT_ID", value) - env._set("GOOGLE_CLIENT_SECRET", value) - coreEnv._set("GOOGLE_CLIENT_ID", value) - coreEnv._set("GOOGLE_CLIENT_SECRET", value) - } + let key: keyof typeof newEnvVars + for (key in newEnvVars) { + env._set(key, newEnvVars[key]) + coreEnv._set(key, newEnvVars[key]) + } - modeCloud = () => { - this.setSelfHosted(false) - } + return () => { + for (const [key, value] of Object.entries(oldEnv)) { + env._set(key, value) + } - modeSelf = () => { - this.setSelfHosted(true) + for (const [key, value] of Object.entries(oldCoreEnv)) { + coreEnv._set(key, value) + } + } } // UTILS diff --git a/packages/server/src/tests/utilities/api/attachment.ts b/packages/server/src/tests/utilities/api/attachment.ts new file mode 100644 index 0000000000..a466f1a67e --- /dev/null +++ b/packages/server/src/tests/utilities/api/attachment.ts @@ -0,0 +1,35 @@ +import { + APIError, + Datasource, + ProcessAttachmentResponse, +} from "@budibase/types" +import TestConfiguration from "../TestConfiguration" +import { TestAPI } from "./base" +import fs from "fs" + +export class AttachmentAPI extends TestAPI { + constructor(config: TestConfiguration) { + super(config) + } + + process = async ( + name: string, + file: Buffer | fs.ReadStream | string, + { expectStatus } = { expectStatus: 200 } + ): Promise => { + const result = await this.request + .post(`/api/attachments/process`) + .attach("file", file, name) + .set(this.config.defaultHeaders()) + + if (result.statusCode !== expectStatus) { + throw new Error( + `Expected status ${expectStatus} but got ${ + result.statusCode + }, body: ${JSON.stringify(result.body)}` + ) + } + + return result.body + } +} diff --git a/packages/server/src/tests/utilities/api/index.ts b/packages/server/src/tests/utilities/api/index.ts index fce8237760..30ef7c478d 100644 --- a/packages/server/src/tests/utilities/api/index.ts +++ b/packages/server/src/tests/utilities/api/index.ts @@ -7,6 +7,7 @@ import { DatasourceAPI } from "./datasource" import { LegacyViewAPI } from "./legacyView" import { ScreenAPI } from "./screen" import { ApplicationAPI } from "./application" +import { AttachmentAPI } from "./attachment" export default class API { table: TableAPI @@ -17,6 +18,7 @@ export default class API { datasource: DatasourceAPI screen: ScreenAPI application: ApplicationAPI + attachment: AttachmentAPI constructor(config: TestConfiguration) { this.table = new TableAPI(config) @@ -27,5 +29,6 @@ export default class API { this.datasource = new DatasourceAPI(config) this.screen = new ScreenAPI(config) this.application = new ApplicationAPI(config) + this.attachment = new AttachmentAPI(config) } } diff --git a/packages/types/src/api/web/app/attachment.ts b/packages/types/src/api/web/app/attachment.ts new file mode 100644 index 0000000000..792bdf3885 --- /dev/null +++ b/packages/types/src/api/web/app/attachment.ts @@ -0,0 +1,9 @@ +export interface Upload { + size: number + name: string + url: string + extension: string + key: string +} + +export type ProcessAttachmentResponse = Upload[] diff --git a/packages/types/src/api/web/app/index.ts b/packages/types/src/api/web/app/index.ts index 276d7fa7c1..f5b876009b 100644 --- a/packages/types/src/api/web/app/index.ts +++ b/packages/types/src/api/web/app/index.ts @@ -5,3 +5,4 @@ export * from "./view" export * from "./rows" export * from "./table" export * from "./permission" +export * from "./attachment" From db398a839e056c1db9ecaf8176291f07b72d2831 Mon Sep 17 00:00:00 2001 From: Budibase Staging Release Bot <> Date: Mon, 30 Oct 2023 16:54:07 +0000 Subject: [PATCH 20/21] Bump version to 2.12.1 --- lerna.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lerna.json b/lerna.json index 3179bc3b2e..6df4a4c4cd 100644 --- a/lerna.json +++ b/lerna.json @@ -1,5 +1,5 @@ { - "version": "2.12.0", + "version": "2.12.1", "npmClient": "yarn", "packages": [ "packages/*" From ca9491ce67694db85ff941f639310b5b1c9be56a Mon Sep 17 00:00:00 2001 From: Sam Rose Date: Mon, 30 Oct 2023 16:55:57 +0000 Subject: [PATCH 21/21] Surface error message from attachments API to user. --- packages/builder/src/components/common/Dropzone.svelte | 2 +- .../src/components/grid/cells/AttachmentCell.svelte | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/builder/src/components/common/Dropzone.svelte b/packages/builder/src/components/common/Dropzone.svelte index fd2359fd91..daa6ad1807 100644 --- a/packages/builder/src/components/common/Dropzone.svelte +++ b/packages/builder/src/components/common/Dropzone.svelte @@ -23,7 +23,7 @@ try { return await API.uploadBuilderAttachment(data) } catch (error) { - notifications.error("Failed to upload attachment") + notifications.error(error.message || "Failed to upload attachment") return [] } } diff --git a/packages/frontend-core/src/components/grid/cells/AttachmentCell.svelte b/packages/frontend-core/src/components/grid/cells/AttachmentCell.svelte index a27c31bbe5..fc0001d55e 100644 --- a/packages/frontend-core/src/components/grid/cells/AttachmentCell.svelte +++ b/packages/frontend-core/src/components/grid/cells/AttachmentCell.svelte @@ -55,7 +55,7 @@ try { return await API.uploadBuilderAttachment(data) } catch (error) { - $notifications.error("Failed to upload attachment") + $notifications.error(error.message || "Failed to upload attachment") return [] } }