Merge pull request #14289 from Budibase/fix/import-column-issues

Trim couchdb fields while exporting rows

packages/server/src/api/routes/tests/row.spec.ts

@@ -1640,6 +1640,23 @@ describe.each([
       table = await config.api.table.save(defaultTable())
     })
 
+    isInternal &&
+      it("should not export internal couchdb fields", async () => {
+        const existing = await config.api.row.save(table._id!, {
+          name: generator.guid(),
+          description: generator.paragraph(),
+        })
+        const res = await config.api.row.exportRows(table._id!, {
+          rows: [existing._id!],
+        })
+        const results = JSON.parse(res)
+        expect(results.length).toEqual(1)
+        const row = results[0]
+
+        expect(Object.keys(row)).toEqual(["_id", "name", "description"])
+      })
+
+    !isInternal &&
       it("should allow exporting all columns", async () => {
         const existing = await config.api.row.save(table._id!, {})
         const res = await config.api.row.exportRows(table._id!, {
@@ -1650,9 +1667,7 @@ describe.each([
         const row = results[0]
 
         // Ensure all original columns were exported
-      expect(Object.keys(row).length).toBeGreaterThanOrEqual(
+        expect(Object.keys(row).length).toBe(Object.keys(existing).length)
-        Object.keys(existing).length
-      )
         Object.keys(existing).forEach(key => {
           expect(row[key]).toEqual(existing[key])
         })

packages/server/src/sdk/app/rows/search/internal.ts

@@ -11,6 +11,7 @@ import {
   SearchResponse,
   SortType,
   Table,
+  TableSchema,
   User,
 } from "@budibase/types"
 import { getGlobalUsersFromMetadata } from "../../../../utilities/global"
@@ -137,6 +138,9 @@ export async function exportRows(
   let rows: Row[] = []
   let schema = table.schema
   let headers
+
+  result = trimFields(result, schema)
+
   // Filter data to only specified columns if required
   if (columns && columns.length) {
     for (let i = 0; i < result.length; i++) {
@@ -299,3 +303,13 @@ async function getView(db: Database, viewName: string) {
   }
   return viewInfo
 }
+
+function trimFields(rows: Row[], schema: TableSchema) {
+  const allowedFields = ["_id", ...Object.keys(schema)]
+  const result = rows.map(row =>
+    Object.keys(row)
+      .filter(key => allowedFields.includes(key))
+      .reduce((acc, key) => ({ ...acc, [key]: row[key] }), {} as Row)
+  )
+  return result
+}

packages/server/src/sdk/app/rows/utils.ts

@@ -76,7 +76,7 @@ export async function getDatasourceAndQuery(
 }
 
 export function cleanExportRows(
-  rows: any[],
+  rows: Row[],
   schema: TableSchema,
   format: string,
   columns?: string[],