From 22eafa892c9a8f11512058f54f19ba9780f8f1a0 Mon Sep 17 00:00:00 2001 From: Dean Date: Mon, 16 Sep 2024 13:02:35 +0100 Subject: [PATCH] PR feedback --- packages/client/src/components/app/DataProvider.svelte | 5 +---- .../src/components/app/dynamic-filter/DynamicFilter.svelte | 2 +- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/packages/client/src/components/app/DataProvider.svelte b/packages/client/src/components/app/DataProvider.svelte index a2ba674beb..c05d4de74e 100644 --- a/packages/client/src/components/app/DataProvider.svelte +++ b/packages/client/src/components/app/DataProvider.svelte @@ -17,11 +17,8 @@ let interval let queryExtensions = {} - let localFilters - $: localFilters = filter ? Helpers.cloneDeep(filter) : null - - $: defaultQuery = QueryUtils.buildQuery(localFilters) + $: defaultQuery = QueryUtils.buildQuery(filter) // We need to manage our lucene query manually as we want to allow components // to extend it diff --git a/packages/client/src/components/app/dynamic-filter/DynamicFilter.svelte b/packages/client/src/components/app/dynamic-filter/DynamicFilter.svelte index a1b64b181a..4ab01de17d 100644 --- a/packages/client/src/components/app/dynamic-filter/DynamicFilter.svelte +++ b/packages/client/src/components/app/dynamic-filter/DynamicFilter.svelte @@ -95,7 +95,7 @@ } const updateQuery = () => { - filters = Helpers.cloneDeep(editableFilters) + filters = editableFilters } onDestroy(() => {