From 248764ce9861c1c579f4363cebcd7f017e6abc6e Mon Sep 17 00:00:00 2001 From: Gerard Burns Date: Mon, 22 Apr 2024 08:38:19 +0100 Subject: [PATCH] cleanup --- packages/client/src/components/app/charts/BarChart.svelte | 2 +- .../client/src/components/app/charts/CandleStickChart.svelte | 2 +- .../frontend-core/src/components/grid/cells/HeaderCell.svelte | 1 - 3 files changed, 2 insertions(+), 3 deletions(-) diff --git a/packages/client/src/components/app/charts/BarChart.svelte b/packages/client/src/components/app/charts/BarChart.svelte index 2682fac4d4..3fa03e2caf 100644 --- a/packages/client/src/components/app/charts/BarChart.svelte +++ b/packages/client/src/components/app/charts/BarChart.svelte @@ -79,7 +79,7 @@ text: xAxisLabel } }, - // Providing `type: "datetime"` normally makes Apex Charts parse unix time nicely with no additonal config, but bar charts in horizontal mode don't have a default setting for parsing the labels of dates, and will just spit out the unix time value. It also doesn't seem to respect any date based formatting properties passed in. So we'll just manualy format the labels, the chart still sorts the dates correctly in any case + // Providing `type: "datetime"` normally makes Apex Charts parse unix time nicely with no additonal config, but bar charts in horizontal mode don't have a default setting for parsing the labels of dates, and will just spit out the unix time value. It also doesn't seem to respect any date based formatting properties passed in. So we'll just manually format the labels, the chart still sorts the dates correctly in any case yaxis: { labels: { formatter: yAxisFormatter diff --git a/packages/client/src/components/app/charts/CandleStickChart.svelte b/packages/client/src/components/app/charts/CandleStickChart.svelte index 224e87c067..3ff272b1e0 100644 --- a/packages/client/src/components/app/charts/CandleStickChart.svelte +++ b/packages/client/src/components/app/charts/CandleStickChart.svelte @@ -75,7 +75,7 @@ } const isString = typeof value === "string"; - // "2025" could be either an ISO 8601 date time string or Unix time. + // "2025" could be either an ISO 8601 datetime string or Unix time. // There's no way to tell the user's intent without providing more // granular controls. // We'll just assume any string without dashes is Unix time. diff --git a/packages/frontend-core/src/components/grid/cells/HeaderCell.svelte b/packages/frontend-core/src/components/grid/cells/HeaderCell.svelte index 4f861c84a1..657f618759 100644 --- a/packages/frontend-core/src/components/grid/cells/HeaderCell.svelte +++ b/packages/frontend-core/src/components/grid/cells/HeaderCell.svelte @@ -102,7 +102,6 @@ const editColumn = async () => { editIsOpen = true - console.log(column.schema); await tick() dispatch("edit-column", column.schema) }