update more names from record to model

This commit is contained in:
kevmodrome 2020-04-14 11:25:37 +02:00
parent 4c464e33c9
commit 28854c5c9a
8 changed files with 472 additions and 21 deletions

File diff suppressed because one or more lines are too long

View File

@ -59,7 +59,7 @@ window["##BUDIBASE_APPDEFINITION##"] = {
getShardName: "", getShardName: "",
getSortKey: "record.id", getSortKey: "record.id",
aggregateGroups: [], aggregateGroups: [],
allowedRecordNodeIds: [2], allowedModelNodeIds: [2],
nodeId: 5, nodeId: 5,
}, },
], ],
@ -79,7 +79,7 @@ window["##BUDIBASE_APPDEFINITION##"] = {
getShardName: "", getShardName: "",
getSortKey: "record.id", getSortKey: "record.id",
aggregateGroups: [], aggregateGroups: [],
allowedRecordNodeIds: [1], allowedModelNodeIds: [1],
nodeId: 4, nodeId: 4,
}, },
{ {
@ -91,7 +91,7 @@ window["##BUDIBASE_APPDEFINITION##"] = {
getShardName: "", getShardName: "",
getSortKey: "record.id", getSortKey: "record.id",
aggregateGroups: [], aggregateGroups: [],
allowedRecordNodeIds: [2], allowedModelNodeIds: [2],
nodeId: 6, nodeId: 6,
}, },
], ],

View File

@ -9,7 +9,7 @@ import {
templateApi, templateApi,
isIndex, isIndex,
canDeleteIndex, canDeleteIndex,
canDeleteRecord, canDeleteModel,
} from "components/common/core" } from "components/common/core"
export const getBackendUiStore = () => { export const getBackendUiStore = () => {
@ -217,7 +217,7 @@ export const deleteCurrentNode = store => () => {
const isRecord = hierarchyFunctions.isRecord(nodeToDelete) const isRecord = hierarchyFunctions.isRecord(nodeToDelete)
const check = isRecord const check = isRecord
? canDeleteRecord(nodeToDelete) ? canDeleteModel(nodeToDelete)
: canDeleteIndex(nodeToDelete) : canDeleteIndex(nodeToDelete)
if (!check.canDelete) { if (!check.canDelete) {

View File

@ -10,7 +10,7 @@ import { generateSchema } from "../../../../core/src/indexing/indexSchemaCreator
import { generate } from "shortid" import { generate } from "shortid"
export { canDeleteIndex } from "../../../../core/src/templateApi/canDeleteIndex" export { canDeleteIndex } from "../../../../core/src/templateApi/canDeleteIndex"
export { canDeleteRecord } from "../../../../core/src/templateApi/canDeleteRecord" export { canDeleteModel } from "../../../../core/src/templateApi/canDeleteModel"
export { userWithFullAccess } from "../../../../core/src/index" export { userWithFullAccess } from "../../../../core/src/index"
export { joinKey } from "../../../../core/src/common" export { joinKey } from "../../../../core/src/common"
export { getExactNodeForKey } from "../../../../core/src/templateApi/hierarchy" export { getExactNodeForKey } from "../../../../core/src/templateApi/hierarchy"

View File

@ -9,10 +9,10 @@ import {
import { $ } from "../common" import { $ } from "../common"
import { map, filter, includes } from "lodash/fp" import { map, filter, includes } from "lodash/fp"
export const canDeleteRecord = recordNode => { export const canDeleteModel = modelNode => {
const flatHierarchy = $(recordNode, [findRoot, getFlattenedHierarchy]) const flatHierarchy = $(modelNode, [findRoot, getFlattenedHierarchy])
const ancestors = $(flatHierarchy, [filter(isAncestor(recordNode))]) const ancestors = $(flatHierarchy, [filter(isAncestor(modelNode))])
const belongsToAncestor = i => ancestors.includes(i.parent()) const belongsToAncestor = i => ancestors.includes(i.parent())
@ -26,7 +26,7 @@ export const canDeleteRecord = recordNode => {
), ),
map( map(
i => i =>
`index "${i.name}" indexes this record. Please remove the record from the index, or delete the index` `index "${i.name}" indexes this model. Please remove the model from the index, or delete the index`
), ),
]) ])
@ -39,7 +39,7 @@ export const canDeleteRecord = recordNode => {
return errorsThisNode return errorsThisNode
} }
const errors = errorsForNode(recordNode) const errors = errorsForNode(modelNode)
return { errors, canDelete: errors.length === 0 } return { errors, canDelete: errors.length === 0 }
} }

View File

@ -5,7 +5,7 @@ import {
basicAppHierarchyCreator_WithFields_AndIndexes, basicAppHierarchyCreator_WithFields_AndIndexes,
} from "./specHelpers" } from "./specHelpers"
import { canDeleteIndex } from "../src/templateApi/canDeleteIndex" import { canDeleteIndex } from "../src/templateApi/canDeleteIndex"
import { canDeleteRecord } from "../src/templateApi/canDeleteRecord" import { canDeleteModel } from "../src/templateApi/canDeleteModel"
describe("canDeleteIndex", () => { describe("canDeleteIndex", () => {
it("should return no errors if deltion is valid", async () => { it("should return no errors if deltion is valid", async () => {
@ -49,14 +49,14 @@ describe("canDeleteIndex", () => {
}) })
describe("canDeleteRecord", () => { describe("canDeleteModel", () => {
it("should return no errors when deletion is valid", async () => { it("should return no errors when deletion is valid", async () => {
const { appHierarchy } = await setupApphierarchy( const { appHierarchy } = await setupApphierarchy(
basicAppHierarchyCreator_WithFields basicAppHierarchyCreator_WithFields
) )
appHierarchy.root.indexes = appHierarchy.root.indexes.filter(i => !i.allowedModelNodeIds.includes(appHierarchy.customerRecord.nodeId)) appHierarchy.root.indexes = appHierarchy.root.indexes.filter(i => !i.allowedModelNodeIds.includes(appHierarchy.customerRecord.nodeId))
const result = canDeleteRecord(appHierarchy.customerRecord) const result = canDeleteModel(appHierarchy.customerRecord)
expect(result.canDelete).toBe(true) expect(result.canDelete).toBe(true)
expect(result.errors).toEqual([]) expect(result.errors).toEqual([])
@ -67,7 +67,7 @@ describe("canDeleteRecord", () => {
basicAppHierarchyCreator_WithFields basicAppHierarchyCreator_WithFields
) )
const result = canDeleteRecord(appHierarchy.customerRecord) const result = canDeleteModel(appHierarchy.customerRecord)
expect(result.canDelete).toBe(false) expect(result.canDelete).toBe(false)
expect(result.errors.some(e => e.includes("customer_index"))).toBe(true) expect(result.errors.some(e => e.includes("customer_index"))).toBe(true)
@ -78,7 +78,7 @@ describe("canDeleteRecord", () => {
basicAppHierarchyCreator_WithFields_AndIndexes basicAppHierarchyCreator_WithFields_AndIndexes
) )
const result = canDeleteRecord(appHierarchy.customerRecord) const result = canDeleteModel(appHierarchy.customerRecord)
expect(result.canDelete).toBe(false) expect(result.canDelete).toBe(false)
expect(result.errors.some(e => e.includes("Outstanding Invoices"))).toBe(true) expect(result.errors.some(e => e.includes("Outstanding Invoices"))).toBe(true)

File diff suppressed because one or more lines are too long

View File

@ -59,7 +59,7 @@ window["##BUDIBASE_APPDEFINITION##"] = {
getShardName: "", getShardName: "",
getSortKey: "record.id", getSortKey: "record.id",
aggregateGroups: [], aggregateGroups: [],
allowedRecordNodeIds: [2], allowedModelNodeIds: [2],
nodeId: 5, nodeId: 5,
}, },
], ],
@ -79,7 +79,7 @@ window["##BUDIBASE_APPDEFINITION##"] = {
getShardName: "", getShardName: "",
getSortKey: "record.id", getSortKey: "record.id",
aggregateGroups: [], aggregateGroups: [],
allowedRecordNodeIds: [1], allowedModelNodeIds: [1],
nodeId: 4, nodeId: 4,
}, },
{ {
@ -91,7 +91,7 @@ window["##BUDIBASE_APPDEFINITION##"] = {
getShardName: "", getShardName: "",
getSortKey: "record.id", getSortKey: "record.id",
aggregateGroups: [], aggregateGroups: [],
allowedRecordNodeIds: [2], allowedModelNodeIds: [2],
nodeId: 6, nodeId: 6,
}, },
], ],