From 295b65678c60bcc09114c5260f12b73d4a513843 Mon Sep 17 00:00:00 2001
From: mike12345567 <me@michaeldrury.co.uk>
Date: Fri, 25 Feb 2022 18:02:08 +0000
Subject: [PATCH] Adding test cases for all implemented endpoints.

---
 .../server/src/api/controllers/public/rows.ts |  5 +-
 .../api/routes/public/tests/compare.spec.js   | 47 +++++++++++++++----
 2 files changed, 41 insertions(+), 11 deletions(-)

diff --git a/packages/server/src/api/controllers/public/rows.ts b/packages/server/src/api/controllers/public/rows.ts
index 7a770dabd1..91bd2fe2d1 100644
--- a/packages/server/src/api/controllers/public/rows.ts
+++ b/packages/server/src/api/controllers/public/rows.ts
@@ -51,12 +51,15 @@ export async function read(ctx: any) {
 
 export async function update(ctx: any) {
   ctx.request.body = await addRev(fixRow(ctx.request.body, ctx.params.tableId))
+  await rowController.save(ctx)
   ctx.body = { row: ctx.body }
 }
 
 export async function destroy(ctx: any) {
   // set the body as expected, with the _id and _rev fields
-  ctx.request.body = await addRev(fixRow({}, ctx.params.tableId))
+  ctx.request.body = await addRev(
+    fixRow({ _id: ctx.params.rowId }, ctx.params.tableId)
+  )
   await rowController.destroy(ctx)
   // destroy controller doesn't currently return the row as the body, need to adjust this
   // in the public API to be correct
diff --git a/packages/server/src/api/routes/public/tests/compare.spec.js b/packages/server/src/api/routes/public/tests/compare.spec.js
index 961738cd56..c91be18217 100644
--- a/packages/server/src/api/routes/public/tests/compare.spec.js
+++ b/packages/server/src/api/routes/public/tests/compare.spec.js
@@ -8,10 +8,10 @@ jestOpenAPI(yamlPath)
 
 let request = setup.getRequest()
 let config = setup.getConfig()
-let apiKey, table
+let apiKey, table, app
 
 beforeAll(async () => {
-  await config.init()
+  app = await config.init()
   table = await config.updateTable()
   apiKey = await config.generateApiKey()
 })
@@ -72,29 +72,47 @@ describe("check the applications endpoints", () => {
 
 describe("check the tables endpoints", () => {
   it("should allow retrieving tables through search", async () => {
+    await config.createApp("new app 1")
+    table = await config.updateTable()
     const res = await makeRequest("post", "/tables/search")
     expect(res).toSatisfyApiSpec()
   })
 
   it("should allow creating a table", async () => {
-
+    const res = await makeRequest("post", "/tables", {
+      name: "table name",
+      primaryDisplay: "column1",
+      schema: {
+        column1: {
+          type: "string",
+          constraints: {},
+        }
+      }
+    })
+    expect(res).toSatisfyApiSpec()
   })
 
   it("should allow updating a table", async () => {
-
+    const updated = { ...table, _rev: undefined, name: "new name" }
+    const res = await makeRequest("put", `/tables/${table._id}`, updated)
+    expect(res).toSatisfyApiSpec()
   })
 
   it("should allow retrieving a table", async () => {
-
+    const res = await makeRequest("get", `/tables/${table._id}`)
+    expect(res).toSatisfyApiSpec()
   })
 
   it("should allow deleting a table", async () => {
-
+    const res = await makeRequest("delete", `/tables/${table._id}`)
+    expect(res).toSatisfyApiSpec()
   })
 })
 
 describe("check the rows endpoints", () => {
+  let row
   it("should allow retrieving rows through search", async () => {
+    table = await config.updateTable()
     const res = await makeRequest("post", `/tables/${table._id}/rows/search`, {
       query: {
       },
@@ -103,19 +121,28 @@ describe("check the rows endpoints", () => {
   })
 
   it("should allow creating a row", async () => {
-
+    const res = await makeRequest("post", `/tables/${table._id}/rows`, {
+      name: "test row",
+    })
+    expect(res).toSatisfyApiSpec()
+    row = res.body.row
   })
 
   it("should allow updating a row", async () => {
-
+    const res = await makeRequest("put", `/tables/${table._id}/rows/${row._id}`, {
+      name: "test row updated",
+    })
+    expect(res).toSatisfyApiSpec()
   })
 
   it("should allow retrieving a row", async () => {
-
+    const res = await makeRequest("get", `/tables/${table._id}/rows/${row._id}`)
+    expect(res).toSatisfyApiSpec()
   })
 
   it("should allow deleting a row", async () => {
-
+    const res = await makeRequest("delete", `/tables/${table._id}/rows/${row._id}`)
+    expect(res).toSatisfyApiSpec()
   })
 })