From 2b090c3a62ae5fcd0244ed5258ecbe01cf36bd74 Mon Sep 17 00:00:00 2001 From: Peter Clement Date: Mon, 3 Mar 2025 09:00:02 +0000 Subject: [PATCH] pr comments --- packages/bbui/src/Stores/notifications.ts | 2 +- packages/bbui/src/Table/CellRenderer.svelte | 6 +++--- packages/bbui/src/Table/DateTimeRenderer.svelte | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/packages/bbui/src/Stores/notifications.ts b/packages/bbui/src/Stores/notifications.ts index f4d6625491..174486e611 100644 --- a/packages/bbui/src/Stores/notifications.ts +++ b/packages/bbui/src/Stores/notifications.ts @@ -15,7 +15,7 @@ interface Notification { } export const createNotificationStore = () => { - const timeoutIds = new Set() + const timeoutIds = new Set>() const _notifications = writable([], () => { return () => { // clear all the timers diff --git a/packages/bbui/src/Table/CellRenderer.svelte b/packages/bbui/src/Table/CellRenderer.svelte index a1609bb725..e93eae3ca3 100644 --- a/packages/bbui/src/Table/CellRenderer.svelte +++ b/packages/bbui/src/Table/CellRenderer.svelte @@ -8,9 +8,9 @@ import InternalRenderer from "./InternalRenderer.svelte" import { processStringSync } from "@budibase/string-templates" - export let row: any - export let schema: any - export let value: any + export let row: Record + export let schema: Record + export let value: Record export let customRenderers: { column: string; component: any }[] = [] export let snippets: any diff --git a/packages/bbui/src/Table/DateTimeRenderer.svelte b/packages/bbui/src/Table/DateTimeRenderer.svelte index 607f71e163..7e4d85cab1 100644 --- a/packages/bbui/src/Table/DateTimeRenderer.svelte +++ b/packages/bbui/src/Table/DateTimeRenderer.svelte @@ -7,7 +7,7 @@ // adding the 0- will turn a string like 00:00:00 into a valid ISO // date, but will make actual ISO dates invalid $: time = new Date(`0-${value}`) - $: isTimeOnly = !isNaN(time.getTime()) || schema?.timeOnly + $: isTimeOnly = !isNaN(time as any) || schema?.timeOnly $: isDateOnly = schema?.dateOnly $: format = isTimeOnly ? "HH:mm:ss"