From 2b206f2105681140a1079ba49bcc434df1e7f489 Mon Sep 17 00:00:00 2001
From: Sam Rose <hello@samwho.dev>
Date: Wed, 6 Mar 2024 10:00:02 +0000
Subject: [PATCH] Fix the TODO I left myself last night.

---
 packages/backend-core/src/db/Replication.ts | 41 +++++----------------
 packages/server/src/api/controllers/role.ts | 25 +++++++------
 2 files changed, 23 insertions(+), 43 deletions(-)

diff --git a/packages/backend-core/src/db/Replication.ts b/packages/backend-core/src/db/Replication.ts
index 12c11eb9e2..9c960d76dd 100644
--- a/packages/backend-core/src/db/Replication.ts
+++ b/packages/backend-core/src/db/Replication.ts
@@ -5,56 +5,33 @@ import { DocumentType } from "../constants"
 class Replication {
   source: PouchDB.Database
   target: PouchDB.Database
-  replication?: Promise<any>
 
-  /**
-   *
-   * @param source - the DB you want to replicate or rollback to
-   * @param target - the DB you want to replicate to, or rollback from
-   */
   constructor({ source, target }: { source: string; target: string }) {
     this.source = getPouchDB(source)
     this.target = getPouchDB(target)
   }
 
-  close() {
-    return Promise.all([closePouchDB(this.source), closePouchDB(this.target)])
+  async close() {
+    await Promise.all([closePouchDB(this.source), closePouchDB(this.target)])
   }
 
-  promisify(operation: any, opts = {}) {
-    return new Promise(resolve => {
-      operation(this.target, opts)
-        .on("denied", function (err: any) {
+  replicate(opts: PouchDB.Replication.ReplicateOptions = {}) {
+    return new Promise<PouchDB.Replication.ReplicationResult<{}>>(resolve => {
+      this.source.replicate
+        .to(this.target, opts)
+        .on("denied", function (err) {
           // a document failed to replicate (e.g. due to permissions)
           throw new Error(`Denied: Document failed to replicate ${err}`)
         })
-        .on("complete", function (info: any) {
+        .on("complete", function (info) {
           return resolve(info)
         })
-        .on("error", function (err: any) {
+        .on("error", function (err) {
           throw new Error(`Replication Error: ${err}`)
         })
     })
   }
 
-  /**
-   * Two way replication operation, intended to be promise based.
-   * @param opts - PouchDB replication options
-   */
-  sync(opts: PouchDB.Replication.SyncOptions = {}) {
-    this.replication = this.promisify(this.source.sync, opts)
-    return this.replication
-  }
-
-  /**
-   * One way replication operation, intended to be promise based.
-   * @param opts - PouchDB replication options
-   */
-  replicate(opts: PouchDB.Replication.ReplicateOptions = {}) {
-    this.replication = this.promisify(this.source.replicate.to, opts)
-    return this.replication
-  }
-
   appReplicateOpts(
     opts: PouchDB.Replication.ReplicateOptions = {}
   ): PouchDB.Replication.ReplicateOptions {
diff --git a/packages/server/src/api/controllers/role.ts b/packages/server/src/api/controllers/role.ts
index 6b62c568e2..84179d8dbc 100644
--- a/packages/server/src/api/controllers/role.ts
+++ b/packages/server/src/api/controllers/role.ts
@@ -107,17 +107,20 @@ export async function save(ctx: UserCtx<SaveRoleRequest, SaveRoleResponse>) {
   role._rev = result.rev
   ctx.body = role
 
-  // TODO: need to check that the prod DB actually exists, I think it won't
-  // if the app has never been published.
-  const replication = new dbCore.Replication({
-    source: context.getDevAppDB().name,
-    target: context.getProdAppDB().name,
-  })
-  await replication.replicate({
-    filter: (doc: any, params: any) => {
-      return doc._id === _id
-    },
-  })
+  const devDb = context.getDevAppDB()
+  const prodDb = context.getProdAppDB()
+
+  if (await prodDb.exists()) {
+    const replication = new dbCore.Replication({
+      source: devDb.name,
+      target: prodDb.name,
+    })
+    await replication.replicate({
+      filter: (doc: any, params: any) => {
+        return doc._id === _id
+      },
+    })
+  }
 }
 
 export async function destroy(ctx: UserCtx<void, DestroyRoleResponse>) {