From 2c125bc671b3f899d4f85f7978ff23cbaec77424 Mon Sep 17 00:00:00 2001
From: Andrew Kingston <aptkingston@ssl-mail.com>
Date: Tue, 9 Feb 2021 12:41:21 +0000
Subject: [PATCH] Ensure client data contexts are correctly updated if a parent
 context is updated

---
 .../client/src/components/Provider.svelte     | 17 +++++--
 packages/client/src/store/context.js          | 21 ++++----
 .../standard-components/src/RowDetail.svelte  | 51 +++++++++++--------
 3 files changed, 52 insertions(+), 37 deletions(-)

diff --git a/packages/client/src/components/Provider.svelte b/packages/client/src/components/Provider.svelte
index bc95412bab..3c894f6723 100644
--- a/packages/client/src/components/Provider.svelte
+++ b/packages/client/src/components/Provider.svelte
@@ -11,16 +11,21 @@
   // Clone and create new data context for this component tree
   const context = getContext("context")
   const component = getContext("component")
-  const newContext = createContextStore($context)
+  const newContext = createContextStore()
   setContext("context", newContext)
+
+  let initiated = false
   $: providerKey = key || $component.id
 
+  // Add data context
+  $: {
+    newContext.actions.provideData(providerKey, $context, data)
+    initiated = true
+  }
+
   // Instance ID is unique to each instance of a provider
   let instanceId
 
-  // Add data context
-  $: data !== undefined && newContext.actions.provideData(providerKey, data)
-
   // Add actions context
   $: {
     if (instanceId) {
@@ -51,4 +56,6 @@
   })
 </script>
 
-<slot />
+{#if initiated}
+  <slot />
+{/if}
diff --git a/packages/client/src/store/context.js b/packages/client/src/store/context.js
index 80777cbeff..5725f94231 100644
--- a/packages/client/src/store/context.js
+++ b/packages/client/src/store/context.js
@@ -1,22 +1,20 @@
 import { writable } from "svelte/store"
 
-export const createContextStore = existingContext => {
-  const store = writable({ ...existingContext })
+export const createContextStore = () => {
+  const store = writable({})
 
   // Adds a data context layer to the tree
-  const provideData = (providerId, data) => {
-    if (!providerId) {
-      return
-    }
-    store.update(state => {
-      state[providerId] = data
+  const provideData = (providerId, context, data) => {
+    let newData = { ...context }
+    if (providerId && data !== undefined) {
+      newData[providerId] = data
 
       // Keep track of the closest component ID so we can later hydrate a "data" prop.
       // This is only required for legacy bindings that used "data" rather than a
       // component ID.
-      state.closestComponentId = providerId
-      return state
-    })
+      newData.closestComponentId = providerId
+    }
+    store.set(newData)
   }
 
   // Adds an action context layer to the tree
@@ -32,7 +30,6 @@ export const createContextStore = existingContext => {
 
   return {
     subscribe: store.subscribe,
-    update: store.update,
     actions: { provideData, provideAction },
   }
 }
diff --git a/packages/standard-components/src/RowDetail.svelte b/packages/standard-components/src/RowDetail.svelte
index ed46fd6927..8a413dfb43 100644
--- a/packages/standard-components/src/RowDetail.svelte
+++ b/packages/standard-components/src/RowDetail.svelte
@@ -1,46 +1,57 @@
 <script>
   import { onMount, getContext } from "svelte"
 
-  const { API, screenStore, routeStore, Provider, styleable } = getContext(
-    "sdk"
-  )
-  const component = getContext("component")
-
   export let table
 
+  const {
+    API,
+    screenStore,
+    routeStore,
+    Provider,
+    styleable,
+    ActionTypes,
+  } = getContext("sdk")
+  const component = getContext("component")
   let headers = []
   let row
 
-  async function fetchFirstRow() {
-    const rows = await API.fetchTableData(table)
-    return Array.isArray(rows) && rows.length ? rows[0] : { tableId: table }
+  const fetchFirstRow = async tableId => {
+    const rows = await API.fetchTableData(tableId)
+    return Array.isArray(rows) && rows.length ? rows[0] : { tableId }
   }
 
-  async function fetchData() {
-    if (!table) {
+  const fetchData = async (rowId, tableId) => {
+    if (!tableId) {
       return
     }
 
     const pathParts = window.location.pathname.split("/")
-    const routeParamId = $routeStore.routeParams.id
 
     // if srcdoc, then we assume this is the builder preview
-    if ((pathParts.length === 0 || pathParts[0] === "srcdoc") && table) {
-      row = await fetchFirstRow()
-    } else if (routeParamId) {
-      row = await API.fetchRow({ tableId: table, rowId: routeParamId })
+    if ((pathParts.length === 0 || pathParts[0] === "srcdoc") && tableId) {
+      row = await fetchFirstRow(tableId)
+    } else if (rowId) {
+      row = await API.fetchRow({ tableId, rowId })
     } else {
       throw new Error("Row ID was not supplied to RowDetail")
     }
   }
 
-  onMount(fetchData)
+  $: actions = [
+    {
+      type: ActionTypes.RefreshDatasource,
+      callback: () => fetchData($routeStore.routeParams.id, table),
+      metadata: { datasource: { type: "table", tableId: table } },
+    },
+  ]
+
+  onMount(() => fetchData($routeStore.routeParams.id, table))
 </script>
 
 {#if row}
-  <div use:styleable={$component.styles}>
-    <Provider data={row}>
+  <Provider data={row} {actions}>
+    <div use:styleable={$component.styles}>
       <slot />
-    </Provider>
-  </div>
+    </div>
+  </Provider>
 {/if}