From 2ec6b15e5647560a185a14cd8822604e7ececdf2 Mon Sep 17 00:00:00 2001 From: mike12345567 Date: Tue, 11 May 2021 17:49:26 +0100 Subject: [PATCH] General cleanup, doing away with the concept of hosting in the builder and the generally confusing difference between cloud, self hosting and running locally - server is simply always a server now. --- packages/auth/src/constants.js | 7 ++ .../builder/src/builderStore/store/hosting.js | 21 +--- .../deploy/DeploymentHistory.svelte | 3 +- .../components/settings/tabs/General.svelte | 51 +++++----- .../start/BuilderSettingsModal.svelte | 51 +--------- .../components/start/CreateAppModal.svelte | 29 +++--- .../app/[application]/deploy/index.svelte | 23 +---- .../server/src/api/controllers/application.js | 2 +- .../src/api/controllers/deploy/Deployment.js | 29 ------ .../src/api/controllers/deploy/index.js | 7 -- .../src/api/controllers/deploy/quota.js | 39 -------- .../src/api/controllers/deploy/selfDeploy.js | 38 -------- .../server/src/api/controllers/hosting.js | 46 +++------ packages/server/src/api/controllers/script.js | 10 +- .../src/api/controllers/static/index.js | 2 +- packages/server/src/api/routes/hosting.js | 3 - packages/server/src/api/routes/script.js | 2 +- .../src/api/routes/tests/hosting.spec.js | 95 +------------------ packages/server/src/db/utils.js | 5 - .../server/src/utilities/builder/hosting.js | 86 ----------------- .../server/src/utilities/workerRequests.js | 3 - packages/worker/package.json | 2 +- packages/worker/src/constants/index.js | 9 +- 23 files changed, 72 insertions(+), 491 deletions(-) delete mode 100644 packages/server/src/api/controllers/deploy/quota.js delete mode 100644 packages/server/src/utilities/builder/hosting.js diff --git a/packages/auth/src/constants.js b/packages/auth/src/constants.js index 8ca05066c9..230c80b609 100644 --- a/packages/auth/src/constants.js +++ b/packages/auth/src/constants.js @@ -14,3 +14,10 @@ exports.GlobalRoles = { BUILDER: "builder", GROUP_MANAGER: "group_manager", } + +exports.Configs = { + SETTINGS: "settings", + ACCOUNT: "account", + SMTP: "smtp", + GOOGLE: "google", +} diff --git a/packages/builder/src/builderStore/store/hosting.js b/packages/builder/src/builderStore/store/hosting.js index f180d4157a..fb174c2663 100644 --- a/packages/builder/src/builderStore/store/hosting.js +++ b/packages/builder/src/builderStore/store/hosting.js @@ -2,7 +2,6 @@ import { writable } from "svelte/store" import api, { get } from "../api" const INITIAL_HOSTING_UI_STATE = { - hostingInfo: {}, appUrl: "", deployedApps: {}, deployedAppNames: [], @@ -13,28 +12,12 @@ export const getHostingStore = () => { const store = writable({ ...INITIAL_HOSTING_UI_STATE }) store.actions = { fetch: async () => { - const responses = await Promise.all([ - api.get("/api/hosting/"), - api.get("/api/hosting/urls"), - ]) - const [info, urls] = await Promise.all(responses.map(resp => resp.json())) + const response = await api.get("/api/hosting/urls") + const urls = await response.json() store.update(state => { - state.hostingInfo = info state.appUrl = urls.app return state }) - return info - }, - save: async hostingInfo => { - const response = await api.post("/api/hosting", hostingInfo) - const revision = (await response.json()).rev - store.update(state => { - state.hostingInfo = { - ...hostingInfo, - _rev: revision, - } - return state - }) }, fetchDeployedApps: async () => { let deployments = await (await get("/api/hosting/apps")).json() diff --git a/packages/builder/src/components/deploy/DeploymentHistory.svelte b/packages/builder/src/components/deploy/DeploymentHistory.svelte index fd098235be..dc90acf435 100644 --- a/packages/builder/src/components/deploy/DeploymentHistory.svelte +++ b/packages/builder/src/components/deploy/DeploymentHistory.svelte @@ -36,8 +36,7 @@ let errorReason let poll let deployments = [] - let urlComponent = - $hostingStore.hostingInfo.type === "self" ? $store.url : `/${appId}` + let urlComponent = $store.url || `/${appId}` let deploymentUrl = `${$hostingStore.appUrl}${urlComponent}` const formatDate = (date, format) => diff --git a/packages/builder/src/components/settings/tabs/General.svelte b/packages/builder/src/components/settings/tabs/General.svelte index d5829f9e72..4a8d24ed58 100644 --- a/packages/builder/src/components/settings/tabs/General.svelte +++ b/packages/builder/src/components/settings/tabs/General.svelte @@ -49,27 +49,22 @@ onMount(async () => { const nameError = "Your application must have a name.", urlError = "Your application must have a URL." - let hostingInfo = await hostingStore.actions.fetch() - if (hostingInfo.type === "self") { - await hostingStore.actions.fetchDeployedApps() - const existingAppNames = get(hostingStore).deployedAppNames - const existingAppUrls = get(hostingStore).deployedAppUrls - const nameIdx = existingAppNames.indexOf(get(store).name) - const urlIdx = existingAppUrls.indexOf(get(store).url) - if (nameIdx !== -1) { - existingAppNames.splice(nameIdx, 1) - } - if (urlIdx !== -1) { - existingAppUrls.splice(urlIdx, 1) - } - nameValidation = { - name: string().required(nameError).notOneOf(existingAppNames), - } - urlValidation = { - url: string().required(urlError).notOneOf(existingAppUrls), - } - } else { - nameValidation = { name: string().required(nameError) } + await hostingStore.actions.fetchDeployedApps() + const existingAppNames = get(hostingStore).deployedAppNames + const existingAppUrls = get(hostingStore).deployedAppUrls + const nameIdx = existingAppNames.indexOf(get(store).name) + const urlIdx = existingAppUrls.indexOf(get(store).url) + if (nameIdx !== -1) { + existingAppNames.splice(nameIdx, 1) + } + if (urlIdx !== -1) { + existingAppUrls.splice(urlIdx, 1) + } + nameValidation = { + name: string().required(nameError).notOneOf(existingAppNames), + } + urlValidation = { + url: string().required(urlError).notOneOf(existingAppUrls), } }) @@ -81,14 +76,12 @@ error={nameError} label="App Name" /> - {#if $hostingStore.hostingInfo.type === "self"} - updateApplication({ url: e.detail })} - value={$store.url} - error={urlError} - label="App URL" - /> - {/if} + updateApplication({ url: e.detail })} + value={$store.url} + error={urlError} + label="App URL" + />