From 929c75924703012d6c83bb164561d890bbec2fe6 Mon Sep 17 00:00:00 2001
From: Sam Rose <hello@samwho.dev>
Date: Wed, 12 Mar 2025 16:47:26 +0000
Subject: [PATCH 01/21] wip

---
 .../SetupPanel/AutomationBlockSetup.svelte     |  1 +
 .../SetupPanel/RowSelectorTypes.svelte         |  1 +
 .../common/CodeEditor/CodeEditor.svelte        | 18 +++++++++++++++---
 .../common/bindings/BindingPanel.svelte        |  2 ++
 .../common/bindings/CodeEditorField.svelte     |  1 +
 packages/pro                                   |  2 +-
 packages/types/src/api/web/ai.ts               |  4 ++++
 7 files changed, 25 insertions(+), 4 deletions(-)

diff --git a/packages/builder/src/components/automation/SetupPanel/AutomationBlockSetup.svelte b/packages/builder/src/components/automation/SetupPanel/AutomationBlockSetup.svelte
index eb8cdd27e3..194add5975 100644
--- a/packages/builder/src/components/automation/SetupPanel/AutomationBlockSetup.svelte
+++ b/packages/builder/src/components/automation/SetupPanel/AutomationBlockSetup.svelte
@@ -1059,6 +1059,7 @@
                         inputData[key] = e.detail
                       }}
                       completions={stepCompletions}
+                      {bindings}
                       mode={codeMode}
                       autocompleteEnabled={codeMode !== EditorModes.JS}
                       bind:getCaretPosition
diff --git a/packages/builder/src/components/automation/SetupPanel/RowSelectorTypes.svelte b/packages/builder/src/components/automation/SetupPanel/RowSelectorTypes.svelte
index aefbf02303..3282f89f2d 100644
--- a/packages/builder/src/components/automation/SetupPanel/RowSelectorTypes.svelte
+++ b/packages/builder/src/components/automation/SetupPanel/RowSelectorTypes.svelte
@@ -152,6 +152,7 @@
     <div class="field-wrap json-field">
       <CodeEditor
         value={readableValue}
+        {bindings}
         on:blur={e => {
           onChange({
             row: {
diff --git a/packages/builder/src/components/common/CodeEditor/CodeEditor.svelte b/packages/builder/src/components/common/CodeEditor/CodeEditor.svelte
index b5b2736159..03adde1438 100644
--- a/packages/builder/src/components/common/CodeEditor/CodeEditor.svelte
+++ b/packages/builder/src/components/common/CodeEditor/CodeEditor.svelte
@@ -59,7 +59,11 @@
   import { javascript } from "@codemirror/lang-javascript"
   import { EditorModes } from "./"
   import { themeStore } from "@/stores/portal"
-  import { FeatureFlag, type EditorMode } from "@budibase/types"
+  import {
+    type EnrichedBinding,
+    FeatureFlag,
+    type EditorMode,
+  } from "@budibase/types"
   import { tooltips } from "@codemirror/view"
   import type { BindingCompletion, CodeValidator } from "@/types"
   import { validateHbsTemplate } from "./validator/hbs"
@@ -80,6 +84,7 @@
   export let readonly = false
   export let readonlyLineNumbers = false
   export let dropdown = DropdownPosition.Relative
+  export let bindings: EnrichedBinding[] = []
 
   const dispatch = createEventDispatcher()
 
@@ -100,7 +105,8 @@
   let promptInput: TextArea
   $: aiGenEnabled =
     featureFlag.isEnabled(FeatureFlag.AI_JS_GENERATION) &&
-    mode.name === "javascript"
+    mode.name === "javascript" &&
+    !readonly
 
   $: {
     if (autofocus && isEditorInitialised) {
@@ -165,7 +171,7 @@
     popoverWidth = 30
     let code = ""
     try {
-      const resp = await API.generateJs({ prompt })
+      const resp = await API.generateJs({ prompt, bindings })
       code = resp.code
     } catch (e) {
       console.error(e)
@@ -189,6 +195,7 @@
     suggestedCode = null
     previousContents = null
     resetPopover()
+    dispatch("change", editor.state.doc.toString())
   }
 
   const rejectSuggestion = () => {
@@ -513,6 +520,11 @@
     bind:this={popover}
     minWidth={popoverWidth}
     anchor={popoverAnchor}
+    on:close={() => {
+      if (suggestedCode) {
+        acceptSuggestion()
+      }
+    }}
     align="left-outside"
   >
     {#if promptLoading}
diff --git a/packages/builder/src/components/common/bindings/BindingPanel.svelte b/packages/builder/src/components/common/bindings/BindingPanel.svelte
index 8d5a9321ea..3d9d77509e 100644
--- a/packages/builder/src/components/common/bindings/BindingPanel.svelte
+++ b/packages/builder/src/components/common/bindings/BindingPanel.svelte
@@ -359,6 +359,7 @@
               bind:getCaretPosition
               bind:insertAtPos
               {completions}
+              {bindings}
               {validations}
               autofocus={autofocusEditor}
               placeholder={placeholder ||
@@ -372,6 +373,7 @@
               value={jsValue ? decodeJSBinding(jsValue) : ""}
               on:change={onChangeJSValue}
               {completions}
+              {bindings}
               {validations}
               mode={EditorModes.JS}
               bind:getCaretPosition
diff --git a/packages/builder/src/components/common/bindings/CodeEditorField.svelte b/packages/builder/src/components/common/bindings/CodeEditorField.svelte
index 3a7b388f07..3f2c7570a9 100644
--- a/packages/builder/src/components/common/bindings/CodeEditorField.svelte
+++ b/packages/builder/src/components/common/bindings/CodeEditorField.svelte
@@ -144,6 +144,7 @@
         on:change={onChangeJSValue}
         on:blur
         completions={jsCompletions}
+        {bindings}
         mode={EditorModes.JS}
         bind:getCaretPosition
         bind:insertAtPos
diff --git a/packages/pro b/packages/pro
index a44aec4935..0a71c9147a 160000
--- a/packages/pro
+++ b/packages/pro
@@ -1 +1 @@
-Subproject commit a44aec4935713412feaaddb50b5075a5e748c575
+Subproject commit 0a71c9147ab8ac184013e6ce197b689e160ff663
diff --git a/packages/types/src/api/web/ai.ts b/packages/types/src/api/web/ai.ts
index b97b45c5ee..3962422b77 100644
--- a/packages/types/src/api/web/ai.ts
+++ b/packages/types/src/api/web/ai.ts
@@ -1,6 +1,10 @@
+import { EnrichedBinding } from "../../ui"
+
 export interface GenerateJsRequest {
   prompt: string
+  bindings?: EnrichedBinding[]
 }
+
 export interface GenerateJsResponse {
   code: string
 }

From df5e5d909b249f410549950fc82af2b6d4080b38 Mon Sep 17 00:00:00 2001
From: Sam Rose <hello@samwho.dev>
Date: Wed, 12 Mar 2025 16:50:34 +0000
Subject: [PATCH 02/21] Dispatch blur as well as change.

---
 .../builder/src/components/common/CodeEditor/CodeEditor.svelte   | 1 +
 1 file changed, 1 insertion(+)

diff --git a/packages/builder/src/components/common/CodeEditor/CodeEditor.svelte b/packages/builder/src/components/common/CodeEditor/CodeEditor.svelte
index 03adde1438..78c6179ef9 100644
--- a/packages/builder/src/components/common/CodeEditor/CodeEditor.svelte
+++ b/packages/builder/src/components/common/CodeEditor/CodeEditor.svelte
@@ -196,6 +196,7 @@
     previousContents = null
     resetPopover()
     dispatch("change", editor.state.doc.toString())
+    dispatch("blur", editor.state.doc.toString())
   }
 
   const rejectSuggestion = () => {

From 2399d398bc4e56b0914372a21849f5632c9a0039 Mon Sep 17 00:00:00 2001
From: Sam Rose <hello@samwho.dev>
Date: Thu, 13 Mar 2025 16:25:24 +0000
Subject: [PATCH 03/21] Update pro reference.

---
 packages/pro | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/packages/pro b/packages/pro
index 0a71c9147a..e956fa4a0d 160000
--- a/packages/pro
+++ b/packages/pro
@@ -1 +1 @@
-Subproject commit 0a71c9147ab8ac184013e6ce197b689e160ff663
+Subproject commit e956fa4a0d78570c8507464345a064f4d9964884

From abea3d6ac2432dcca986cb9a5ccfce3c5596e57b Mon Sep 17 00:00:00 2001
From: Sam Rose <hello@samwho.dev>
Date: Thu, 13 Mar 2025 16:38:32 +0000
Subject: [PATCH 04/21] "Fix" automation saving after AI prompt.

---
 packages/bbui/src/Form/Core/TextArea.svelte     | 16 ++++++++++++----
 .../common/CodeEditor/CodeEditor.svelte         | 17 +++++++++++++----
 2 files changed, 25 insertions(+), 8 deletions(-)

diff --git a/packages/bbui/src/Form/Core/TextArea.svelte b/packages/bbui/src/Form/Core/TextArea.svelte
index 4d2e68934f..30c1993f9b 100644
--- a/packages/bbui/src/Form/Core/TextArea.svelte
+++ b/packages/bbui/src/Form/Core/TextArea.svelte
@@ -19,7 +19,7 @@
 
   const dispatch = createEventDispatcher()
 
-  let focus = false
+  let isFocused = false
   let textarea: HTMLTextAreaElement
   let scrollable = false
 
@@ -27,8 +27,16 @@
   $: minHeightString = getStyleString("min-height", minHeight)
   $: dispatch("scrollable", scrollable)
 
+  export function focus() {
+    textarea.focus()
+  }
+
+  export function contents() {
+    return textarea.value
+  }
+
   const onBlur = () => {
-    focus = false
+    isFocused = false
     updateValue()
   }
 
@@ -65,7 +73,7 @@
   style={`${heightString}${minHeightString}`}
   class="spectrum-Textfield spectrum-Textfield--multiline"
   class:is-disabled={disabled}
-  class:is-focused={focus}
+  class:is-focused={isFocused}
 >
   <!-- prettier-ignore -->
   <textarea
@@ -77,7 +85,7 @@
     {readonly}
     {id}
     on:input={onChange}
-    on:focus={() => (focus = true)}
+    on:focus={() => (isFocused = true)}
     on:blur={onBlur}
     on:blur
     on:keypress
diff --git a/packages/builder/src/components/common/CodeEditor/CodeEditor.svelte b/packages/builder/src/components/common/CodeEditor/CodeEditor.svelte
index 78c6179ef9..d68a399955 100644
--- a/packages/builder/src/components/common/CodeEditor/CodeEditor.svelte
+++ b/packages/builder/src/components/common/CodeEditor/CodeEditor.svelte
@@ -173,13 +173,22 @@
     try {
       const resp = await API.generateJs({ prompt, bindings })
       code = resp.code
+
+      if (code === "") {
+        throw new Error(
+          "we didn't understand your prompt, please phrase your request in another way"
+        )
+      }
     } catch (e) {
       console.error(e)
-      notifications.error("Unable to generate code, please try again later.")
+      if (e instanceof Error) {
+        notifications.error(`Unable to generate code: ${e.message}`)
+      } else {
+        notifications.error("Unable to generate code, please try again later.")
+      }
       code = previousContents
-      popoverWidth = 300
       promptLoading = false
-      popover.hide()
+      resetPopover()
       return
     }
     value = code
@@ -532,7 +541,7 @@
       <div class="prompt-spinner">
         <Spinner size="20" color="white" />
       </div>
-    {:else if suggestedCode}
+    {:else if suggestedCode !== null}
       <Button on:click={acceptSuggestion}>Accept</Button>
       <Button on:click={rejectSuggestion}>Reject</Button>
     {:else}

From 0860816ff2646b3b06f6f8c618af77c291f0cc16 Mon Sep 17 00:00:00 2001
From: Sam Rose <hello@samwho.dev>
Date: Thu, 13 Mar 2025 16:58:46 +0000
Subject: [PATCH 05/21] Update pro reference.

---
 packages/pro | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/packages/pro b/packages/pro
index e956fa4a0d..bb1ed6fa96 160000
--- a/packages/pro
+++ b/packages/pro
@@ -1 +1 @@
-Subproject commit e956fa4a0d78570c8507464345a064f4d9964884
+Subproject commit bb1ed6fa96ebed30e30659e47b0712567601f3c0

From 0e676f018365af79d602b1acef43131656ec3344 Mon Sep 17 00:00:00 2001
From: Sam Rose <hello@samwho.dev>
Date: Thu, 13 Mar 2025 17:30:21 +0000
Subject: [PATCH 06/21] Update pro reference.

---
 packages/pro | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/packages/pro b/packages/pro
index bb1ed6fa96..f709bb6a07 160000
--- a/packages/pro
+++ b/packages/pro
@@ -1 +1 @@
-Subproject commit bb1ed6fa96ebed30e30659e47b0712567601f3c0
+Subproject commit f709bb6a07483785c32ebb6f186709450d735ec3

From 9e7dae9a603203658fdd75a22a7697a03eb969a1 Mon Sep 17 00:00:00 2001
From: Adria Navarro <adria@budibase.com>
Date: Fri, 14 Mar 2025 09:05:50 +0100
Subject: [PATCH 07/21] Remove url field in favour of the one from query

---
 .../src/components/integration/RestQueryViewer.svelte  | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/packages/builder/src/components/integration/RestQueryViewer.svelte b/packages/builder/src/components/integration/RestQueryViewer.svelte
index 7bb5022f3c..77f0ce2a5f 100644
--- a/packages/builder/src/components/integration/RestQueryViewer.svelte
+++ b/packages/builder/src/components/integration/RestQueryViewer.svelte
@@ -56,7 +56,7 @@
   let query, datasource
   let breakQs = {},
     requestBindings = {}
-  let saveId, url
+  let saveId
   let response, schema, enabledHeaders
   let authConfigId
   let dynamicVariables, addVariableModal, varBinding, globalDynamicBindings
@@ -91,7 +91,7 @@
   $: datasourceType = datasource?.source
   $: integrationInfo = $integrations[datasourceType]
   $: queryConfig = integrationInfo?.query
-  $: url = buildUrl(url, breakQs)
+  $: url = buildUrl(query?.fields?.path, breakQs)
   $: checkQueryName(url)
   $: responseSuccess = response?.info?.code >= 200 && response?.info?.code < 400
   $: isGet = query?.queryVerb === "read"
@@ -126,7 +126,8 @@
       ?.trim() || inputUrl
 
   function checkQueryName(inputUrl = null) {
-    if (query && (!query.name || query.flags.urlName)) {
+    if (query && (!query.name || query.flags?.urlName)) {
+      query.flags ??= {}
       query.flags.urlName = true
       query.name = cleanUrl(inputUrl)
     }
@@ -426,7 +427,6 @@
     ) {
       query.fields.path = `${datasource.config.url}/${path ? path : ""}`
     }
-    url = buildUrl(query.fields.path, breakQs)
     requestBindings = restUtils.queryParametersToKeyValue(query.parameters)
     authConfigId = getAuthConfigId()
     if (!query.fields.disabledHeaders) {
@@ -524,7 +524,7 @@
           <div class="url">
             <Input
               on:blur={urlChanged}
-              bind:value={url}
+              bind:value={query.fields.path}
               placeholder="http://www.api.com/endpoint"
             />
           </div>

From 9b0b4ba283c820b7d243191d1ede065cf92f6ac4 Mon Sep 17 00:00:00 2001
From: Adria Navarro <adria@budibase.com>
Date: Fri, 14 Mar 2025 09:10:15 +0100
Subject: [PATCH 08/21] Don't check screens usage on creation

---
 .../builder/src/components/integration/RestQueryViewer.svelte | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/packages/builder/src/components/integration/RestQueryViewer.svelte b/packages/builder/src/components/integration/RestQueryViewer.svelte
index 77f0ce2a5f..e0f3a7f2eb 100644
--- a/packages/builder/src/components/integration/RestQueryViewer.svelte
+++ b/packages/builder/src/components/integration/RestQueryViewer.svelte
@@ -504,7 +504,9 @@
             on:save={saveQuery}
           />
           <div class="controls">
-            <ConnectedQueryScreens sourceId={query._id} />
+            {#if query._id}
+              <ConnectedQueryScreens sourceId={query._id} />
+            {/if}
             <div class="access">
               <Label>Access</Label>
               <AccessLevelSelect {query} {saveId} />

From 33330a4b4046e09bfc3470dec9b94fc743ac08fb Mon Sep 17 00:00:00 2001
From: Adria Navarro <adria@budibase.com>
Date: Fri, 14 Mar 2025 09:17:42 +0100
Subject: [PATCH 09/21] Fix save button disabled state

---
 .../integration/RestQueryViewer.svelte         | 18 ++++++++++++++----
 1 file changed, 14 insertions(+), 4 deletions(-)

diff --git a/packages/builder/src/components/integration/RestQueryViewer.svelte b/packages/builder/src/components/integration/RestQueryViewer.svelte
index e0f3a7f2eb..c158b90060 100644
--- a/packages/builder/src/components/integration/RestQueryViewer.svelte
+++ b/packages/builder/src/components/integration/RestQueryViewer.svelte
@@ -50,6 +50,7 @@
     toBindingsArray,
   } from "@/dataBinding"
   import ConnectedQueryScreens from "./ConnectedQueryScreens.svelte"
+  import _ from "lodash"
 
   export let queryId
 
@@ -62,6 +63,7 @@
   let dynamicVariables, addVariableModal, varBinding, globalDynamicBindings
   let restBindings = getRestBindings()
   let nestedSchemaFields = {}
+  let originalQuery
 
   $: staticVariables = datasource?.config?.staticVariables || {}
 
@@ -103,6 +105,9 @@
 
   $: runtimeUrlQueries = readableToRuntimeMap(mergedBindings, breakQs)
 
+  $: isModified =
+    JSON.stringify(originalQuery) !== JSON.stringify(buildQuery(query))
+
   function getSelectedQuery() {
     return cloneDeep(
       $queries.list.find(q => q._id === queryId) || {
@@ -148,8 +153,11 @@
     return qs.length === 0 ? newUrl : `${newUrl}?${qs}`
   }
 
-  function buildQuery() {
-    const newQuery = cloneDeep(query)
+  function buildQuery(fromQuery = query) {
+    if (!fromQuery) {
+      return
+    }
+    const newQuery = cloneDeep(fromQuery)
     const queryString = restUtils.buildQueryString(runtimeUrlQueries)
 
     newQuery.parameters = restUtils.keyValueToQueryParameters(requestBindings)
@@ -158,7 +166,7 @@
         ? readableToRuntimeMap(mergedBindings, newQuery.fields.requestBody)
         : readableToRuntimeBinding(mergedBindings, newQuery.fields.requestBody)
 
-    newQuery.fields.path = url.split("?")[0]
+    newQuery.fields.path = url?.split("?")[0]
     newQuery.fields.queryString = queryString
     newQuery.fields.authConfigId = authConfigId
     newQuery.fields.disabledHeaders = restUtils.flipHeaderState(enabledHeaders)
@@ -481,6 +489,8 @@
       staticVariables,
       restBindings
     )
+
+    originalQuery = _.cloneDeep(buildQuery())
   })
 </script>
 
@@ -532,7 +542,7 @@
           </div>
           <Button primary disabled={!url} on:click={runQuery}>Send</Button>
           <Button
-            disabled={!query.name}
+            disabled={!isModified}
             cta
             on:click={saveQuery}
             tooltip={!hasSchema

From 47350840445f0eb2d035198a13d62a5673d96401 Mon Sep 17 00:00:00 2001
From: Adria Navarro <adria@budibase.com>
Date: Fri, 14 Mar 2025 10:07:53 +0100
Subject: [PATCH 10/21] Use query

---
 .../components/integration/RestQueryViewer.svelte  | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/packages/builder/src/components/integration/RestQueryViewer.svelte b/packages/builder/src/components/integration/RestQueryViewer.svelte
index c158b90060..40d6731207 100644
--- a/packages/builder/src/components/integration/RestQueryViewer.svelte
+++ b/packages/builder/src/components/integration/RestQueryViewer.svelte
@@ -105,8 +105,8 @@
 
   $: runtimeUrlQueries = readableToRuntimeMap(mergedBindings, breakQs)
 
-  $: isModified =
-    JSON.stringify(originalQuery) !== JSON.stringify(buildQuery(query))
+  $: builtQuery = buildQuery(query, runtimeUrlQueries)
+  $: isModified = JSON.stringify(originalQuery) !== JSON.stringify(builtQuery)
 
   function getSelectedQuery() {
     return cloneDeep(
@@ -153,12 +153,12 @@
     return qs.length === 0 ? newUrl : `${newUrl}?${qs}`
   }
 
-  function buildQuery(fromQuery = query) {
+  function buildQuery(fromQuery, urlQueries) {
     if (!fromQuery) {
       return
     }
     const newQuery = cloneDeep(fromQuery)
-    const queryString = restUtils.buildQueryString(runtimeUrlQueries)
+    const queryString = restUtils.buildQueryString(urlQueries)
 
     newQuery.parameters = restUtils.keyValueToQueryParameters(requestBindings)
     newQuery.fields.requestBody =
@@ -177,7 +177,7 @@
   }
 
   async function saveQuery() {
-    const toSave = buildQuery()
+    const toSave = builtQuery
     try {
       const isNew = !query._rev
       const { _id } = await queries.save(toSave.datasourceId, toSave)
@@ -236,7 +236,7 @@
   async function runQuery() {
     try {
       await validateQuery()
-      response = await queries.preview(buildQuery())
+      response = await queries.preview(builtQuery)
       if (response.rows.length === 0) {
         notifications.info("Request did not return any data")
       } else {
@@ -490,7 +490,7 @@
       restBindings
     )
 
-    originalQuery = _.cloneDeep(buildQuery())
+    originalQuery = _.cloneDeep(buildQuery(query, runtimeUrlQueries))
   })
 </script>
 

From 7adc47982d910a5960b10a263142f3f83ce1f9af Mon Sep 17 00:00:00 2001
From: Adria Navarro <adria@budibase.com>
Date: Fri, 14 Mar 2025 10:21:20 +0100
Subject: [PATCH 11/21] Fix bindings check

---
 .../integration/KeyValueBuilder.svelte          | 17 +++++++++++------
 .../integration/RestQueryViewer.svelte          |  8 +++++---
 2 files changed, 16 insertions(+), 9 deletions(-)

diff --git a/packages/builder/src/components/integration/KeyValueBuilder.svelte b/packages/builder/src/components/integration/KeyValueBuilder.svelte
index 7ea7a935c8..7f4d1fbd56 100644
--- a/packages/builder/src/components/integration/KeyValueBuilder.svelte
+++ b/packages/builder/src/components/integration/KeyValueBuilder.svelte
@@ -13,7 +13,7 @@
   import { lowercase } from "@/helpers"
   import DrawerBindableInput from "@/components/common/bindings/DrawerBindableInput.svelte"
 
-  let dispatch = createEventDispatcher()
+  const dispatch = createEventDispatcher()
 
   export let defaults
   export let object = defaults || {}
@@ -47,10 +47,12 @@
   }))
   let fieldActivity = buildFieldActivity(activity)
 
-  $: object = fields.reduce(
-    (acc, next) => ({ ...acc, [next.name]: next.value }),
-    {}
-  )
+  $: object = fields.reduce((acc, next) => {
+    if (next.name) {
+      acc[next.name] = next.value
+    }
+    return acc
+  }, {})
 
   function buildFieldActivity(obj) {
     if (!obj || typeof obj !== "object") {
@@ -78,16 +80,19 @@
   }
 
   function changed() {
+    // Required for reactivity
     fields = fields
     const newActivity = {}
+    const trimmedFields = []
     for (let idx = 0; idx < fields.length; idx++) {
       const fieldName = fields[idx].name
       if (fieldName) {
         newActivity[fieldName] = fieldActivity[idx]
+        trimmedFields.push(fields[idx])
       }
     }
     activity = newActivity
-    dispatch("change", fields)
+    dispatch("change", trimmedFields)
   }
 
   function isJsonArray(value) {
diff --git a/packages/builder/src/components/integration/RestQueryViewer.svelte b/packages/builder/src/components/integration/RestQueryViewer.svelte
index 40d6731207..b9cfc788f3 100644
--- a/packages/builder/src/components/integration/RestQueryViewer.svelte
+++ b/packages/builder/src/components/integration/RestQueryViewer.svelte
@@ -105,7 +105,7 @@
 
   $: runtimeUrlQueries = readableToRuntimeMap(mergedBindings, breakQs)
 
-  $: builtQuery = buildQuery(query, runtimeUrlQueries)
+  $: builtQuery = buildQuery(query, runtimeUrlQueries, requestBindings)
   $: isModified = JSON.stringify(originalQuery) !== JSON.stringify(builtQuery)
 
   function getSelectedQuery() {
@@ -153,7 +153,7 @@
     return qs.length === 0 ? newUrl : `${newUrl}?${qs}`
   }
 
-  function buildQuery(fromQuery, urlQueries) {
+  function buildQuery(fromQuery, urlQueries, requestBindings) {
     if (!fromQuery) {
       return
     }
@@ -490,7 +490,9 @@
       restBindings
     )
 
-    originalQuery = _.cloneDeep(buildQuery(query, runtimeUrlQueries))
+    originalQuery = _.cloneDeep(
+      buildQuery(query, runtimeUrlQueries, requestBindings)
+    )
   })
 </script>
 

From a196faf71748a989b4bf0b0851aac4c730c05651 Mon Sep 17 00:00:00 2001
From: Adria Navarro <adria@budibase.com>
Date: Fri, 14 Mar 2025 10:28:07 +0100
Subject: [PATCH 12/21] Fix saves and initial values

---
 .../components/integration/KeyValueBuilder.svelte   | 13 +++++++++----
 .../components/integration/RestQueryViewer.svelte   | 10 +++++-----
 2 files changed, 14 insertions(+), 9 deletions(-)

diff --git a/packages/builder/src/components/integration/KeyValueBuilder.svelte b/packages/builder/src/components/integration/KeyValueBuilder.svelte
index 7f4d1fbd56..2a1f3901ea 100644
--- a/packages/builder/src/components/integration/KeyValueBuilder.svelte
+++ b/packages/builder/src/components/integration/KeyValueBuilder.svelte
@@ -47,9 +47,14 @@
   }))
   let fieldActivity = buildFieldActivity(activity)
 
-  $: object = fields.reduce((acc, next) => {
-    if (next.name) {
-      acc[next.name] = next.value
+  $: fullObject = fields.reduce((acc, next) => {
+    acc[next.name] = next.value
+    return acc
+  }, {})
+
+  $: object = Object.entries(fullObject).reduce((acc, [key, next]) => {
+    if (key) {
+      acc[key] = next
     }
     return acc
   }, {})
@@ -107,7 +112,7 @@
 </script>
 
 <!-- Builds Objects with Key Value Pairs. Useful for building things like Request Headers. -->
-{#if Object.keys(object || {}).length > 0}
+{#if Object.keys(fullObject || {}).length > 0}
   {#if headings}
     <div class="container" class:container-active={toggle}>
       <Label {tooltip}>{keyHeading || keyPlaceholder}</Label>
diff --git a/packages/builder/src/components/integration/RestQueryViewer.svelte b/packages/builder/src/components/integration/RestQueryViewer.svelte
index b9cfc788f3..a9456e7718 100644
--- a/packages/builder/src/components/integration/RestQueryViewer.svelte
+++ b/packages/builder/src/components/integration/RestQueryViewer.svelte
@@ -63,7 +63,6 @@
   let dynamicVariables, addVariableModal, varBinding, globalDynamicBindings
   let restBindings = getRestBindings()
   let nestedSchemaFields = {}
-  let originalQuery
 
   $: staticVariables = datasource?.config?.staticVariables || {}
 
@@ -105,6 +104,7 @@
 
   $: runtimeUrlQueries = readableToRuntimeMap(mergedBindings, breakQs)
 
+  $: originalQuery = originalQuery ?? _.cloneDeep(query)
   $: builtQuery = buildQuery(query, runtimeUrlQueries, requestBindings)
   $: isModified = JSON.stringify(originalQuery) !== JSON.stringify(builtQuery)
 
@@ -198,6 +198,10 @@
         staticVariables,
         restBindings
       )
+
+      // Force rebuilding original query
+      originalQuery = null
+
       if (isNew) {
         $goto(`../../${_id}`)
       }
@@ -489,10 +493,6 @@
       staticVariables,
       restBindings
     )
-
-    originalQuery = _.cloneDeep(
-      buildQuery(query, runtimeUrlQueries, requestBindings)
-    )
   })
 </script>
 

From d9adad303fb31d156ebfb5782b09aee84c2ba129 Mon Sep 17 00:00:00 2001
From: Adria Navarro <adria@budibase.com>
Date: Fri, 14 Mar 2025 10:32:08 +0100
Subject: [PATCH 13/21] Saving state

---
 .../src/components/integration/RestQueryViewer.svelte       | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/packages/builder/src/components/integration/RestQueryViewer.svelte b/packages/builder/src/components/integration/RestQueryViewer.svelte
index a9456e7718..4041e5a478 100644
--- a/packages/builder/src/components/integration/RestQueryViewer.svelte
+++ b/packages/builder/src/components/integration/RestQueryViewer.svelte
@@ -63,6 +63,7 @@
   let dynamicVariables, addVariableModal, varBinding, globalDynamicBindings
   let restBindings = getRestBindings()
   let nestedSchemaFields = {}
+  let saving
 
   $: staticVariables = datasource?.config?.staticVariables || {}
 
@@ -178,6 +179,7 @@
 
   async function saveQuery() {
     const toSave = builtQuery
+    saving = true
     try {
       const isNew = !query._rev
       const { _id } = await queries.save(toSave.datasourceId, toSave)
@@ -207,6 +209,8 @@
       }
     } catch (err) {
       notifications.error(`Error saving query`)
+    } finally {
+      saving = false
     }
   }
 
@@ -544,7 +548,7 @@
           </div>
           <Button primary disabled={!url} on:click={runQuery}>Send</Button>
           <Button
-            disabled={!isModified}
+            disabled={!isModified || saving}
             cta
             on:click={saveQuery}
             tooltip={!hasSchema

From fcd7ef2e0b8b86fc01d8447079c3b34c84bff436 Mon Sep 17 00:00:00 2001
From: Adria Navarro <adria@budibase.com>
Date: Fri, 14 Mar 2025 10:40:44 +0100
Subject: [PATCH 14/21] Fix param handler

---
 .../integration/RestQueryViewer.svelte        | 24 ++++++-------------
 1 file changed, 7 insertions(+), 17 deletions(-)

diff --git a/packages/builder/src/components/integration/RestQueryViewer.svelte b/packages/builder/src/components/integration/RestQueryViewer.svelte
index 4041e5a478..09b544e07c 100644
--- a/packages/builder/src/components/integration/RestQueryViewer.svelte
+++ b/packages/builder/src/components/integration/RestQueryViewer.svelte
@@ -392,13 +392,6 @@
     }
   }
 
-  const paramsChanged = evt => {
-    breakQs = {}
-    for (let param of evt.detail) {
-      breakQs[param.name] = param.value
-    }
-  }
-
   const urlChanged = evt => {
     breakQs = {}
     const qs = evt.target.value.split("?")[1]
@@ -575,16 +568,13 @@
             />
           </Tab>
           <Tab title="Params">
-            {#key breakQs}
-              <KeyValueBuilder
-                on:change={paramsChanged}
-                object={breakQs}
-                name="param"
-                headings
-                bindings={mergedBindings}
-                bindingDrawerLeft="260px"
-              />
-            {/key}
+            <KeyValueBuilder
+              bind:object={breakQs}
+              name="param"
+              headings
+              bindings={mergedBindings}
+              bindingDrawerLeft="260px"
+            />
           </Tab>
           <Tab title="Headers">
             <KeyValueBuilder

From da654f6f8ec9af23f6f90bed8143f8f86e516ee0 Mon Sep 17 00:00:00 2001
From: Adria Navarro <adria@budibase.com>
Date: Fri, 14 Mar 2025 10:58:37 +0100
Subject: [PATCH 15/21] Fix flash on creation

---
 .../components/integration/RestQueryViewer.svelte   | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/packages/builder/src/components/integration/RestQueryViewer.svelte b/packages/builder/src/components/integration/RestQueryViewer.svelte
index 09b544e07c..d7fe379829 100644
--- a/packages/builder/src/components/integration/RestQueryViewer.svelte
+++ b/packages/builder/src/components/integration/RestQueryViewer.svelte
@@ -184,8 +184,6 @@
       const isNew = !query._rev
       const { _id } = await queries.save(toSave.datasourceId, toSave)
       saveId = _id
-      query = getSelectedQuery()
-      notifications.success(`Request saved successfully`)
       if (dynamicVariables) {
         datasource.config.dynamicVariables = rebuildVariables(saveId)
         datasource = await datasources.save({
@@ -193,6 +191,13 @@
           datasource,
         })
       }
+
+      notifications.success(`Request saved successfully`)
+      if (isNew) {
+        $goto(`../../${_id}`)
+      }
+
+      query = getSelectedQuery()
       prettifyQueryRequestBody(
         query,
         requestBindings,
@@ -203,10 +208,6 @@
 
       // Force rebuilding original query
       originalQuery = null
-
-      if (isNew) {
-        $goto(`../../${_id}`)
-      }
     } catch (err) {
       notifications.error(`Error saving query`)
     } finally {

From 53d0eb5cf983e517de3d445b58d0b363b56fefe2 Mon Sep 17 00:00:00 2001
From: Adria Navarro <adria@budibase.com>
Date: Fri, 14 Mar 2025 11:06:15 +0100
Subject: [PATCH 16/21] Disable name editing on save

---
 .../builder/src/components/common/inputs/EditableLabel.svelte | 2 ++
 .../builder/src/components/integration/RestQueryViewer.svelte | 4 ++++
 2 files changed, 6 insertions(+)

diff --git a/packages/builder/src/components/common/inputs/EditableLabel.svelte b/packages/builder/src/components/common/inputs/EditableLabel.svelte
index 57fd2621a1..d8ceac4d4c 100644
--- a/packages/builder/src/components/common/inputs/EditableLabel.svelte
+++ b/packages/builder/src/components/common/inputs/EditableLabel.svelte
@@ -9,6 +9,8 @@
   export let type = "label"
   export let size = "M"
 
+  export const disableEditingState = () => setEditing(false)
+
   let editing = false
 
   function setEditing(state) {
diff --git a/packages/builder/src/components/integration/RestQueryViewer.svelte b/packages/builder/src/components/integration/RestQueryViewer.svelte
index d7fe379829..2b04581aac 100644
--- a/packages/builder/src/components/integration/RestQueryViewer.svelte
+++ b/packages/builder/src/components/integration/RestQueryViewer.svelte
@@ -64,6 +64,7 @@
   let restBindings = getRestBindings()
   let nestedSchemaFields = {}
   let saving
+  let queryNameLabel
 
   $: staticVariables = datasource?.config?.staticVariables || {}
 
@@ -208,6 +209,8 @@
 
       // Force rebuilding original query
       originalQuery = null
+
+      queryNameLabel.disableEditingState()
     } catch (err) {
       notifications.error(`Error saving query`)
     } finally {
@@ -507,6 +510,7 @@
       <Layout gap="S">
         <div class="top-bar">
           <EditableLabel
+            bind:this={queryNameLabel}
             type="heading"
             bind:value={query.name}
             defaultValue="Untitled"

From 480042eda991c62396afee7fd36705b4ca6879a3 Mon Sep 17 00:00:00 2001
From: Adria Navarro <adria@budibase.com>
Date: Fri, 14 Mar 2025 11:11:08 +0100
Subject: [PATCH 17/21] Dont allow saving without a name

---
 .../builder/src/components/integration/RestQueryViewer.svelte   | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/packages/builder/src/components/integration/RestQueryViewer.svelte b/packages/builder/src/components/integration/RestQueryViewer.svelte
index 2b04581aac..847bb1c729 100644
--- a/packages/builder/src/components/integration/RestQueryViewer.svelte
+++ b/packages/builder/src/components/integration/RestQueryViewer.svelte
@@ -546,7 +546,7 @@
           </div>
           <Button primary disabled={!url} on:click={runQuery}>Send</Button>
           <Button
-            disabled={!isModified || saving}
+            disabled={!query.name || !isModified || saving}
             cta
             on:click={saveQuery}
             tooltip={!hasSchema

From 49ef14237f704487f89d0eff36e724acfb7df2c5 Mon Sep 17 00:00:00 2001
From: Adria Navarro <adria@budibase.com>
Date: Fri, 14 Mar 2025 11:17:17 +0100
Subject: [PATCH 18/21] Fix auth state

---
 .../integration/RestQueryViewer.svelte        | 21 +------------------
 1 file changed, 1 insertion(+), 20 deletions(-)

diff --git a/packages/builder/src/components/integration/RestQueryViewer.svelte b/packages/builder/src/components/integration/RestQueryViewer.svelte
index 847bb1c729..828bf91fce 100644
--- a/packages/builder/src/components/integration/RestQueryViewer.svelte
+++ b/packages/builder/src/components/integration/RestQueryViewer.svelte
@@ -59,7 +59,6 @@
     requestBindings = {}
   let saveId
   let response, schema, enabledHeaders
-  let authConfigId
   let dynamicVariables, addVariableModal, varBinding, globalDynamicBindings
   let restBindings = getRestBindings()
   let nestedSchemaFields = {}
@@ -170,7 +169,6 @@
 
     newQuery.fields.path = url?.split("?")[0]
     newQuery.fields.queryString = queryString
-    newQuery.fields.authConfigId = authConfigId
     newQuery.fields.disabledHeaders = restUtils.flipHeaderState(enabledHeaders)
     newQuery.schema = schema || {}
     newQuery.nestedSchemaFields = nestedSchemaFields || {}
@@ -270,22 +268,6 @@
     }
   }
 
-  const getAuthConfigId = () => {
-    let id = query.fields.authConfigId
-    if (id) {
-      // find the matching config on the datasource
-      const matchedConfig = datasource?.config?.authConfigs?.filter(
-        c => c._id === id
-      )[0]
-      // clear the id if the config is not found (deleted)
-      // i.e. just show 'None' in the dropdown
-      if (!matchedConfig) {
-        id = undefined
-      }
-    }
-    return id
-  }
-
   const buildAuthConfigs = datasource => {
     if (datasource?.config?.authConfigs) {
       return datasource.config.authConfigs.map(c => ({
@@ -441,7 +423,6 @@
       query.fields.path = `${datasource.config.url}/${path ? path : ""}`
     }
     requestBindings = restUtils.queryParametersToKeyValue(query.parameters)
-    authConfigId = getAuthConfigId()
     if (!query.fields.disabledHeaders) {
       query.fields.disabledHeaders = {}
     }
@@ -667,7 +648,7 @@
                 label="Auth"
                 labelPosition="left"
                 placeholder="None"
-                bind:value={authConfigId}
+                bind:value={query.fields.authConfigId}
                 options={authConfigs}
               />
             </div>

From 3cb73ab2be8047a96077deef6df1ccf31db7245b Mon Sep 17 00:00:00 2001
From: Adria Navarro <adria@budibase.com>
Date: Fri, 14 Mar 2025 11:35:05 +0100
Subject: [PATCH 19/21] Autosave rest auth

---
 .../_components/panels/Authentication/index.svelte | 14 +++++++++++---
 .../_components/panels/SaveDatasourceButton.svelte | 10 ++--------
 .../builder/src/stores/builder/integrations.ts     | 12 ++++++++++--
 3 files changed, 23 insertions(+), 13 deletions(-)

diff --git a/packages/builder/src/pages/builder/app/[application]/data/datasource/[datasourceId]/_components/panels/Authentication/index.svelte b/packages/builder/src/pages/builder/app/[application]/data/datasource/[datasourceId]/_components/panels/Authentication/index.svelte
index 439ef961ed..e9a46b50bb 100644
--- a/packages/builder/src/pages/builder/app/[application]/data/datasource/[datasourceId]/_components/panels/Authentication/index.svelte
+++ b/packages/builder/src/pages/builder/app/[application]/data/datasource/[datasourceId]/_components/panels/Authentication/index.svelte
@@ -1,20 +1,28 @@
 <script>
   import RestAuthenticationBuilder from "./RestAuthenticationBuilder.svelte"
   import { cloneDeep } from "lodash/fp"
-  import SaveDatasourceButton from "../SaveDatasourceButton.svelte"
   import Panel from "../Panel.svelte"
   import Tooltip from "../Tooltip.svelte"
+  import { integrations } from "@/stores/builder"
 
   export let datasource
   $: updatedDatasource = cloneDeep(datasource)
 
-  const updateAuthConfigs = newAuthConfigs => {
+  const updateAuthConfigs = async newAuthConfigs => {
     updatedDatasource.config.authConfigs = newAuthConfigs
+
+    try {
+      await integrations.saveDatasource(updatedDatasource)
+      notifications.success(
+        `Datasource ${updatedDatasource.name} updated successfully`
+      )
+    } catch (error) {
+      notifications.error(`Error saving datasource: ${error.message}`)
+    }
   }
 </script>
 
 <Panel>
-  <SaveDatasourceButton slot="controls" {datasource} {updatedDatasource} />
   <Tooltip
     slot="tooltip"
     title="REST Authentication"
diff --git a/packages/builder/src/pages/builder/app/[application]/data/datasource/[datasourceId]/_components/panels/SaveDatasourceButton.svelte b/packages/builder/src/pages/builder/app/[application]/data/datasource/[datasourceId]/_components/panels/SaveDatasourceButton.svelte
index 4bbeba728a..412f1d3ae7 100644
--- a/packages/builder/src/pages/builder/app/[application]/data/datasource/[datasourceId]/_components/panels/SaveDatasourceButton.svelte
+++ b/packages/builder/src/pages/builder/app/[application]/data/datasource/[datasourceId]/_components/panels/SaveDatasourceButton.svelte
@@ -1,8 +1,6 @@
 <script>
-  import { get } from "svelte/store"
   import { isEqual } from "lodash"
-  import { integrationForDatasource } from "@/stores/selectors"
-  import { integrations, datasources } from "@/stores/builder"
+  import { integrations } from "@/stores/builder"
   import { notifications, Button } from "@budibase/bbui"
 
   export let datasource
@@ -12,11 +10,7 @@
 
   const save = async () => {
     try {
-      const integration = integrationForDatasource(
-        get(integrations),
-        updatedDatasource
-      )
-      await datasources.save({ datasource: updatedDatasource, integration })
+      await integrations.saveDatasource(updatedDatasource)
       notifications.success(
         `Datasource ${updatedDatasource.name} updated successfully`
       )
diff --git a/packages/builder/src/stores/builder/integrations.ts b/packages/builder/src/stores/builder/integrations.ts
index b48f45a654..9a1fffe80b 100644
--- a/packages/builder/src/stores/builder/integrations.ts
+++ b/packages/builder/src/stores/builder/integrations.ts
@@ -1,6 +1,8 @@
-import { writable, type Writable } from "svelte/store"
+import { get, writable, type Writable } from "svelte/store"
 import { API } from "@/api"
-import { Integration } from "@budibase/types"
+import { Datasource, Integration } from "@budibase/types"
+import { integrationForDatasource } from "@/stores/selectors"
+import { datasources } from "./datasources"
 
 type IntegrationsState = Record<string, Integration>
 
@@ -25,9 +27,15 @@ const createIntegrationsStore = () => {
     store.set(integrations)
   }
 
+  const saveDatasource = async (datasource: Datasource) => {
+    const integration = integrationForDatasource(get(store), datasource)
+    await datasources.save({ datasource, integration })
+  }
+
   return {
     ...store,
     init,
+    saveDatasource,
   }
 }
 

From d5c0a89fdc5ccc71327fcf966b49614326a4a519 Mon Sep 17 00:00:00 2001
From: Adria Navarro <adria@budibase.com>
Date: Fri, 14 Mar 2025 12:07:25 +0100
Subject: [PATCH 20/21] Remove duplicated cloneDeep

---
 .../builder/src/components/integration/RestQueryViewer.svelte  | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/packages/builder/src/components/integration/RestQueryViewer.svelte b/packages/builder/src/components/integration/RestQueryViewer.svelte
index 828bf91fce..372d435033 100644
--- a/packages/builder/src/components/integration/RestQueryViewer.svelte
+++ b/packages/builder/src/components/integration/RestQueryViewer.svelte
@@ -50,7 +50,6 @@
     toBindingsArray,
   } from "@/dataBinding"
   import ConnectedQueryScreens from "./ConnectedQueryScreens.svelte"
-  import _ from "lodash"
 
   export let queryId
 
@@ -105,7 +104,7 @@
 
   $: runtimeUrlQueries = readableToRuntimeMap(mergedBindings, breakQs)
 
-  $: originalQuery = originalQuery ?? _.cloneDeep(query)
+  $: originalQuery = originalQuery ?? cloneDeep(query)
   $: builtQuery = buildQuery(query, runtimeUrlQueries, requestBindings)
   $: isModified = JSON.stringify(originalQuery) !== JSON.stringify(builtQuery)
 

From 17bc7000ee42c3a144bc9604435ecf5f99df5466 Mon Sep 17 00:00:00 2001
From: Adria Navarro <adria@budibase.com>
Date: Fri, 14 Mar 2025 12:10:43 +0100
Subject: [PATCH 21/21] Fix notifications

---
 .../_components/panels/Authentication/index.svelte               | 1 +
 1 file changed, 1 insertion(+)

diff --git a/packages/builder/src/pages/builder/app/[application]/data/datasource/[datasourceId]/_components/panels/Authentication/index.svelte b/packages/builder/src/pages/builder/app/[application]/data/datasource/[datasourceId]/_components/panels/Authentication/index.svelte
index e9a46b50bb..f0bf39f4c1 100644
--- a/packages/builder/src/pages/builder/app/[application]/data/datasource/[datasourceId]/_components/panels/Authentication/index.svelte
+++ b/packages/builder/src/pages/builder/app/[application]/data/datasource/[datasourceId]/_components/panels/Authentication/index.svelte
@@ -4,6 +4,7 @@
   import Panel from "../Panel.svelte"
   import Tooltip from "../Tooltip.svelte"
   import { integrations } from "@/stores/builder"
+  import { notifications } from "@budibase/bbui"
 
   export let datasource
   $: updatedDatasource = cloneDeep(datasource)