MirrorSave
/
budibase
mirror of https://github.com/Budibase/budibase.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix: Default props were mutated - cause very strange issue with event handlers

This commit is contained in:
Michael Shanks 2020-10-12 16:27:34 +01:00
parent 98138296c7
commit 376b8b40d7
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
packages/builder/src/components/userInterface/pagesParsing/createProps.js
View File

@ -1,4 +1,4 @@
import { isString, isUndefined } from "lodash/fp" import { isString, isUndefined, cloneDeep } from "lodash/fp"
import { TYPE_MAP } from "./types" import { TYPE_MAP } from "./types"
import { assign } from "lodash" import { assign } from "lodash"
import { uuid } from "builderStore/uuid" import { uuid } from "builderStore/uuid"
@ -83,13 +83,13 @@ const parsePropDef = propDef => {
if (isString(propDef)) { if (isString(propDef)) {
if (!TYPE_MAP[propDef]) return error(`Type ${propDef} is not recognised.`) if (!TYPE_MAP[propDef]) return error(`Type ${propDef} is not recognised.`)
return TYPE_MAP[propDef].default return cloneDeep(TYPE_MAP[propDef].default)
} }
const type = TYPE_MAP[propDef.type] const type = TYPE_MAP[propDef.type]
if (!type) return error(`Type ${propDef.type} is not recognised.`) if (!type) return error(`Type ${propDef.type} is not recognised.`)
return propDef.default return cloneDeep(propDef.default)
} }
export const arrayElementComponentName = (parentComponentName, arrayPropName) => export const arrayElementComponentName = (parentComponentName, arrayPropName) =>