Merge pull request #12274 from Budibase/ensure-bbtmp-exists

Eliminate TOCTOU problem in creating bbTmp.
2023-11-03 16:00:27 +00:00 · 2023-11-03 16:00:27 +00:00 · 38d7dfda92
parent 8fed47766a ea0ca11202
commit 38d7dfda92
1 changed files with 5 additions and 1 deletions
--- a/packages/backend-core/src/objectStore/utils.ts
+++ b/packages/backend-core/src/objectStore/utils.ts
@ -18,8 +18,12 @@ export const ObjectStoreBuckets = {
 }

 const bbTmp = join(tmpdir(), ".budibase")
-if (!fs.existsSync(bbTmp)) {
+try {
  fs.mkdirSync(bbTmp)
+} catch (e: any) {
+  if (e.code !== "EEXIST") {
+    throw e
+  }
 }

 export function budibaseTempDir() {