Merge branch 'master' into typing/stores-grid-ui

This commit is contained in:
Adria Navarro 2024-12-30 14:57:33 +01:00 committed by GitHub
commit 3a6e0406cf
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
25 changed files with 778 additions and 537 deletions

View File

@ -51,6 +51,7 @@
}
input.hide-arrows {
-moz-appearance: textfield;
appearance: textfield;
}
input[type="time"]::-webkit-calendar-picker-indicator {
display: none;

View File

@ -39,6 +39,7 @@
padding: 0;
margin: 0;
-webkit-appearance: none;
appearance: none;
background: transparent;
}
input::-webkit-slider-thumb {

View File

@ -124,8 +124,6 @@
.spectrum-Tabs-selectionIndicator.emphasized {
background-color: var(--spectrum-global-color-blue-400);
}
.spectrum-Tabs--horizontal .spectrum-Tabs-selectionIndicator {
}
.noHorizPadding {
padding: 0;
}

View File

@ -134,6 +134,7 @@
.spectrum-Tooltip-label {
display: -webkit-box;
-webkit-line-clamp: 3;
line-clamp: 3;
-webkit-box-orient: vertical;
overflow: hidden;
font-size: 12px;

View File

@ -94,6 +94,7 @@
"@sveltejs/vite-plugin-svelte": "1.4.0",
"@testing-library/jest-dom": "6.4.2",
"@testing-library/svelte": "^4.1.0",
"@types/shortid": "^2.2.0",
"babel-jest": "^29.6.2",
"identity-obj-proxy": "^3.0.0",
"jest": "29.7.0",

View File

@ -1507,7 +1507,12 @@ export const updateReferencesInObject = ({
// Migrate references
// Switch all bindings to reference their ids
export const migrateReferencesInObject = ({ obj, label = "steps", steps }) => {
export const migrateReferencesInObject = ({
obj,
label = "steps",
steps,
originalIndex,
}) => {
const stepIndexRegex = new RegExp(`{{\\s*${label}\\.(\\d+)\\.`, "g")
const updateActionStep = (str, index, replaceWith) =>
str.replace(`{{ ${label}.${index}.`, `{{ ${label}.${replaceWith}.`)
@ -1528,6 +1533,7 @@ export const migrateReferencesInObject = ({ obj, label = "steps", steps }) => {
migrateReferencesInObject({
obj: obj[key],
steps,
originalIndex,
})
}
}

View File

@ -1,7 +1,54 @@
import { API } from "api"
import { BudiStore } from "../BudiStore"
import {
App,
AppFeatures,
AppIcon,
AutomationSettings,
Plugin,
} from "@budibase/types"
export const INITIAL_APP_META_STATE = {
interface ClientFeatures {
spectrumThemes: boolean
intelligentLoading: boolean
deviceAwareness: boolean
state: boolean
rowSelection: boolean
customThemes: boolean
devicePreview: boolean
messagePassing: boolean
continueIfAction: boolean
showNotificationAction: boolean
sidePanel: boolean
}
interface TypeSupportPresets {
[key: string]: any
}
interface AppMetaState {
appId: string
name: string
url: string
libraries: string[]
clientFeatures: ClientFeatures
typeSupportPresets: TypeSupportPresets
features: AppFeatures
clientLibPath: string
hasLock: boolean
appInstance: { _id: string } | null
initialised: boolean
hasAppPackage: boolean
usedPlugins: Plugin[] | null
automations: AutomationSettings
routes: { [key: string]: any }
version?: string
revertableVersion?: string
upgradableVersion?: string
icon?: AppIcon
}
export const INITIAL_APP_META_STATE: AppMetaState = {
appId: "",
name: "",
url: "",
@ -34,23 +81,27 @@ export const INITIAL_APP_META_STATE = {
routes: {},
}
export class AppMetaStore extends BudiStore {
export class AppMetaStore extends BudiStore<AppMetaState> {
constructor() {
super(INITIAL_APP_META_STATE)
}
reset() {
reset(): void {
this.store.set({ ...INITIAL_APP_META_STATE })
}
syncAppPackage(pkg) {
syncAppPackage(pkg: {
application: App
clientLibPath: string
hasLock: boolean
}): void {
const { application: app, clientLibPath, hasLock } = pkg
this.update(state => ({
...state,
name: app.name,
appId: app.appId,
url: app.url,
url: app.url || "",
hasLock,
clientLibPath,
libraries: app.componentLibraries,
@ -58,8 +109,8 @@ export class AppMetaStore extends BudiStore {
appInstance: app.instance,
revertableVersion: app.revertableVersion,
upgradableVersion: app.upgradableVersion,
usedPlugins: app.usedPlugins,
icon: app.icon || {},
usedPlugins: app.usedPlugins || null,
icon: app.icon,
features: {
...INITIAL_APP_META_STATE.features,
...app.features,
@ -70,7 +121,7 @@ export class AppMetaStore extends BudiStore {
}))
}
syncClientFeatures(features) {
syncClientFeatures(features: Partial<ClientFeatures>): void {
this.update(state => ({
...state,
clientFeatures: {
@ -80,14 +131,14 @@ export class AppMetaStore extends BudiStore {
}))
}
syncClientTypeSupportPresets(typeSupportPresets) {
syncClientTypeSupportPresets(typeSupportPresets: TypeSupportPresets): void {
this.update(state => ({
...state,
typeSupportPresets,
}))
}
async syncAppRoutes() {
async syncAppRoutes(): Promise<void> {
const resp = await API.fetchAppRoutes()
this.update(state => ({
...state,
@ -96,7 +147,7 @@ export class AppMetaStore extends BudiStore {
}
// Returned from socket
syncMetadata(metadata) {
syncMetadata(metadata: { name: string; url: string; icon?: AppIcon }): void {
const { name, url, icon } = metadata
this.update(state => ({
...state,

View File

@ -1,10 +1,28 @@
import { get } from "svelte/store"
import { createBuilderWebsocket } from "./websocket.js"
import { Socket } from "socket.io-client"
import { BuilderSocketEvent } from "@budibase/shared-core"
import { BudiStore } from "../BudiStore.js"
import { TOUR_KEYS } from "components/portal/onboarding/tours.js"
import { App } from "@budibase/types"
export const INITIAL_BUILDER_STATE = {
interface BuilderState {
previousTopNavPath: Record<string, string>
highlightedSetting: {
key: string
type: "info" | string
} | null
propertyFocus: string | null
builderSidePanel: boolean
onboarding: boolean
tourNodes: Record<string, HTMLElement> | null
tourKey: string | null
tourStepKey: string | null
hoveredComponentId: string | null
websocket?: Socket
}
export const INITIAL_BUILDER_STATE: BuilderState = {
previousTopNavPath: {},
highlightedSetting: null,
propertyFocus: null,
@ -16,7 +34,9 @@ export const INITIAL_BUILDER_STATE = {
hoveredComponentId: null,
}
export class BuilderStore extends BudiStore {
export class BuilderStore extends BudiStore<BuilderState> {
websocket?: Socket
constructor() {
super({ ...INITIAL_BUILDER_STATE })
@ -32,11 +52,9 @@ export class BuilderStore extends BudiStore {
this.registerTourNode = this.registerTourNode.bind(this)
this.destroyTourNode = this.destroyTourNode.bind(this)
this.startBuilderOnboarding = this.startBuilderOnboarding.bind(this)
this.websocket
}
init(app) {
init(app: App): void {
if (!app?.appId) {
console.error("BuilderStore: No appId supplied for websocket")
return
@ -46,45 +64,46 @@ export class BuilderStore extends BudiStore {
}
}
refresh() {
this.store.set(this.store.get())
refresh(): void {
const currentState = get(this.store)
this.store.set(currentState)
}
reset() {
reset(): void {
this.store.set({ ...INITIAL_BUILDER_STATE })
this.websocket?.disconnect()
this.websocket = null
this.websocket = undefined
}
highlightSetting(key, type) {
highlightSetting(key?: string, type?: string): void {
this.update(state => ({
...state,
highlightedSetting: key ? { key, type: type || "info" } : null,
}))
}
propertyFocus(key) {
propertyFocus(key: string | null): void {
this.update(state => ({
...state,
propertyFocus: key,
}))
}
showBuilderSidePanel() {
showBuilderSidePanel(): void {
this.update(state => ({
...state,
builderSidePanel: true,
}))
}
hideBuilderSidePanel() {
hideBuilderSidePanel(): void {
this.update(state => ({
...state,
builderSidePanel: false,
}))
}
setPreviousTopNavPath(route, url) {
setPreviousTopNavPath(route: string, url: string): void {
this.update(state => ({
...state,
previousTopNavPath: {
@ -94,13 +113,13 @@ export class BuilderStore extends BudiStore {
}))
}
selectResource(id) {
this.websocket.emit(BuilderSocketEvent.SelectResource, {
selectResource(id: string): void {
this.websocket?.emit(BuilderSocketEvent.SelectResource, {
resourceId: id,
})
}
registerTourNode(tourStepKey, node) {
registerTourNode(tourStepKey: string, node: HTMLElement): void {
this.update(state => {
const update = {
...state,
@ -113,7 +132,7 @@ export class BuilderStore extends BudiStore {
})
}
destroyTourNode(tourStepKey) {
destroyTourNode(tourStepKey: string): void {
const store = get(this.store)
if (store.tourNodes?.[tourStepKey]) {
const nodes = { ...store.tourNodes }
@ -125,7 +144,7 @@ export class BuilderStore extends BudiStore {
}
}
startBuilderOnboarding() {
startBuilderOnboarding(): void {
this.update(state => ({
...state,
onboarding: true,
@ -133,19 +152,19 @@ export class BuilderStore extends BudiStore {
}))
}
endBuilderOnboarding() {
endBuilderOnboarding(): void {
this.update(state => ({
...state,
onboarding: false,
}))
}
setTour(tourKey) {
setTour(tourKey?: string | null): void {
this.update(state => ({
...state,
tourStepKey: null,
tourNodes: null,
tourKey: tourKey,
tourKey: tourKey || null,
}))
}
}

View File

@ -1,28 +0,0 @@
import { writable } from "svelte/store"
export const INITIAL_CONTEXT_MENU_STATE = {
id: null,
items: [],
position: { x: 0, y: 0 },
visible: false,
}
export function createViewsStore() {
const store = writable({ ...INITIAL_CONTEXT_MENU_STATE })
const open = (id, items, position) => {
store.set({ id, items, position, visible: true })
}
const close = () => {
store.set({ ...INITIAL_CONTEXT_MENU_STATE })
}
return {
subscribe: store.subscribe,
open,
close,
}
}
export const contextMenuStore = createViewsStore()

View File

@ -0,0 +1,46 @@
import { writable } from "svelte/store"
interface Position {
x: number
y: number
}
interface MenuItem {
label: string
icon?: string
action: () => void
}
interface ContextMenuState {
id: string | null
items: MenuItem[]
position: Position
visible: boolean
}
export const INITIAL_CONTEXT_MENU_STATE: ContextMenuState = {
id: null,
items: [],
position: { x: 0, y: 0 },
visible: false,
}
export function createViewsStore() {
const store = writable<ContextMenuState>({ ...INITIAL_CONTEXT_MENU_STATE })
const open = (id: string, items: MenuItem[], position: Position): void => {
store.set({ id, items, position, visible: true })
}
const close = (): void => {
store.set({ ...INITIAL_CONTEXT_MENU_STATE })
}
return {
subscribe: store.subscribe,
open,
close,
}
}
export const contextMenuStore = createViewsStore()

View File

@ -1,11 +1,12 @@
import { writable } from "svelte/store"
import { writable, type Writable } from "svelte/store"
import { API } from "api"
import { notifications } from "@budibase/bbui"
import { DeploymentProgressResponse } from "@budibase/types"
export const createDeploymentStore = () => {
let store = writable([])
let store: Writable<DeploymentProgressResponse[]> = writable([])
const load = async () => {
const load = async (): Promise<void> => {
try {
store.set(await API.getAppDeployments())
} catch (err) {

View File

@ -65,7 +65,7 @@ describe("Builder store", () => {
ctx.test.builderStore.reset()
expect(disconnected).toBe(true)
expect(ctx.test.store).toStrictEqual(INITIAL_BUILDER_STATE)
expect(ctx.test.builderStore.websocket).toBeNull()
expect(ctx.test.builderStore.websocket).toBeUndefined()
})
it("Attempt to emit a resource select event to the websocket on select", ctx => {

View File

@ -22,6 +22,7 @@ export const createLicensingStore = () => {
backupsEnabled: false,
brandingEnabled: false,
scimEnabled: false,
environmentVariablesEnabled: false,
budibaseAIEnabled: false,
customAIConfigsEnabled: false,
auditLogsEnabled: false,

View File

@ -73,6 +73,7 @@
.value {
display: -webkit-box;
-webkit-line-clamp: var(--content-lines);
line-clamp: var(--content-lines);
-webkit-box-orient: vertical;
overflow: hidden;
line-height: 20px;

View File

@ -93,6 +93,7 @@
.value {
display: -webkit-box;
-webkit-line-clamp: var(--content-lines);
line-clamp: var(--content-lines);
-webkit-box-orient: vertical;
overflow: hidden;
line-height: 20px;

View File

@ -74,12 +74,14 @@
.value {
display: -webkit-box;
-webkit-line-clamp: var(--content-lines);
line-clamp: var(--content-lines);
-webkit-box-orient: vertical;
overflow: hidden;
line-height: 20px;
}
.number .value {
-webkit-line-clamp: 1;
line-clamp: 1;
}
input {
flex: 1 1 auto;
@ -110,5 +112,6 @@
}
input[type="number"] {
-moz-appearance: textfield;
appearance: textfield;
}
</style>

View File

@ -133,11 +133,7 @@ export const deriveStores = (context: StoreContext): DerivedDatasourceStore => {
type = ($datasource as any).value?.datasource?.type
}
// Handle calculation views
if (
type === "viewV2" &&
"type" in $definition &&
$definition?.type === ViewV2Type.CALCULATION
) {
if (type === "viewV2" && $definition?.type === ViewV2Type.CALCULATION) {
return false
}
return ["table", "viewV2", "link"].includes(type)

View File

@ -3,6 +3,11 @@ import { helpers } from "@budibase/shared-core"
import { Store as StoreContext } from "."
import { UIUser } from "@budibase/types"
interface UIEnrichedUser extends UIUser {
color: string
label: string
}
interface UsersStore {
users: Writable<UIUser[]>
}
@ -12,7 +17,8 @@ interface DerivedUsersStore {
}
interface ActionUserStore {
users: UsersStore["users"] & {
users: UsersStore["users"] &
Readable<UIEnrichedUser[]> & {
actions: {
updateUser: (user: UIUser) => void
removeUser: (sessionId: string) => void
@ -20,13 +26,13 @@ interface ActionUserStore {
}
}
export type Store = UsersStore & DerivedUsersStore
export type Store = DerivedUsersStore & ActionUserStore
export const createStores = (): UsersStore => {
const users = writable<UIUser[]>([])
const enrichedUsers = derived(users, $users => {
return $users.map(user => ({
return $users.map<UIEnrichedUser>(user => ({
...user,
color: helpers.getUserColor(user),
label: helpers.getUserLabel(user),

View File

@ -456,7 +456,7 @@ export function filterAutomation(appId: string, tableId?: string): Automation {
icon: "Icon",
id: "a",
type: AutomationStepType.TRIGGER,
event: "row:save",
event: AutomationEventType.ROW_SAVE,
stepId: AutomationTriggerStepId.ROW_SAVED,
inputs: {
tableId: tableId!,
@ -498,7 +498,7 @@ export function updateRowAutomationWithFilters(
icon: "Icon",
id: "a",
type: AutomationStepType.TRIGGER,
event: "row:update",
event: AutomationEventType.ROW_UPDATE,
stepId: AutomationTriggerStepId.ROW_UPDATED,
inputs: { tableId },
schema: TRIGGER_DEFINITIONS.ROW_UPDATED.schema,
@ -513,7 +513,7 @@ export function basicAutomationResults(
return {
automationId,
status: AutomationStatus.SUCCESS,
trigger: "trigger",
trigger: "trigger" as any,
steps: [
{
stepId: AutomationActionStepId.SERVER_LOG,

View File

@ -148,6 +148,7 @@ export interface Automation extends Document {
interface BaseIOStructure {
type?: AutomationIOType
subtype?: AutomationIOType
customType?: AutomationCustomIOType
title?: string
description?: string
@ -192,7 +193,7 @@ export enum AutomationStoppedReason {
export interface AutomationResults {
automationId?: string
status?: AutomationStatus
trigger?: any
trigger?: AutomationTrigger
steps: {
stepId: AutomationTriggerStepId | AutomationActionStepId
inputs: {

View File

@ -6,6 +6,7 @@ import {
AutomationFeature,
InputOutputBlock,
AutomationTriggerStepId,
AutomationEventType,
} from "./automation"
import {
CollectStepInputs,
@ -142,6 +143,7 @@ export type ActionImplementations<T extends Hosting> = {
export interface AutomationStepSchemaBase {
name: string
stepTitle?: string
event?: AutomationEventType
tagline: string
icon: string
description: string
@ -344,7 +346,7 @@ export interface AutomationTriggerSchema<
> extends AutomationStepSchemaBase {
id: string
type: AutomationStepType.TRIGGER
event?: string
event?: AutomationEventType
cronJobId?: string
stepId: TTrigger
inputs: AutomationTriggerInputs<TTrigger> & Record<string, any> // The record union to be removed once the types are fixed

View File

@ -0,0 +1,12 @@
export interface BranchPath {
stepIdx: number
branchIdx: number
branchStepId: string
id: string
}
export interface BlockDefinitions {
TRIGGER: Record<string, any>
CREATABLE_TRIGGER: Record<string, any>
ACTION: Record<string, any>
}

View File

@ -1,2 +1,3 @@
export * from "./integration"
export * from "./automations"
export * from "./grid"

View File

@ -5946,6 +5946,11 @@
dependencies:
"@types/node" "*"
"@types/shortid@^2.2.0":
version "2.2.0"
resolved "https://registry.yarnpkg.com/@types/shortid/-/shortid-2.2.0.tgz#905990fc4275f77e60ab0cd9f791b91a3d4bff04"
integrity sha512-jBG2FgBxcaSf0h662YloTGA32M8UtNbnTPekUr/eCmWXq0JWQXgNEQ/P5Gf05Cv66QZtE1Ttr83I1AJBPdzCBg==
"@types/ssh2-streams@*":
version "0.1.12"
resolved "https://registry.yarnpkg.com/@types/ssh2-streams/-/ssh2-streams-0.1.12.tgz#e68795ba2bf01c76b93f9c9809e1f42f0eaaec5f"
@ -18639,16 +18644,7 @@ string-length@^4.0.1:
char-regex "^1.0.2"
strip-ansi "^6.0.0"
"string-width-cjs@npm:string-width@^4.2.0":
version "4.2.3"
resolved "https://registry.yarnpkg.com/string-width/-/string-width-4.2.3.tgz#269c7117d27b05ad2e536830a8ec895ef9c6d010"
integrity sha512-wKyQRQpjJ0sIp62ErSZdGsjMJWsap5oRNihHhu6G7JVO/9jIB6UyevL+tXuOqrng8j/cxKTWyWUwvSTriiZz/g==
dependencies:
emoji-regex "^8.0.0"
is-fullwidth-code-point "^3.0.0"
strip-ansi "^6.0.1"
"string-width@^1.0.2 || 2 || 3 || 4", string-width@^4.0.0, string-width@^4.1.0, string-width@^4.2.0, string-width@^4.2.2, string-width@^4.2.3:
"string-width-cjs@npm:string-width@^4.2.0", "string-width@^1.0.2 || 2 || 3 || 4", string-width@^4.0.0, string-width@^4.1.0, string-width@^4.2.0, string-width@^4.2.2, string-width@^4.2.3:
version "4.2.3"
resolved "https://registry.yarnpkg.com/string-width/-/string-width-4.2.3.tgz#269c7117d27b05ad2e536830a8ec895ef9c6d010"
integrity sha512-wKyQRQpjJ0sIp62ErSZdGsjMJWsap5oRNihHhu6G7JVO/9jIB6UyevL+tXuOqrng8j/cxKTWyWUwvSTriiZz/g==
@ -18740,7 +18736,7 @@ stringify-object@^3.2.1:
is-obj "^1.0.1"
is-regexp "^1.0.0"
"strip-ansi-cjs@npm:strip-ansi@^6.0.1":
"strip-ansi-cjs@npm:strip-ansi@^6.0.1", strip-ansi@^6.0.0, strip-ansi@^6.0.1:
version "6.0.1"
resolved "https://registry.yarnpkg.com/strip-ansi/-/strip-ansi-6.0.1.tgz#9e26c63d30f53443e9489495b2105d37b67a85d9"
integrity sha512-Y38VPSHcqkFrCpFnQ9vuSXmquuv5oXOKpGeT6aGrr3o3Gc9AlVa6JBfUSOCnbxGGZF+/0ooI7KrPuUSztUdU5A==
@ -18754,13 +18750,6 @@ strip-ansi@^5.0.0, strip-ansi@^5.1.0, strip-ansi@^5.2.0:
dependencies:
ansi-regex "^4.1.0"
strip-ansi@^6.0.0, strip-ansi@^6.0.1:
version "6.0.1"
resolved "https://registry.yarnpkg.com/strip-ansi/-/strip-ansi-6.0.1.tgz#9e26c63d30f53443e9489495b2105d37b67a85d9"
integrity sha512-Y38VPSHcqkFrCpFnQ9vuSXmquuv5oXOKpGeT6aGrr3o3Gc9AlVa6JBfUSOCnbxGGZF+/0ooI7KrPuUSztUdU5A==
dependencies:
ansi-regex "^5.0.1"
strip-ansi@^7.0.1:
version "7.0.1"
resolved "https://registry.yarnpkg.com/strip-ansi/-/strip-ansi-7.0.1.tgz#61740a08ce36b61e50e65653f07060d000975fb2"
@ -20508,7 +20497,7 @@ worker-farm@1.7.0:
dependencies:
errno "~0.1.7"
"wrap-ansi-cjs@npm:wrap-ansi@^7.0.0":
"wrap-ansi-cjs@npm:wrap-ansi@^7.0.0", wrap-ansi@^7.0.0:
version "7.0.0"
resolved "https://registry.yarnpkg.com/wrap-ansi/-/wrap-ansi-7.0.0.tgz#67e145cff510a6a6984bdf1152911d69d2eb9e43"
integrity sha512-YVGIj2kamLSTxw6NsZjoBxfSwsn0ycdesmc4p+Q21c5zPuZ1pl+NfxVdxPtdHvmNVOQ6XSYG4AUtyt/Fi7D16Q==
@ -20526,15 +20515,6 @@ wrap-ansi@^5.1.0:
string-width "^3.0.0"
strip-ansi "^5.0.0"
wrap-ansi@^7.0.0:
version "7.0.0"
resolved "https://registry.yarnpkg.com/wrap-ansi/-/wrap-ansi-7.0.0.tgz#67e145cff510a6a6984bdf1152911d69d2eb9e43"
integrity sha512-YVGIj2kamLSTxw6NsZjoBxfSwsn0ycdesmc4p+Q21c5zPuZ1pl+NfxVdxPtdHvmNVOQ6XSYG4AUtyt/Fi7D16Q==
dependencies:
ansi-styles "^4.0.0"
string-width "^4.1.0"
strip-ansi "^6.0.0"
wrap-ansi@^8.1.0:
version "8.1.0"
resolved "https://registry.yarnpkg.com/wrap-ansi/-/wrap-ansi-8.1.0.tgz#56dc22368ee570face1b49819975d9b9a5ead214"