From 80d91cdd927426efa22e6268c8eaa49a2d84d77d Mon Sep 17 00:00:00 2001 From: melohagan <101575380+melohagan@users.noreply.github.com> Date: Thu, 28 Sep 2023 16:09:13 +0100 Subject: [PATCH 01/10] Make sure field state is valid (#11921) --- .../src/components/app/forms/RelationshipField.svelte | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/packages/client/src/components/app/forms/RelationshipField.svelte b/packages/client/src/components/app/forms/RelationshipField.svelte index 768f784d49..bfa7c6cbd2 100644 --- a/packages/client/src/components/app/forms/RelationshipField.svelte +++ b/packages/client/src/components/app/forms/RelationshipField.svelte @@ -121,7 +121,12 @@ if (!Array.isArray(values)) { values = [values] } - return values.map(value => (typeof value === "object" ? value._id : value)) + values = values.map(value => + typeof value === "object" ? value._id : value + ) + // Make sure field state is valid + fieldApi.setValue(values) + return values } const getDisplayName = row => { From ee363763cb4ed5d98af8d996df0ee7d931ef9635 Mon Sep 17 00:00:00 2001 From: Budibase Staging Release Bot <> Date: Thu, 28 Sep 2023 15:09:32 +0000 Subject: [PATCH 02/10] Bump version to 2.10.16-alpha.10 --- lerna.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lerna.json b/lerna.json index abbec8dc5d..d45ad3fe23 100644 --- a/lerna.json +++ b/lerna.json @@ -1,5 +1,5 @@ { - "version": "2.10.16-alpha.9", + "version": "2.10.16-alpha.10", "npmClient": "yarn", "packages": [ "packages/*" From d37239601825dcf593d2bf3b7b5bc809cde27d3a Mon Sep 17 00:00:00 2001 From: Martin McKeaveney Date: Thu, 28 Sep 2023 16:41:22 +0100 Subject: [PATCH 03/10] Update README.md --- packages/builder/README.md | 2 -- 1 file changed, 2 deletions(-) diff --git a/packages/builder/README.md b/packages/builder/README.md index 101d483185..c1dd8b7871 100644 --- a/packages/builder/README.md +++ b/packages/builder/README.md @@ -1,5 +1,3 @@ -test - ## Get Started `yarn install` From 2868cd9b2b9e9edc3c4632751e2001a14aba9416 Mon Sep 17 00:00:00 2001 From: Budibase Staging Release Bot <> Date: Thu, 28 Sep 2023 15:41:42 +0000 Subject: [PATCH 04/10] Bump version to 2.10.16-alpha.11 --- lerna.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lerna.json b/lerna.json index d45ad3fe23..d99355a157 100644 --- a/lerna.json +++ b/lerna.json @@ -1,5 +1,5 @@ { - "version": "2.10.16-alpha.10", + "version": "2.10.16-alpha.11", "npmClient": "yarn", "packages": [ "packages/*" From b4e0d98973c6395e36040f7789fb2f7995781f10 Mon Sep 17 00:00:00 2001 From: melohagan <101575380+melohagan@users.noreply.github.com> Date: Fri, 29 Sep 2023 10:15:36 +0100 Subject: [PATCH 05/10] Add bindings support to meeting start / end dates (#11759) * Deprecate zapier+make values1..5 * Allow dates in meeting invite to be bindable * Add DrawerBindableSlot component * Show calendar icon * refactor * Use cancel icon * Disable cancel for JS bindings * WIP * WIP * WIP * Fix linkedIds svelte binding * Label and icon update * Handle arrays * Support text area * Add reactivity to text area icon * Support boolean * JSON support * Remove rowControl * Allow boolean field to have three states * lint * Refactor --------- Co-authored-by: Michael Drury --- .../builderStore/store/automation/index.js | 12 - .../FlowChart/FlowItem.svelte | 23 -- .../SetupPanel/AutomationBlockSetup.svelte | 84 ++---- .../automation/SetupPanel/RowSelector.svelte | 82 ++---- .../SetupPanel/RowSelectorTypes.svelte | 149 ++++++----- .../common/LinkedRowSelector.svelte | 6 +- .../common/bindings/DrawerBindableSlot.svelte | 250 ++++++++++++++++++ packages/server/src/automations/steps/make.ts | 8 +- .../server/src/automations/steps/zapier.ts | 8 +- 9 files changed, 376 insertions(+), 246 deletions(-) create mode 100644 packages/builder/src/components/common/bindings/DrawerBindableSlot.svelte diff --git a/packages/builder/src/builderStore/store/automation/index.js b/packages/builder/src/builderStore/store/automation/index.js index 4ebf0515d6..c22240370b 100644 --- a/packages/builder/src/builderStore/store/automation/index.js +++ b/packages/builder/src/builderStore/store/automation/index.js @@ -221,18 +221,6 @@ const automationActions = store => ({ newAutomation.definition.steps.splice(blockIdx, 0, block) await store.actions.save(newAutomation) }, - /** - * "rowControl" appears to be the name of the flag used to determine whether - * a certain automation block uses values or bindings as inputs - */ - toggleRowControl: async (block, rowControl) => { - const newBlock = { ...block, rowControl } - const newAutomation = store.actions.getUpdatedDefinition( - get(selectedAutomation), - newBlock - ) - await store.actions.save(newAutomation) - }, deleteAutomationBlock: async block => { const automation = get(selectedAutomation) let newAutomation = cloneDeep(automation) diff --git a/packages/builder/src/components/automation/AutomationBuilder/FlowChart/FlowItem.svelte b/packages/builder/src/components/automation/AutomationBuilder/FlowChart/FlowItem.svelte index 85c3776fdb..6c964c84a9 100644 --- a/packages/builder/src/components/automation/AutomationBuilder/FlowChart/FlowItem.svelte +++ b/packages/builder/src/components/automation/AutomationBuilder/FlowChart/FlowItem.svelte @@ -7,7 +7,6 @@ Detail, Modal, Button, - Select, ActionButton, notifications, Label, @@ -39,9 +38,6 @@ step => step.stepId === ActionStepID.COLLECT ) $: automationId = $selectedAutomation?._id - $: showBindingPicker = - block.stepId === ActionStepID.CREATE_ROW || - block.stepId === ActionStepID.UPDATE_ROW $: isTrigger = block.type === "TRIGGER" $: steps = $selectedAutomation?.definition?.steps ?? [] $: blockIdx = steps.findIndex(step => step.id === block.id) @@ -96,15 +92,6 @@ } } - /** - * "rowControl" appears to be the name of the flag used to determine whether - * a certain automation block uses values or bindings as inputs - */ - function toggleRowControl(evt) { - const rowControl = evt.detail !== "Use values" - automationStore.actions.toggleRowControl(block, rowControl) - } - async function addLooping() { const loopDefinition = $automationStore.blockDefinitions.ACTION.LOOP const loopBlock = automationStore.actions.constructBlock( @@ -189,16 +176,6 @@ Add Looping {/if} - {#if showBindingPicker} - onChange(e, key)} @@ -469,7 +420,6 @@ /> {:else if value.customType === "row"} { diff --git a/packages/builder/src/components/automation/SetupPanel/RowSelector.svelte b/packages/builder/src/components/automation/SetupPanel/RowSelector.svelte index 5039c37ece..8c50689f22 100644 --- a/packages/builder/src/components/automation/SetupPanel/RowSelector.svelte +++ b/packages/builder/src/components/automation/SetupPanel/RowSelector.svelte @@ -1,18 +1,14 @@ -{#if schemaHasOptions(schema) && schema.type !== "array"} -