From 3e1e865bb4a2abca3d2eb8367c620615da0ecc38 Mon Sep 17 00:00:00 2001
From: Michael Shanks <mike@budibase.com>
Date: Fri, 2 Oct 2020 14:14:58 +0100
Subject: [PATCH] record value coersion  - untested

---
 packages/server/src/api/controllers/record.js | 53 +++++++++++++++++++
 1 file changed, 53 insertions(+)

diff --git a/packages/server/src/api/controllers/record.js b/packages/server/src/api/controllers/record.js
index 2626667ef3..508a2210b6 100644
--- a/packages/server/src/api/controllers/record.js
+++ b/packages/server/src/api/controllers/record.js
@@ -33,6 +33,8 @@ exports.patch = async function(ctx) {
   const model = await db.get(record.modelId)
   const patchfields = ctx.request.body
 
+  coersceRecordValues(record, model)
+
   for (let key in patchfields) {
     if (!model.schema[key]) continue
     record[key] = patchfields[key]
@@ -71,6 +73,8 @@ exports.save = async function(ctx) {
 
   const model = await db.get(record.modelId)
 
+  coersceRecordValues(record, model)
+
   const validateResult = await validate({
     record,
     model,
@@ -218,3 +222,52 @@ async function validate({ instanceId, modelId, record, model }) {
   }
   return { valid: Object.keys(errors).length === 0, errors }
 }
+
+function coersceRecordValues(record, model) {
+  for (let [key, value] of Object.entries(record)) {
+    const field = model.schema[key]
+    if (!field) continue
+    const mapping = Object.prototype.hasOwnProperty.call(
+      TYPE_TRANSFORM_MAP,
+      value
+    )
+      ? TYPE_TRANSFORM_MAP[field.type][value]
+      : TYPE_TRANSFORM_MAP[field.type].parse
+
+    record[key] = typeof mapping === "function" ? mapping(value) : mapping
+  }
+}
+
+const TYPE_TRANSFORM_MAP = {
+  string: {
+    "": "",
+    [null]: "",
+    [undefined]: undefined,
+    parse: s => s.toString(),
+  },
+  number: {
+    "": null,
+    [undefined]: undefined,
+    parse: n => parseFloat(n),
+  },
+  datetime: {
+    "": null,
+    [undefined]: undefined,
+    [null]: null,
+    parse: d => new Date(d).getTime(),
+  },
+  attachments: {
+    [null]: [],
+    [undefined]: undefined,
+    parse: a => a,
+  },
+  boolean: {
+    [null]: null,
+    [undefined]: undefined,
+    parse: b => {
+      if (b === "false") return false
+      if (b === "true") return true
+      return b
+    },
+  },
+}