From 6b9854770988c722f4c3eeb44fdf9eef21b24270 Mon Sep 17 00:00:00 2001
From: NEOLPAR <ricardo@neolpar.com>
Date: Thu, 14 Jul 2022 15:36:35 +0100
Subject: [PATCH 1/3] amended icons

---
 .../portal/manage/groups/_components/UserGroupsRow.svelte      | 3 +--
 .../manage/users/_components/SettingsTableRenderer.svelte      | 2 +-
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/packages/builder/src/pages/builder/portal/manage/groups/_components/UserGroupsRow.svelte b/packages/builder/src/pages/builder/portal/manage/groups/_components/UserGroupsRow.svelte
index 478608f2d4..e00123614a 100644
--- a/packages/builder/src/pages/builder/portal/manage/groups/_components/UserGroupsRow.svelte
+++ b/packages/builder/src/pages/builder/portal/manage/groups/_components/UserGroupsRow.svelte
@@ -65,8 +65,7 @@
         <MenuItem on:click={() => deleteGroup(group)} icon="Delete"
           >Delete</MenuItem
         >
-        <MenuItem on:click={() => editGroup(group)} icon="Delete">Edit</MenuItem
-        >
+        <MenuItem on:click={() => editGroup(group)} icon="Edit">Edit</MenuItem>
       </ActionMenu>
     </div>
   </div>
diff --git a/packages/builder/src/pages/builder/portal/manage/users/_components/SettingsTableRenderer.svelte b/packages/builder/src/pages/builder/portal/manage/users/_components/SettingsTableRenderer.svelte
index 37ce58a0b7..e32072d5e1 100644
--- a/packages/builder/src/pages/builder/portal/manage/users/_components/SettingsTableRenderer.svelte
+++ b/packages/builder/src/pages/builder/portal/manage/users/_components/SettingsTableRenderer.svelte
@@ -11,6 +11,6 @@
       <Icon hoverable name="More" />
     </span>
     <MenuItem icon="Delete">Delete</MenuItem>
-    <MenuItem icon="Delete">Edit</MenuItem>
+    <MenuItem icon="Edit">Edit</MenuItem>
   </ActionMenu>
 </div>

From 0fc78fdbf65b162d621c52325d564fc4ffa2b7e7 Mon Sep 17 00:00:00 2001
From: NEOLPAR <ricardo@neolpar.com>
Date: Thu, 14 Jul 2022 15:59:06 +0100
Subject: [PATCH 2/3] removed duplicated behaviour in user table

---
 .../_components/SettingsTableRenderer.svelte     | 16 ----------------
 .../builder/portal/manage/users/index.svelte     |  2 --
 2 files changed, 18 deletions(-)
 delete mode 100644 packages/builder/src/pages/builder/portal/manage/users/_components/SettingsTableRenderer.svelte

diff --git a/packages/builder/src/pages/builder/portal/manage/users/_components/SettingsTableRenderer.svelte b/packages/builder/src/pages/builder/portal/manage/users/_components/SettingsTableRenderer.svelte
deleted file mode 100644
index e32072d5e1..0000000000
--- a/packages/builder/src/pages/builder/portal/manage/users/_components/SettingsTableRenderer.svelte
+++ /dev/null
@@ -1,16 +0,0 @@
-<script>
-  import { Icon, ActionMenu, MenuItem } from "@budibase/bbui"
-</script>
-
-<div
-  style="    overflow: hidden;
-"
->
-  <ActionMenu align="right">
-    <span slot="control">
-      <Icon hoverable name="More" />
-    </span>
-    <MenuItem icon="Delete">Delete</MenuItem>
-    <MenuItem icon="Edit">Edit</MenuItem>
-  </ActionMenu>
-</div>
diff --git a/packages/builder/src/pages/builder/portal/manage/users/index.svelte b/packages/builder/src/pages/builder/portal/manage/users/index.svelte
index 0a765c44e9..938f92850b 100644
--- a/packages/builder/src/pages/builder/portal/manage/users/index.svelte
+++ b/packages/builder/src/pages/builder/portal/manage/users/index.svelte
@@ -21,7 +21,6 @@
   import GroupsTableRenderer from "./_components/GroupsTableRenderer.svelte"
   import AppsTableRenderer from "./_components/AppsTableRenderer.svelte"
   import NameTableRenderer from "./_components/NameTableRenderer.svelte"
-  import SettingsTableRenderer from "./_components/SettingsTableRenderer.svelte"
   import RoleTableRenderer from "./_components/RoleTableRenderer.svelte"
   import { goto } from "@roxi/routify"
   import OnboardingTypeModal from "./_components/OnboardingTypeModal.svelte"
@@ -62,7 +61,6 @@
     { column: "userGroups", component: GroupsTableRenderer },
     { column: "apps", component: AppsTableRenderer },
     { column: "name", component: NameTableRenderer },
-    { column: "settings", component: SettingsTableRenderer },
     { column: "role", component: RoleTableRenderer },
   ]
 

From c8512e3de6f72e90544e4cd0f93e2c9f2909b170 Mon Sep 17 00:00:00 2001
From: NEOLPAR <ricardo@neolpar.com>
Date: Thu, 14 Jul 2022 16:55:19 +0100
Subject: [PATCH 3/3] changing user roles from users table

---
 .../_components/RoleTableRenderer.svelte      | 36 +++++++++++++++----
 packages/builder/src/stores/portal/users.js   |  4 +++
 2 files changed, 33 insertions(+), 7 deletions(-)

diff --git a/packages/builder/src/pages/builder/portal/manage/users/_components/RoleTableRenderer.svelte b/packages/builder/src/pages/builder/portal/manage/users/_components/RoleTableRenderer.svelte
index 66f133663f..1bc820be72 100644
--- a/packages/builder/src/pages/builder/portal/manage/users/_components/RoleTableRenderer.svelte
+++ b/packages/builder/src/pages/builder/portal/manage/users/_components/RoleTableRenderer.svelte
@@ -1,15 +1,37 @@
 <script>
-  import { Select } from "@budibase/bbui"
+  import { notifications, Select } from "@budibase/bbui"
+  import { users } from "stores/portal"
+  import { Constants } from "@budibase/frontend-core"
 
-  const options = [
-    { label: "App User", value: "appUser" },
-    { label: "Developer", value: "developer" },
-    { label: "Admin", value: "admin" },
-  ]
+  export let row
+  $: value = users.getUserRole(row)
+
+  async function updateUserRole({ detail }) {
+    if (detail === "developer") {
+      toggleFlags({ admin: { global: false }, builder: { global: true } })
+    } else if (detail === "admin") {
+      toggleFlags({ admin: { global: true }, builder: { global: false } })
+    } else if (detail === "appUser") {
+      toggleFlags({ admin: { global: false }, builder: { global: false } })
+    }
+  }
+  async function toggleFlags(roleFlags) {
+    try {
+      await users.save({ ...(await users.get(row._id)), ...roleFlags })
+    } catch (error) {
+      notifications.error("Error updating user")
+    }
+  }
 </script>
 
 <div on:click|stopPropagation>
-  <Select value={"appUser"} {options} placeholder="Admin" autoWidth quiet />
+  <Select
+    {value}
+    options={Constants.BbRoles}
+    autoWidth
+    quiet
+    on:change={updateUserRole}
+  />
 </div>
 
 <style>
diff --git a/packages/builder/src/stores/portal/users.js b/packages/builder/src/stores/portal/users.js
index 228bc05fe7..cb499dd9fd 100644
--- a/packages/builder/src/stores/portal/users.js
+++ b/packages/builder/src/stores/portal/users.js
@@ -86,10 +86,14 @@ export function createUsersStore() {
     return await API.saveUser(user)
   }
 
+  const getUserRole = ({ admin, builder }) =>
+    admin?.global ? "admin" : builder?.global ? "developer" : "appUser"
+
   return {
     subscribe,
     search,
     get,
+    getUserRole,
     fetch,
     invite,
     acceptInvite,