Merge pull request #3621 from Budibase/merge-master

Merge master -> develop
2021-12-01 14:20:49 +00:00 · 2021-12-01 14:20:49 +00:00 · 3ffd0cbb63
parent 820bb44b18 17ccb2fc23
commit 3ffd0cbb63
13 changed files with 106 additions and 41 deletions
--- a/lerna.json
+++ b/lerna.json
@ -1,5 +1,5 @@
 {
-  "version": "1.0.3-alpha.0",
+  "version": "1.0.4",
  "npmClient": "yarn",
  "packages": [
    "packages/*"
--- a/packages/auth/package.json
+++ b/packages/auth/package.json
@ -1,6 +1,6 @@
 {
  "name": "@budibase/auth",
-  "version": "1.0.3-alpha.0",
+  "version": "1.0.4",
  "description": "Authentication middlewares for budibase builder and apps",
  "main": "src/index.js",
  "author": "Budibase",
--- a/packages/bbui/package.json
+++ b/packages/bbui/package.json
@ -1,7 +1,7 @@
 {
  "name": "@budibase/bbui",
  "description": "A UI solution used in the different Budibase projects.",
-  "version": "1.0.3-alpha.0",
+  "version": "1.0.4",
  "license": "MPL-2.0",
  "svelte": "src/index.js",
  "module": "dist/bbui.es.js",
--- a/packages/builder/package.json
+++ b/packages/builder/package.json
@ -1,6 +1,6 @@
 {
  "name": "@budibase/builder",
-  "version": "1.0.3-alpha.0",
+  "version": "1.0.4",
  "license": "GPL-3.0",
  "private": true,
  "scripts": {
@ -65,10 +65,10 @@
    }
  },
  "dependencies": {
-    "@budibase/bbui": "^1.0.3-alpha.0",
-    "@budibase/client": "^1.0.3-alpha.0",
+    "@budibase/bbui": "^1.0.4",
+    "@budibase/client": "^1.0.4",
    "@budibase/colorpicker": "1.1.2",
-    "@budibase/string-templates": "^1.0.3-alpha.0",
+    "@budibase/string-templates": "^1.0.4",
    "@sentry/browser": "5.19.1",
    "@spectrum-css/page": "^3.0.1",
    "@spectrum-css/vars": "^3.0.1",
--- a/packages/builder/src/builderStore/dataBinding.js
+++ b/packages/builder/src/builderStore/dataBinding.js
@ -61,7 +61,7 @@ export const getComponentBindableProperties = (asset, componentId) => {
 /**
 * Gets all data provider components above a component.
 */
-export const getDataProviderComponents = (asset, componentId) => {
+export const getContextProviderComponents = (asset, componentId, type) => {
  if (!asset || !componentId) {
    return []
  }
@ -74,7 +74,18 @@ export const getDataProviderComponents = (asset, componentId) => {
  // Filter by only data provider components
  return path.filter(component => {
    const def = store.actions.components.getDefinition(component._component)
-    return def?.context != null
+    if (!def?.context) {
+      return false
+    }
+
+    // If no type specified, return anything that exposes context
+    if (!type) {
+      return true
+    }
+
+    // Otherwise only match components with the specific context type
+    const contexts = Array.isArray(def.context) ? def.context : [def.context]
+    return contexts.find(context => context.type === type) != null
  })
 }

@ -143,7 +154,7 @@ export const getDatasourceForProvider = (asset, component) => {
 */
 const getContextBindings = (asset, componentId) => {
  // Extract any components which provide data contexts
-  const dataProviders = getDataProviderComponents(asset, componentId)
+  const dataProviders = getContextProviderComponents(asset, componentId)

  // Generate bindings for all matching components
  return getProviderContextBindings(asset, dataProviders)
--- a/packages/builder/src/components/design/PropertiesPanel/PropertyControls/DataSourceSelect.svelte
+++ b/packages/builder/src/components/design/PropertiesPanel/PropertyControls/DataSourceSelect.svelte
@ -1,5 +1,5 @@
 <script>
-  import { getDataProviderComponents } from "builderStore/dataBinding"
+  import { getContextProviderComponents } from "builderStore/dataBinding"
  import {
    Button,
    Popover,
@ -58,16 +58,19 @@
      ...query,
      type: "query",
    }))
-  $: dataProviders = getDataProviderComponents(
+  $: contextProviders = getContextProviderComponents(
    $currentAsset,
    $store.selectedComponentId
-  ).map(provider => ({
-    label: provider._instanceName,
-    name: provider._instanceName,
-    providerId: provider._id,
-    value: `{{ literal ${safe(provider._id)} }}`,
-    type: "provider",
-  }))
+  )
+  $: dataProviders = contextProviders
+    .filter(component => component._component?.endsWith("/dataprovider"))
+    .map(provider => ({
+      label: provider._instanceName,
+      name: provider._instanceName,
+      providerId: provider._id,
+      value: `{{ literal ${safe(provider._id)} }}`,
+      type: "provider",
+    }))
  $: links = bindings
    .filter(x => x.fieldSchema?.type === "link")
    .map(binding => {
--- a/packages/builder/src/components/design/PropertiesPanel/PropertyControls/EventsEditor/EventPropertyControl.svelte
+++ b/packages/builder/src/components/design/PropertiesPanel/PropertyControls/EventsEditor/EventPropertyControl.svelte
@ -4,6 +4,7 @@
  import { notifications } from "@budibase/bbui"
  import EventEditor from "./EventEditor.svelte"
  import { automationStore } from "builderStore"
+  import { cloneDeep } from "lodash/fp"

  const dispatch = createEventDispatcher()

@ -12,17 +13,23 @@
  export let bindings

  let drawer
+  let tmpValue
+
+  const openDrawer = () => {
+    tmpValue = cloneDeep(value)
+    drawer.show()
+  }

  const saveEventData = async () => {
    // any automations that need created from event triggers
-    const automationsToCreate = value.filter(
+    const automationsToCreate = tmpValue.filter(
      action => action["##eventHandlerType"] === "Trigger Automation"
    )
    for (let action of automationsToCreate) {
      await createAutomation(action.parameters)
    }

-    dispatch("change", value)
+    dispatch("change", tmpValue)
    notifications.success("Component actions saved.")
    drawer.hide()
  }
@ -54,11 +61,16 @@
  }
 </script>

-<ActionButton on:click={drawer.show}>Define actions</ActionButton>
+<ActionButton on:click={openDrawer}>Define actions</ActionButton>
 <Drawer bind:this={drawer} title={"Actions"}>
  <svelte:fragment slot="description">
    Define what actions to run.
  </svelte:fragment>
  <Button cta slot="buttons" on:click={saveEventData}>Save</Button>
-  <EventEditor slot="body" bind:actions={value} eventType={name} {bindings} />
+  <EventEditor
+    slot="body"
+    bind:actions={tmpValue}
+    eventType={name}
+    {bindings}
+  />
 </Drawer>
--- a/packages/builder/src/components/design/PropertiesPanel/PropertyControls/EventsEditor/actions/SaveRow.svelte
+++ b/packages/builder/src/components/design/PropertiesPanel/PropertyControls/EventsEditor/actions/SaveRow.svelte
@ -3,7 +3,7 @@
  import { store, currentAsset } from "builderStore"
  import { tables } from "stores/backend"
  import {
-    getDataProviderComponents,
+    getContextProviderComponents,
    getSchemaForDatasource,
  } from "builderStore/dataBinding"
  import SaveFields from "./SaveFields.svelte"
@ -11,13 +11,54 @@
  export let parameters
  export let bindings = []

-  $: dataProviderComponents = getDataProviderComponents(
+  $: formComponents = getContextProviderComponents(
    $currentAsset,
-    $store.selectedComponentId
+    $store.selectedComponentId,
+    "form"
  )
+  $: schemaComponents = getContextProviderComponents(
+    $currentAsset,
+    $store.selectedComponentId,
+    "schema"
+  )
+  $: providerOptions = getProviderOptions(formComponents, schemaComponents)
  $: schemaFields = getSchemaFields($currentAsset, parameters?.tableId)
  $: tableOptions = $tables.list || []

+  // Gets a context definition of a certain type from a component definition
+  const extractComponentContext = (component, contextType) => {
+    const def = store.actions.components.getDefinition(component?._component)
+    if (!def) {
+      return null
+    }
+    const contexts = Array.isArray(def.context) ? def.context : [def.context]
+    return contexts.find(context => context?.type === contextType)
+  }
+
+  // Gets options for valid context keys which provide valid data to submit
+  const getProviderOptions = (formComponents, schemaComponents) => {
+    const formContexts = formComponents.map(component => ({
+      component,
+      context: extractComponentContext(component, "form"),
+    }))
+    const schemaContexts = schemaComponents.map(component => ({
+      component,
+      context: extractComponentContext(component, "schema"),
+    }))
+    const allContexts = formContexts.concat(schemaContexts)
+
+    return allContexts.map(({ component, context }) => {
+      let runtimeBinding = component._id
+      if (context.suffix) {
+        runtimeBinding += `-${context.suffix}`
+      }
+      return {
+        label: component._instanceName,
+        value: runtimeBinding,
+      }
+    })
+  }
+
  const getSchemaFields = (asset, tableId) => {
    const { schema } = getSchemaForDatasource(asset, { type: "table", tableId })
    return Object.values(schema || {})
@ -39,10 +80,8 @@
    <Label small>Data Source</Label>
    <Select
      bind:value={parameters.providerId}
-      options={dataProviderComponents}
+      options={providerOptions}
      placeholder="None"
-      getOptionLabel={option => option._instanceName}
-      getOptionValue={option => option._id}
    />

    <Label small>Table</Label>
--- a/packages/cli/package.json
+++ b/packages/cli/package.json
@ -1,6 +1,6 @@
 {
  "name": "@budibase/cli",
-  "version": "1.0.3-alpha.0",
+  "version": "1.0.4",
  "description": "Budibase CLI, for developers, self hosting and migrations.",
  "main": "src/index.js",
  "bin": {
--- a/packages/client/package.json
+++ b/packages/client/package.json
@ -1,6 +1,6 @@
 {
  "name": "@budibase/client",
-  "version": "1.0.3-alpha.0",
+  "version": "1.0.4",
  "license": "MPL-2.0",
  "module": "dist/budibase-client.js",
  "main": "dist/budibase-client.js",
@ -19,9 +19,9 @@
    "dev:builder": "rollup -cw"
  },
  "dependencies": {
-    "@budibase/bbui": "^1.0.3-alpha.0",
+    "@budibase/bbui": "^1.0.4",
    "@budibase/standard-components": "^0.9.139",
-    "@budibase/string-templates": "^1.0.3-alpha.0",
+    "@budibase/string-templates": "^1.0.4",
    "regexparam": "^1.3.0",
    "shortid": "^2.2.15",
    "svelte-spa-router": "^3.0.5"
--- a/packages/server/package.json
+++ b/packages/server/package.json
@ -1,7 +1,7 @@
 {
  "name": "@budibase/server",
  "email": "hi@budibase.com",
-  "version": "1.0.3-alpha.0",
+  "version": "1.0.4",
  "description": "Budibase Web Server",
  "main": "src/index.ts",
  "repository": {
@ -69,9 +69,9 @@
  "author": "Budibase",
  "license": "GPL-3.0",
  "dependencies": {
-    "@budibase/auth": "^1.0.3-alpha.0",
-    "@budibase/client": "^1.0.3-alpha.0",
-    "@budibase/string-templates": "^1.0.3-alpha.0",
+    "@budibase/auth": "^1.0.4",
+    "@budibase/client": "^1.0.4",
+    "@budibase/string-templates": "^1.0.4",
    "@bull-board/api": "^3.7.0",
    "@bull-board/koa": "^3.7.0",
    "@elastic/elasticsearch": "7.10.0",
--- a/packages/string-templates/package.json
+++ b/packages/string-templates/package.json
@ -1,6 +1,6 @@
 {
  "name": "@budibase/string-templates",
-  "version": "1.0.3-alpha.0",
+  "version": "1.0.4",
  "description": "Handlebars wrapper for Budibase templating.",
  "main": "src/index.cjs",
  "module": "dist/bundle.mjs",
--- a/packages/worker/package.json
+++ b/packages/worker/package.json
@ -1,7 +1,7 @@
 {
  "name": "@budibase/worker",
  "email": "hi@budibase.com",
-  "version": "1.0.3-alpha.0",
+  "version": "1.0.4",
  "description": "Budibase background service",
  "main": "src/index.js",
  "repository": {
@ -29,8 +29,8 @@
  "author": "Budibase",
  "license": "GPL-3.0",
  "dependencies": {
-    "@budibase/auth": "^1.0.3-alpha.0",
-    "@budibase/string-templates": "^1.0.3-alpha.0",
+    "@budibase/auth": "^1.0.4",
+    "@budibase/string-templates": "^1.0.4",
    "@koa/router": "^8.0.0",
    "@sentry/node": "^6.0.0",
    "@techpass/passport-openidconnect": "^0.3.0",