Update new row top component to fix multiple z-index issues

This commit is contained in:
Andrew Kingston 2023-04-21 18:43:01 +01:00
parent 77406ac183
commit 49f5aea19c
1 changed files with 55 additions and 48 deletions

View File

@ -1,6 +1,6 @@
<script> <script>
import GridCell from "../cells/GridCell.svelte" import GridCell from "../cells/GridCell.svelte"
import { getContext, onMount } from "svelte" import { getContext, onMount, tick } from "svelte"
import { Icon, Button } from "@budibase/bbui" import { Icon, Button } from "@budibase/bbui"
import GridScrollWrapper from "./GridScrollWrapper.svelte" import GridScrollWrapper from "./GridScrollWrapper.svelte"
import DataCell from "../cells/DataCell.svelte" import DataCell from "../cells/DataCell.svelte"
@ -15,11 +15,10 @@
config, config,
dispatch, dispatch,
rows, rows,
showHScrollbar, focusedCellAPI,
tableId, tableId,
subscribe, subscribe,
renderedColumns, renderedColumns,
scrollLeft,
} = getContext("grid") } = getContext("grid")
let isAdding = false let isAdding = false
@ -27,8 +26,6 @@
let touched = false let touched = false
$: firstColumn = $stickyColumn || $renderedColumns[0] $: firstColumn = $stickyColumn || $renderedColumns[0]
$: rowHovered = $hoveredRowId === "new"
$: rowFocused = $focusedCellId?.startsWith("new-")
$: width = GutterWidth + ($stickyColumn?.width || 0) $: width = GutterWidth + ($stickyColumn?.width || 0)
$: $tableId, (isAdding = false) $: $tableId, (isAdding = false)
@ -56,12 +53,18 @@
$hoveredRowId = null $hoveredRowId = null
} }
const startAdding = () => { const startAdding = async () => {
newRow = {} newRow = {}
isAdding = true isAdding = true
$hoveredRowId = "new" $hoveredRowId = "new"
if (firstColumn) { if (firstColumn) {
$focusedCellId = `new-${firstColumn.name}` $focusedCellId = `new-${firstColumn.name}`
// Also focus the cell if it is a text-like cell
if (["string", "number"].includes(firstColumn.schema.type)) {
await tick()
$focusedCellAPI?.focus()
}
} }
} }
@ -96,13 +99,18 @@
<!-- Only show new row functionality if we have any columns --> <!-- Only show new row functionality if we have any columns -->
{#if isAdding} {#if isAdding}
<div class="container"> <div class="container">
<div
class="underlay sticky"
style="width:{width}px;"
transition:fade={{ duration: 130 }}
/>
<div class="underlay" transition:fade={{ duration: 130 }} />
<div <div
class="sticky-column" class="sticky-column"
transition:fade={{ duration: 130 }} transition:fade={{ duration: 130 }}
style="flex: 0 0 {width}px" style="flex: 0 0 {width}px"
class:scrolled={$scrollLeft > 0}
> >
<GridCell width={GutterWidth} {rowHovered} rowFocused> <GridCell width={GutterWidth} rowFocused>
<div class="gutter"> <div class="gutter">
<div class="number">1</div> <div class="number">1</div>
{#if $config.allowExpandRows} {#if $config.allowExpandRows}
@ -124,18 +132,16 @@
/> />
{/if} {/if}
</div> </div>
<div class="normal-columns" transition:fade={{ duration: 130 }}>
<GridScrollWrapper scrollHorizontally wheelInteractive> <GridScrollWrapper scrollHorizontally wheelInteractive>
<div class="row"> <div class="row" transition:fade={{ duration: 130 }}>
{#each $renderedColumns as column} {#each $renderedColumns as column}
{@const cellId = `new-${column.name}`} {@const cellId = `new-${column.name}`}
{#key cellId} {#key cellId}
<DataCell <DataCell
{cellId} {cellId}
{column} {column}
{rowFocused}
{rowHovered}
{updateValue} {updateValue}
rowFocused
row={newRow} row={newRow}
focused={$focusedCellId === cellId} focused={$focusedCellId === cellId}
width={column.width} width={column.width}
@ -145,7 +151,6 @@
{/each} {/each}
</div> </div>
</GridScrollWrapper> </GridScrollWrapper>
</div>
<div class="buttons" transition:fade={{ duration: 130 }}> <div class="buttons" transition:fade={{ duration: 130 }}>
<Button size="M" cta on:click={addRow}>Save</Button> <Button size="M" cta on:click={addRow}>Save</Button>
<Button size="M" secondary newStyles on:click={cancel}>Cancel</Button> <Button size="M" secondary newStyles on:click={cancel}>Cancel</Button>
@ -168,24 +173,39 @@
--cell-background: var(--spectrum-global-color-gray-100); --cell-background: var(--spectrum-global-color-gray-100);
} }
/* Add overlays independently behind both separate z-indexed column containers */ /* Underlay sits behind everything */
.sticky-column:before, .underlay {
.normal-columns:before {
position: absolute; position: absolute;
content: ""; content: "";
left: 0; left: 0;
top: 0; top: var(--row-height);
height: 100%; height: 100%;
width: 100%; width: 100%;
background: var(--cell-background); background: var(--cell-background);
opacity: 0.8; opacity: 0.8;
} }
.underlay.sticky {
z-index: 2;
}
/* Floating buttons which sit on top of the underlay but below the sticky column */
.buttons {
display: flex;
flex-direction: row;
gap: 8px;
pointer-events: all;
z-index: 3;
position: absolute;
top: calc(var(--row-height) + 24px);
left: 32px;
}
/* Sticky column styles */ /* Sticky column styles */
.sticky-column { .sticky-column {
display: flex; display: flex;
z-index: 2; z-index: 4;
position: relative; position: relative;
align-self: flex-start;
} }
.sticky-column :global(.cell:not(:last-child)) { .sticky-column :global(.cell:not(:last-child)) {
border-right: none; border-right: none;
@ -208,22 +228,9 @@
/* Normal column styles */ /* Normal column styles */
.normal-columns { .normal-columns {
flex: 1 1 auto;
} }
.row { .row {
width: 0; width: 0;
display: flex; display: flex;
} }
/* Floating buttons */
.buttons {
display: flex;
flex-direction: row;
gap: 8px;
pointer-events: all;
z-index: 2;
position: absolute;
top: calc(var(--row-height) + 24px);
left: var(--gutter-width);
}
</style> </style>