-
-
{item.label || item.field}
+ >
+
+
+ {item.field}
+
+
+
{readableText}
@@ -53,4 +81,20 @@
.list-item-body {
justify-content: space-between;
}
+ .type-icon {
+ display: flex;
+ gap: var(--spacing-m);
+ margin: var(--spacing-xl);
+ margin-bottom: 0px;
+ height: var(--spectrum-alias-item-height-m);
+ padding: 0px var(--spectrum-alias-item-padding-m);
+ border-width: var(--spectrum-actionbutton-border-size);
+ border-radius: var(--spectrum-alias-border-radius-regular);
+ border: 1px solid
+ var(
+ --spectrum-actionbutton-m-border-color,
+ var(--spectrum-alias-border-color)
+ );
+ align-items: center;
+ }
diff --git a/packages/builder/src/components/integration/RestQueryViewer.svelte b/packages/builder/src/components/integration/RestQueryViewer.svelte
index 254f65fcaf..e6913b0953 100644
--- a/packages/builder/src/components/integration/RestQueryViewer.svelte
+++ b/packages/builder/src/components/integration/RestQueryViewer.svelte
@@ -196,8 +196,36 @@
}
}
+ const validateQuery = async () => {
+ const forbiddenBindings = /{{\s?user(\.(\w|\$)*\s?|\s?)}}/g
+ const bindingError = new Error(
+ "'user' is a protected binding and cannot be used"
+ )
+
+ if (forbiddenBindings.test(url)) {
+ throw bindingError
+ }
+
+ if (forbiddenBindings.test(query.fields.requestBody ?? "")) {
+ throw bindingError
+ }
+
+ Object.values(requestBindings).forEach(bindingValue => {
+ if (forbiddenBindings.test(bindingValue)) {
+ throw bindingError
+ }
+ })
+
+ Object.values(query.fields.headers).forEach(headerValue => {
+ if (forbiddenBindings.test(headerValue)) {
+ throw bindingError
+ }
+ })
+ }
+
async function runQuery() {
try {
+ await validateQuery()
response = await queries.preview(buildQuery())
if (response.rows.length === 0) {
notifications.info("Request did not return any data")
diff --git a/packages/builder/src/pages/builder/app/[application]/design/[screenId]/[componentId]/_components/Component/ComponentSettingsPanel.svelte b/packages/builder/src/pages/builder/app/[application]/design/[screenId]/[componentId]/_components/Component/ComponentSettingsPanel.svelte
index 17eadb99bd..affa115ca2 100644
--- a/packages/builder/src/pages/builder/app/[application]/design/[screenId]/[componentId]/_components/Component/ComponentSettingsPanel.svelte
+++ b/packages/builder/src/pages/builder/app/[application]/design/[screenId]/[componentId]/_components/Component/ComponentSettingsPanel.svelte
@@ -91,7 +91,12 @@
/>
{/if}
{#if section == "styles"}
-
+
{
+ const getSections = (instance, definition, isScreen, tag) => {
const settings = definition?.settings ?? []
- const generalSettings = settings.filter(setting => !setting.section)
- const customSections = settings.filter(setting => setting.section)
+ const generalSettings = settings.filter(
+ setting => !setting.section && setting.tag === tag
+ )
+ const customSections = settings.filter(
+ setting => setting.section && setting.tag === tag
+ )
let sections = [
- {
- name: "General",
- settings: generalSettings,
- },
+ ...(generalSettings?.length
+ ? [
+ {
+ name: "General",
+ settings: generalSettings,
+ },
+ ]
+ : []),
...(customSections || []),
]
@@ -132,7 +146,7 @@
- {:else if idx === 0 && section.name === "General" && componentDefinition.info}
+ {:else if idx === 0 && section.name === "General" && componentDefinition?.info && !tag}
{/if}
{/each}
-{#if componentDefinition?.block}
+{#if componentDefinition?.block && !tag}
diff --git a/packages/builder/src/pages/builder/app/[application]/design/[screenId]/[componentId]/_components/Component/DesignSection.svelte b/packages/builder/src/pages/builder/app/[application]/design/[screenId]/[componentId]/_components/Component/DesignSection.svelte
index 444ded7e1f..def1fcf24b 100644
--- a/packages/builder/src/pages/builder/app/[application]/design/[screenId]/[componentId]/_components/Component/DesignSection.svelte
+++ b/packages/builder/src/pages/builder/app/[application]/design/[screenId]/[componentId]/_components/Component/DesignSection.svelte
@@ -1,10 +1,12 @@
+
+
+
{#if styles?.length > 0}
{#each styles as style}
+ import BlockComponent from "../BlockComponent.svelte"
+ import Block from "../Block.svelte"
+
+ export let buttons = []
+ export let direction
+ export let hAlign
+ export let vAlign
+ export let gap = "S"
+
+
+
+
+ {#each buttons as { text, type, quiet, disabled, onClick, size }}
+
+ {/each}
+
+
diff --git a/packages/client/src/components/app/index.js b/packages/client/src/components/app/index.js
index 060c15a857..97df3741e1 100644
--- a/packages/client/src/components/app/index.js
+++ b/packages/client/src/components/app/index.js
@@ -19,6 +19,7 @@ export { default as dataprovider } from "./DataProvider.svelte"
export { default as divider } from "./Divider.svelte"
export { default as screenslot } from "./ScreenSlot.svelte"
export { default as button } from "./Button.svelte"
+export { default as buttongroup } from "./ButtonGroup.svelte"
export { default as repeater } from "./Repeater.svelte"
export { default as text } from "./Text.svelte"
export { default as layout } from "./Layout.svelte"
diff --git a/packages/server/Dockerfile.v2 b/packages/server/Dockerfile.v2
index 881c21299e..f737570fcd 100644
--- a/packages/server/Dockerfile.v2
+++ b/packages/server/Dockerfile.v2
@@ -44,7 +44,7 @@ RUN chmod +x ./scripts/removeWorkspaceDependencies.sh
WORKDIR /string-templates
COPY packages/string-templates/package.json package.json
RUN ../scripts/removeWorkspaceDependencies.sh package.json
-RUN --mount=type=cache,target=/root/.yarn YARN_CACHE_FOLDER=/root/.yarn yarn install --production=true
+RUN --mount=type=cache,target=/root/.yarn YARN_CACHE_FOLDER=/root/.yarn yarn install --production=true --network-timeout 1000000
COPY packages/string-templates .
@@ -57,7 +57,7 @@ COPY scripts/removeWorkspaceDependencies.sh scripts/removeWorkspaceDependencies.
RUN chmod +x ./scripts/removeWorkspaceDependencies.sh
RUN ./scripts/removeWorkspaceDependencies.sh package.json
-RUN --mount=type=cache,target=/root/.yarn YARN_CACHE_FOLDER=/root/.yarn yarn install --production=true \
+RUN --mount=type=cache,target=/root/.yarn YARN_CACHE_FOLDER=/root/.yarn yarn install --production=true --network-timeout 1000000 \
# Remove unneeded data from file system to reduce image size
&& yarn cache clean && apt-get remove -y --purge --auto-remove g++ make python jq \
&& rm -rf /tmp/* /root/.node-gyp /usr/local/lib/node_modules/npm/node_modules/node-gyp
diff --git a/packages/server/src/api/controllers/role.ts b/packages/server/src/api/controllers/role.ts
index ed23009706..3697bbe925 100644
--- a/packages/server/src/api/controllers/role.ts
+++ b/packages/server/src/api/controllers/role.ts
@@ -1,4 +1,10 @@
-import { context, db as dbCore, events, roles } from "@budibase/backend-core"
+import {
+ context,
+ db as dbCore,
+ events,
+ roles,
+ Header,
+} from "@budibase/backend-core"
import { getUserMetadataParams, InternalTables } from "../../db/utils"
import { Database, Role, UserCtx, UserRoles } from "@budibase/types"
import { sdk as sharedSdk } from "@budibase/shared-core"
@@ -143,4 +149,20 @@ export async function accessible(ctx: UserCtx) {
} else {
ctx.body = await roles.getUserRoleIdHierarchy(roleId!)
}
+
+ // If a custom role is provided in the header, filter out higher level roles
+ const roleHeader = ctx.header?.[Header.PREVIEW_ROLE] as string
+ if (roleHeader && !Object.keys(roles.BUILTIN_ROLE_IDS).includes(roleHeader)) {
+ const inherits = (await roles.getRole(roleHeader))?.inherits
+ const orderedRoles = ctx.body.reverse()
+ let filteredRoles = [roleHeader]
+ for (let role of orderedRoles) {
+ filteredRoles = [role, ...filteredRoles]
+ if (role === inherits) {
+ break
+ }
+ }
+ filteredRoles.pop()
+ ctx.body = [roleHeader, ...filteredRoles]
+ }
}
diff --git a/packages/server/src/api/routes/tests/role.spec.js b/packages/server/src/api/routes/tests/role.spec.js
index c8e383d5ed..d133a69d64 100644
--- a/packages/server/src/api/routes/tests/role.spec.js
+++ b/packages/server/src/api/routes/tests/role.spec.js
@@ -158,5 +158,25 @@ describe("/roles", () => {
expect(res.body.length).toBe(1)
expect(res.body[0]).toBe("PUBLIC")
})
+
+ it("should not fetch higher level accessible roles when a custom role header is provided", async () => {
+ await createRole({
+ name: `CUSTOM_ROLE`,
+ inherits: roles.BUILTIN_ROLE_IDS.BASIC,
+ permissionId: permissions.BuiltinPermissionID.READ_ONLY,
+ version: "name",
+ })
+ const res = await request
+ .get("/api/roles/accessible")
+ .set({
+ ...config.defaultHeaders(),
+ "x-budibase-role": "CUSTOM_ROLE"
+ })
+ .expect(200)
+ expect(res.body.length).toBe(3)
+ expect(res.body[0]).toBe("CUSTOM_ROLE")
+ expect(res.body[1]).toBe("BASIC")
+ expect(res.body[2]).toBe("PUBLIC")
+ })
})
})
diff --git a/packages/server/src/api/routes/tests/routing.spec.js b/packages/server/src/api/routes/tests/routing.spec.js
index ff6d7aba1d..4076f4879c 100644
--- a/packages/server/src/api/routes/tests/routing.spec.js
+++ b/packages/server/src/api/routes/tests/routing.spec.js
@@ -1,5 +1,5 @@
const setup = require("./utilities")
-const { basicScreen } = setup.structures
+const { basicScreen, powerScreen } = setup.structures
const { checkBuilderEndpoint, runInProd } = require("./utilities/TestFunctions")
const { roles } = require("@budibase/backend-core")
const { BUILTIN_ROLE_IDS } = roles
@@ -12,19 +12,14 @@ const route = "/test"
describe("/routing", () => {
let request = setup.getRequest()
let config = setup.getConfig()
- let screen, screen2
+ let basic, power
afterAll(setup.afterAll)
beforeAll(async () => {
await config.init()
- screen = basicScreen()
- screen.routing.route = route
- screen = await config.createScreen(screen)
- screen2 = basicScreen()
- screen2.routing.roleId = BUILTIN_ROLE_IDS.POWER
- screen2.routing.route = route
- screen2 = await config.createScreen(screen2)
+ basic = await config.createScreen(basicScreen(route))
+ power = await config.createScreen(powerScreen(route))
await config.publish()
})
@@ -61,8 +56,8 @@ describe("/routing", () => {
expect(res.body.routes[route]).toEqual({
subpaths: {
[route]: {
- screenId: screen._id,
- roleId: screen.routing.roleId
+ screenId: basic._id,
+ roleId: basic.routing.roleId
}
}
})
@@ -80,8 +75,8 @@ describe("/routing", () => {
expect(res.body.routes[route]).toEqual({
subpaths: {
[route]: {
- screenId: screen2._id,
- roleId: screen2.routing.roleId
+ screenId: power._id,
+ roleId: power.routing.roleId
}
}
})
@@ -101,8 +96,8 @@ describe("/routing", () => {
expect(res.body.routes).toBeDefined()
expect(res.body.routes[route].subpaths[route]).toBeDefined()
const subpath = res.body.routes[route].subpaths[route]
- expect(subpath.screens[screen2.routing.roleId]).toEqual(screen2._id)
- expect(subpath.screens[screen.routing.roleId]).toEqual(screen._id)
+ expect(subpath.screens[power.routing.roleId]).toEqual(power._id)
+ expect(subpath.screens[basic.routing.roleId]).toEqual(basic._id)
})
it("make sure it is a builder only endpoint", async () => {
diff --git a/packages/server/src/constants/screens.ts b/packages/server/src/constants/screens.ts
index 23e36a65b8..6c88b0f957 100644
--- a/packages/server/src/constants/screens.ts
+++ b/packages/server/src/constants/screens.ts
@@ -1,7 +1,15 @@
import { roles } from "@budibase/backend-core"
import { BASE_LAYOUT_PROP_IDS } from "./layouts"
-export function createHomeScreen() {
+export function createHomeScreen(
+ config: {
+ roleId: string
+ route: string
+ } = {
+ roleId: roles.BUILTIN_ROLE_IDS.BASIC,
+ route: "/",
+ }
+) {
return {
description: "",
url: "",
@@ -40,8 +48,8 @@ export function createHomeScreen() {
gap: "M",
},
routing: {
- route: "/",
- roleId: roles.BUILTIN_ROLE_IDS.BASIC,
+ route: config.route,
+ roleId: config.roleId,
},
name: "home-screen",
}
diff --git a/packages/server/src/tests/utilities/structures.ts b/packages/server/src/tests/utilities/structures.ts
index d3e92ea34d..6d236062a8 100644
--- a/packages/server/src/tests/utilities/structures.ts
+++ b/packages/server/src/tests/utilities/structures.ts
@@ -20,6 +20,7 @@ import {
SourceName,
Table,
} from "@budibase/types"
+const { BUILTIN_ROLE_IDS } = roles
export function basicTable(): Table {
return {
@@ -322,8 +323,22 @@ export function basicUser(role: string) {
}
}
-export function basicScreen() {
- return createHomeScreen()
+export function basicScreen(route: string = "/") {
+ return createHomeScreen({
+ roleId: BUILTIN_ROLE_IDS.BASIC,
+ route,
+ })
+}
+
+export function powerScreen(route: string = "/") {
+ return createHomeScreen({
+ roleId: BUILTIN_ROLE_IDS.POWER,
+ route,
+ })
+}
+
+export function customScreen(config: { roleId: string; route: string }) {
+ return createHomeScreen(config)
}
export function basicLayout() {
diff --git a/packages/worker/Dockerfile.v2 b/packages/worker/Dockerfile.v2
index a8be432827..4706ca155a 100644
--- a/packages/worker/Dockerfile.v2
+++ b/packages/worker/Dockerfile.v2
@@ -19,7 +19,7 @@ RUN chmod +x ./scripts/removeWorkspaceDependencies.sh
WORKDIR /string-templates
COPY packages/string-templates/package.json package.json
RUN ../scripts/removeWorkspaceDependencies.sh package.json
-RUN --mount=type=cache,target=/root/.yarn YARN_CACHE_FOLDER=/root/.yarn yarn install --production=true
+RUN --mount=type=cache,target=/root/.yarn YARN_CACHE_FOLDER=/root/.yarn yarn install --production=true --network-timeout 1000000
COPY packages/string-templates .
@@ -30,7 +30,7 @@ RUN cd ../string-templates && yarn link && cd - && yarn link @budibase/string-te
RUN ../scripts/removeWorkspaceDependencies.sh package.json
-RUN --mount=type=cache,target=/root/.yarn YARN_CACHE_FOLDER=/root/.yarn yarn install --production=true
+RUN --mount=type=cache,target=/root/.yarn YARN_CACHE_FOLDER=/root/.yarn yarn install --production=true --network-timeout 1000000
# Remove unneeded data from file system to reduce image size
RUN apk del .gyp \
&& yarn cache clean
diff --git a/scripts/updateWorkspaceVersions.V2.sh b/scripts/updateWorkspaceVersions.V2.sh
new file mode 100755
index 0000000000..634bcbcfb0
--- /dev/null
+++ b/scripts/updateWorkspaceVersions.V2.sh
@@ -0,0 +1,8 @@
+#!/bin/bash
+version=$1
+echo "Setting version $version"
+yarn lerna exec "yarn version --no-git-tag-version --new-version=$version"
+echo "Updating dependencies"
+node scripts/syncLocalDependencies.js $version
+echo "Syncing yarn workspace"
+yarn