Merge pull request #14911 from Budibase/2.33.4-uno-revert-4

Revert to state from 2.33.4.

.github/workflows/deploy-qa.yml

@@ -3,7 +3,7 @@ name: Deploy QA
 on:
   push:
     branches:
-      - feature/automation-branching-ux
+      - v3-ui
   workflow_dispatch:
 
 jobs:

hosting/single/Dockerfile

@@ -22,7 +22,7 @@ RUN ./scripts/removeWorkspaceDependencies.sh packages/worker/package.json
 
 RUN jq 'del(.scripts.postinstall)' package.json > temp.json && mv temp.json package.json
 RUN ./scripts/removeWorkspaceDependencies.sh package.json
-RUN --mount=type=cache,target=/root/.yarn YARN_CACHE_FOLDER=/root/.yarn yarn install --production --frozen-lockfile --network-concurrency 1
+RUN --mount=type=cache,target=/root/.yarn YARN_CACHE_FOLDER=/root/.yarn yarn install --production --frozen-lockfile
 
 # copy the actual code
 COPY packages/server/dist packages/server/dist

lerna.json

@@ -22,4 +22,4 @@
       "loadEnvFiles": false
     }
   }
-}
+}

packages/backend-core/src/security/roles.ts

@@ -219,10 +219,7 @@ export function getBuiltinRole(roleId: string): Role | undefined {
 export function builtinRoleToNumber(id: string) {
   const builtins = getBuiltinRoles()
   const MAX = Object.values(builtins).length + 1
-  if (
+  if (id === BUILTIN_IDS.ADMIN || id === BUILTIN_IDS.BUILDER) {
-    compareRoleIds(id, BUILTIN_IDS.ADMIN) ||
-    compareRoleIds(id, BUILTIN_IDS.BUILDER)
-  ) {
     return MAX
   }
   let role = builtins[id],
@@ -259,9 +256,7 @@ export async function roleToNumber(id: string) {
       // find the built-in roles, get their number, sort it, then get the last one
       const highestBuiltin: number | undefined = role.inherits
         .map(roleId => {
-          const foundRole = hierarchy.find(role =>
+          const foundRole = hierarchy.find(role => role._id === roleId)
-            compareRoleIds(role._id!, roleId)
-          )
           if (foundRole) {
             return findNumber(foundRole) + 1
           }
@@ -385,7 +380,7 @@ async function getAllUserRoles(
 ): Promise<RoleDoc[]> {
   const allRoles = await getAllRoles()
   // admins have access to all roles
-  if (compareRoleIds(userRoleId, BUILTIN_IDS.ADMIN)) {
+  if (userRoleId === BUILTIN_IDS.ADMIN) {
     return allRoles
   }
 
@@ -496,21 +491,17 @@ export async function getAllRoles(appId?: string): Promise<RoleDoc[]> {
     // need to combine builtin with any DB record of them (for sake of permissions)
     for (let builtinRoleId of externalBuiltinRoles) {
       const builtinRole = builtinRoles[builtinRoleId]
-      const dbBuiltin = roles.filter(dbRole =>
+      const dbBuiltin = roles.filter(
-        compareRoleIds(dbRole._id!, builtinRoleId)
+        dbRole =>
+          getExternalRoleID(dbRole._id!, dbRole.version) === builtinRoleId
       )[0]
       if (dbBuiltin == null) {
         roles.push(builtinRole || builtinRoles.BASIC)
       } else {
         // remove role and all back after combining with the builtin
         roles = roles.filter(role => role._id !== dbBuiltin._id)
-        dbBuiltin._id = getExternalRoleID(builtinRole._id!, dbBuiltin.version)
+        dbBuiltin._id = getExternalRoleID(dbBuiltin._id!, dbBuiltin.version)
-        roles.push({
+        roles.push(Object.assign(builtinRole, dbBuiltin))
-          ...builtinRole,
-          ...dbBuiltin,
-          name: builtinRole.name,
-          _id: getExternalRoleID(builtinRole._id!, builtinRole.version),
-        })
       }
     }
     // check permissions
@@ -553,9 +544,9 @@ export class AccessController {
     if (
       tryingRoleId == null ||
       tryingRoleId === "" ||
-      compareRoleIds(tryingRoleId, BUILTIN_IDS.BUILDER) ||
+      tryingRoleId === userRoleId ||
-      compareRoleIds(userRoleId!, tryingRoleId) ||
+      tryingRoleId === BUILTIN_IDS.BUILDER ||
-      compareRoleIds(userRoleId!, BUILTIN_IDS.BUILDER)
+      userRoleId === BUILTIN_IDS.BUILDER
     ) {
       return true
     }

packages/builder/src/pages/builder/app/[application]/settings/automations/index.svelte

@@ -38,10 +38,6 @@
   let loaded = false
   $: app = $appsStore.apps.find(app => $appStore.appId?.includes(app.appId))
   $: licensePlan = $auth.user?.license?.plan
-
-  // Reset the page every time that a filter gets updated
-  $: pageInfo.reset(), automationId, status, timeRange
-
   $: page = $pageInfo.page
   $: fetchLogs(automationId, status, page, timeRange)
   $: isCloud = $admin.cloud

packages/builder/src/pages/builder/portal/users/users/index.svelte

@@ -71,6 +71,7 @@
   ]
   let userData = []
   let invitesLoaded = false
+  let tenantOwnerLoaded = false
   let pendingInvites = []
   let parsedInvites = []
 
@@ -99,9 +100,13 @@
   $: pendingSchema = getPendingSchema(schema)
   $: userData = []
   $: inviteUsersResponse = { successful: [], unsuccessful: [] }
-  $: setEnrichedUsers($fetch.rows, tenantOwner)
+  $: setEnrichedUsers($fetch.rows, tenantOwnerLoaded)
 
-  const setEnrichedUsers = async (rows, owner) => {
+  const setEnrichedUsers = async rows => {
+    if (!tenantOwnerLoaded) {
+      enrichedUsers = []
+      return
+    }
     enrichedUsers = rows?.map(user => {
       let userGroups = []
       $groups.forEach(group => {
@@ -113,9 +118,7 @@
           })
         }
       })
-      if (owner) {
+      user.tenantOwnerEmail = tenantOwner?.email
-        user.tenantOwnerEmail = owner.email
-      }
       const role = Constants.ExtendedBudibaseRoleOptions.find(
         x => x.value === users.getUserRole(user)
       )
@@ -319,21 +322,12 @@
     try {
       await groups.actions.init()
       groupsLoaded = true
-    } catch (error) {
-      notifications.error("Error fetching user group data")
-    }
-    try {
       pendingInvites = await users.getInvites()
       invitesLoaded = true
-    } catch (err) {
-      notifications.error("Error fetching user invitations")
-    }
-    try {
       tenantOwner = await users.getAccountHolder()
-    } catch (err) {
+      tenantOwnerLoaded = true
-      if (err.status !== 404) {
+    } catch (error) {
-        notifications.error("Error fetching account holder")
+      notifications.error("Error fetching user group data")
-      }
     }
   })
 </script>

packages/client/src/components/app/forms/RelationshipField.svelte

@@ -113,10 +113,7 @@
   $: debouncedFetchRows(searchTerm, primaryDisplay, defaultValue)
 
   const forceFetchRows = async () => {
-    // if the filter has changed, then we need to reset the options, clear the selection, and re-fetch
-    optionsObj = {}
     fieldApi?.setValue([])
-    selectedValue = []
     debouncedFetchRows(searchTerm, primaryDisplay, defaultValue)
   }
   const fetchRows = async (searchTerm, primaryDisplay, defaultVal) => {

packages/frontend-core/src/fetch/UserFetch.js

@@ -32,7 +32,7 @@ export default class UserFetch extends DataFetch {
     const { cursor, query } = get(this.store)
     let finalQuery
     // convert old format to new one - we now allow use of the lucene format
-    const { appId, paginated, ...rest } = query || {}
+    const { appId, paginated, ...rest } = query
     if (!QueryUtils.hasFilters(query) && rest.email != null) {
       finalQuery = { string: { email: rest.email } }
     } else {

packages/pro

@@ -1 +1 @@
-Subproject commit 2ab8536b6005576684810d774f1ac22239218546
+Subproject commit f6aebba94451ce47bba551926e5ad72bd75f71c6

packages/server/Dockerfile

@@ -41,7 +41,7 @@ RUN chmod +x ./scripts/removeWorkspaceDependencies.sh
 RUN ./scripts/removeWorkspaceDependencies.sh package.json
 
 # Install yarn packages with caching
-RUN --mount=type=cache,target=/root/.yarn YARN_CACHE_FOLDER=/root/.yarn yarn install --production=true --network-timeout 1000000 --network-concurrency 1 \
+RUN --mount=type=cache,target=/root/.yarn YARN_CACHE_FOLDER=/root/.yarn yarn install --production=true --network-timeout 1000000 \
     && yarn cache clean \
     && apk del g++ make python3 jq \
     && rm -rf /tmp/* /root/.node-gyp /usr/local/lib/node_modules/npm/node_modules/node-gyp

packages/worker/Dockerfile

@@ -24,7 +24,7 @@ COPY packages/worker/dist/yarn.lock .
 
 RUN ../scripts/removeWorkspaceDependencies.sh package.json
 
-RUN --mount=type=cache,target=/root/.yarn YARN_CACHE_FOLDER=/root/.yarn yarn install --production=true --network-timeout 1000000 --network-concurrency 1
+RUN --mount=type=cache,target=/root/.yarn YARN_CACHE_FOLDER=/root/.yarn yarn install --production=true --network-timeout 1000000
 # Remove unneeded data from file system to reduce image size
 RUN apk del .gyp \
     && yarn cache clean