LegacyView test api

packages/server/src/api/routes/tests/row.spec.ts

@@ -690,11 +690,7 @@ describe.each([
         const rowUsage = await getRowUsage()
         const queryUsage = await getQueryUsage()
 
-        const res = await request
+        const res = await config.api.legacyView.get(table._id!)
-          .get(`/api/views/${table._id}`)
-          .set(config.defaultHeaders())
-          .expect("Content-Type", /json/)
-          .expect(200)
         expect(res.body.length).toEqual(1)
         expect(res.body[0]._id).toEqual(row._id)
         await assertRowUsage(rowUsage)
@@ -705,10 +701,7 @@ describe.each([
         const rowUsage = await getRowUsage()
         const queryUsage = await getQueryUsage()
 
-        await request
+        await config.api.legacyView.get("derp", { expectStatus: 404 })
-          .get(`/api/views/derp`)
-          .set(config.defaultHeaders())
-          .expect(404)
 
         await assertRowUsage(rowUsage)
         await assertQueryUsage(queryUsage)
@@ -725,11 +718,7 @@ describe.each([
         const rowUsage = await getRowUsage()
         const queryUsage = await getQueryUsage()
 
-        const res = await request
+        const res = await config.api.legacyView.get(view.name)
-          .get(`/api/views/${view.name}`)
-          .set(config.defaultHeaders())
-          .expect("Content-Type", /json/)
-          .expect(200)
         expect(res.body.length).toEqual(1)
         expect(res.body[0]._id).toEqual(row._id)
 

packages/server/src/tests/utilities/api/index.ts

@@ -4,9 +4,11 @@ import { RowAPI } from "./row"
 import { TableAPI } from "./table"
 import { ViewV2API } from "./viewV2"
 import { DatasourceAPI } from "./datasource"
+import { LegacyViewAPI } from "./legacyView"
 
 export default class API {
   table: TableAPI
+  legacyView: LegacyViewAPI
   viewV2: ViewV2API
   row: RowAPI
   permission: PermissionAPI
@@ -14,6 +16,7 @@ export default class API {
 
   constructor(config: TestConfiguration) {
     this.table = new TableAPI(config)
+    this.legacyView = new LegacyViewAPI(config)
     this.viewV2 = new ViewV2API(config)
     this.row = new RowAPI(config)
     this.permission = new PermissionAPI(config)

packages/server/src/tests/utilities/api/legacyView.ts

@@ -0,0 +1,16 @@
+import TestConfiguration from "../TestConfiguration"
+import { TestAPI } from "./base"
+
+export class LegacyViewAPI extends TestAPI {
+  constructor(config: TestConfiguration) {
+    super(config)
+  }
+
+  get = async (id: string, { expectStatus } = { expectStatus: 200 }) => {
+    return await this.request
+      .get(`/api/views/${id}`)
+      .set(this.config.defaultHeaders())
+      .expect("Content-Type", /json/)
+      .expect(expectStatus)
+  }
+}