From 4fb9a4aa59a773afc5de6bd9ea8af0bf8f0fc6d7 Mon Sep 17 00:00:00 2001 From: Rory Powell Date: Thu, 20 Jan 2022 16:20:58 +0000 Subject: [PATCH] validator tweak --- packages/builder/src/helpers/validation/yup/app.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/packages/builder/src/helpers/validation/yup/app.js b/packages/builder/src/helpers/validation/yup/app.js index 4be6e3cbb0..d89eb72db8 100644 --- a/packages/builder/src/helpers/validation/yup/app.js +++ b/packages/builder/src/helpers/validation/yup/app.js @@ -13,6 +13,7 @@ export const name = (validation, { apps, currentApp } = { apps: [] }) => { "Another app with the same name already exists", value => { if (!value) { + // exit early, above validator will fail return true } if (currentApp) { @@ -57,12 +58,12 @@ export const url = (validation, { apps, currentApp } = { apps: {} }) => { .some(appUrl => appUrl.toLowerCase() === value.toLowerCase()) } ) - .test("start-with-slash", "Not a valid URL", value => { + .test("valid-url", "Not a valid URL", value => { // url is nullable if (!value) { return true } - return value.length > 1 + return value.startsWith("/") && value.length > 1 }) ) }