From 508a865ea5927f387772dee52417d708bf38b38b Mon Sep 17 00:00:00 2001
From: Dean <deanhannigan@gmail.com>
Date: Fri, 8 Jul 2022 09:09:21 +0100
Subject: [PATCH] Action drawer updates. Actions now grouped by type and
 filterable in the action drawer

---
 .../ButtonActionDrawer.svelte                 | 110 +++++++++++++++---
 .../ButtonActionEditor.svelte                 |  12 ++
 .../ButtonActionEditor/manifest.json          |  19 ++-
 3 files changed, 124 insertions(+), 17 deletions(-)

diff --git a/packages/builder/src/components/design/PropertiesPanel/PropertyControls/ButtonActionEditor/ButtonActionDrawer.svelte b/packages/builder/src/components/design/PropertiesPanel/PropertyControls/ButtonActionEditor/ButtonActionDrawer.svelte
index 5b0ab4a6a3..c78611c950 100644
--- a/packages/builder/src/components/design/PropertiesPanel/PropertyControls/ButtonActionEditor/ButtonActionDrawer.svelte
+++ b/packages/builder/src/components/design/PropertiesPanel/PropertyControls/ButtonActionEditor/ButtonActionDrawer.svelte
@@ -6,8 +6,8 @@
     Button,
     Layout,
     DrawerContent,
-    ActionMenu,
-    MenuItem,
+    ActionButton,
+    Search,
   } from "@budibase/bbui"
   import { getAvailableActions } from "./index"
   import { generate } from "shortid"
@@ -22,8 +22,24 @@
   export let actions
   export let bindings = []
 
+  let showAvailableActions = false
+
+  let actionQuery
+  $: parsedQuery =
+    typeof actionQuery === "string" ? actionQuery.toLowerCase().trim() : ""
+
   let selectedAction = actions?.length ? actions[0] : null
 
+  $: mappedActionTypes = actionTypes.reduce((acc, action) => {
+    let parsedName = action.name.toLowerCase().trim()
+    if (parsedQuery.length && parsedName.indexOf(parsedQuery) < 0) {
+      return acc
+    }
+    acc[action.type] = acc[action.type] || []
+    acc[action.type].push(action)
+    return acc
+  }, {})
+
   // These are ephemeral bindings which only exist while executing actions
   $: buttonContextBindings = getButtonContextBindings(
     $currentAsset,
@@ -61,7 +77,12 @@
     actions = actions
   }
 
-  const addAction = actionType => () => {
+  const toggleActionList = () => {
+    actionQuery = null
+    showAvailableActions = !showAvailableActions
+  }
+
+  const addAction = actionType => {
     const newAction = {
       parameters: {},
       [EVENT_TYPE_KEY]: actionType.name,
@@ -78,6 +99,11 @@
     selectedAction = action
   }
 
+  const onAddAction = actionType => {
+    addAction(actionType)
+    toggleActionList()
+  }
+
   function handleDndConsider(e) {
     actions = e.detail.items
   }
@@ -88,7 +114,29 @@
 
 <DrawerContent>
   <Layout noPadding gap="S" slot="sidebar">
-    {#if actions && actions.length > 0}
+    {#if showAvailableActions}
+      <div>
+        <ActionButton secondary icon={"ArrowLeft"} on:click={toggleActionList}>
+          Back
+        </ActionButton>
+      </div>
+      <Search placeholder="Search" bind:value={actionQuery} />
+      {#each Object.entries(mappedActionTypes) as [categoryId, category]}
+        <div class="heading">{categoryId}</div>
+        <ul>
+          {#each category as actionType}
+            <li on:click={onAddAction(actionType)}>
+              <span class="binding__label">{actionType.name}</span>
+            </li>
+          {/each}
+        </ul>
+      {/each}
+    {/if}
+
+    {#if actions && actions.length > 0 && !showAvailableActions}
+      <div>
+        <Button secondary on:click={toggleActionList}>Add Action</Button>
+      </div>
       <div
         class="actions"
         use:dndzone={{
@@ -120,17 +168,9 @@
         {/each}
       </div>
     {/if}
-    <ActionMenu>
-      <Button slot="control" secondary>Add Action</Button>
-      {#each actionTypes as actionType}
-        <MenuItem on:click={addAction(actionType)}>
-          {actionType.name}
-        </MenuItem>
-      {/each}
-    </ActionMenu>
   </Layout>
   <Layout noPadding>
-    {#if selectedActionComponent}
+    {#if selectedActionComponent && !showAvailableActions}
       {#key selectedAction.id}
         <div class="selected-action-container">
           <svelte:component
@@ -152,13 +192,10 @@
     align-items: stretch;
     gap: var(--spacing-s);
   }
-
   .action-header {
     color: var(--spectrum-global-color-gray-700);
-
     flex: 1 1 auto;
   }
-
   .action-container {
     background-color: var(--background);
     padding: var(--spacing-s) var(--spacing-m);
@@ -182,4 +219,45 @@
   .action-container.selected .action-header {
     color: var(--spectrum-global-color-gray-900);
   }
+
+  ul {
+    list-style: none;
+    padding: 0;
+    margin: 0;
+  }
+
+  li {
+    font-size: var(--font-size-s);
+    padding: var(--spacing-m);
+    border-radius: 4px;
+    border: var(--border-light);
+    transition: background-color 130ms ease-in-out, color 130ms ease-in-out,
+      border-color 130ms ease-in-out;
+    word-wrap: break-word;
+  }
+  li:not(:last-of-type) {
+    margin-bottom: var(--spacing-s);
+  }
+  li :global(*) {
+    transition: color 130ms ease-in-out;
+  }
+  li:hover {
+    color: var(--spectrum-global-color-gray-900);
+    background-color: var(--spectrum-global-color-gray-50);
+    border-color: var(--spectrum-global-color-gray-500);
+    cursor: pointer;
+  }
+  li:hover :global(*) {
+    color: var(--spectrum-global-color-gray-900) !important;
+  }
+  .binding__label {
+    font-weight: 600;
+    text-transform: capitalize;
+  }
+  .heading {
+    font-size: var(--font-size-s);
+    font-weight: 600;
+    text-transform: uppercase;
+    color: var(--spectrum-global-color-gray-600);
+  }
 </style>
diff --git a/packages/builder/src/components/design/PropertiesPanel/PropertyControls/ButtonActionEditor/ButtonActionEditor.svelte b/packages/builder/src/components/design/PropertiesPanel/PropertyControls/ButtonActionEditor/ButtonActionEditor.svelte
index 550d982013..8e5954f078 100644
--- a/packages/builder/src/components/design/PropertiesPanel/PropertyControls/ButtonActionEditor/ButtonActionEditor.svelte
+++ b/packages/builder/src/components/design/PropertiesPanel/PropertyControls/ButtonActionEditor/ButtonActionEditor.svelte
@@ -69,9 +69,15 @@
       notifications.error("Error creating automation")
     }
   }
+
+  $: actionCount = value?.length
+  $: actionText = `${actionCount || "No"} action${
+    actionCount !== 1 ? "s" : ""
+  } set`
 </script>
 
 <ActionButton on:click={openDrawer}>Define actions</ActionButton>
+<div class="action-count">{actionText}</div>
 <Drawer bind:this={drawer} title={"Actions"}>
   <svelte:fragment slot="description">
     Define what actions to run.
@@ -85,3 +91,9 @@
     {key}
   />
 </Drawer>
+
+<style>
+  .action-count {
+    padding-top: var(--spacing-s);
+  }
+</style>
diff --git a/packages/builder/src/components/design/PropertiesPanel/PropertyControls/ButtonActionEditor/manifest.json b/packages/builder/src/components/design/PropertiesPanel/PropertyControls/ButtonActionEditor/manifest.json
index cf18fee3a6..40aa606f88 100644
--- a/packages/builder/src/components/design/PropertiesPanel/PropertyControls/ButtonActionEditor/manifest.json
+++ b/packages/builder/src/components/design/PropertiesPanel/PropertyControls/ButtonActionEditor/manifest.json
@@ -2,6 +2,7 @@
   "actions": [
     {
       "name": "Save Row",
+      "type": "data",
       "component": "SaveRow",
       "context": [
         {
@@ -12,6 +13,7 @@
     },
     {
       "name": "Duplicate Row",
+      "type": "data",
       "component": "DuplicateRow",
       "context": [
         {
@@ -22,14 +24,17 @@
     },
     {
       "name": "Delete Row",
+      "type": "data",
       "component": "DeleteRow"
     },
     {
       "name": "Navigate To",
+      "type": "ui/ux",
       "component": "NavigateTo"
     },
     {
       "name": "Execute Query",
+      "type": "data",
       "component": "ExecuteQuery",
       "context": [
         {
@@ -40,43 +45,53 @@
     },
     {
       "name": "Trigger Automation",
+      "type": "ui/ux",
       "component": "TriggerAutomation"
     },
     {
       "name": "Update Field Value",
+      "type": "form",
       "component": "UpdateFieldValue"
     },
     {
       "name": "Validate Form",
+      "type": "form",
       "component": "ValidateForm"
     },
     {
       "name": "Change Form Step",
+      "type": "form",
       "component": "ChangeFormStep"
     },
     {
       "name": "Clear Form",
+      "type": "form",
       "component": "ClearForm"
     },
     {
       "name": "Log Out",
+      "type": "ui/ux",
       "component": "LogOut"
     },
     {
       "name": "Close Screen Modal",
+      "type": "ui/ux",
       "component": "CloseScreenModal"
     },
     {
       "name": "Refresh Data Provider",
+      "type": "data",
       "component": "RefreshDataProvider"
     },
     {
       "name": "Update State",
+      "type": "data",
       "component": "UpdateState",
       "dependsOnFeature": "state"
     },
     {
       "name": "Upload File to S3",
+      "type": "data",
       "component": "S3Upload",
       "context": [
         {
@@ -87,12 +102,14 @@
     },
     {
       "name": "Export Data",
+      "type": "data",
       "component": "ExportData"
     },
     {
       "name": "Continue if / Stop if",
+      "type": "ui/ux",
       "component": "ContinueIf",
       "dependsOnFeature": "continueIfAction"
     }
   ]
-}
+}
\ No newline at end of file