From 5180ac29d2a99122309f73b57cfa713b65223930 Mon Sep 17 00:00:00 2001
From: Mateus Badan de Pieri <mateuspieri@gmail.com>
Date: Fri, 14 Apr 2023 12:16:01 +0100
Subject: [PATCH] final functions being tested

---
 .../backend-core/src/security/permissions.ts  |  4 +-
 .../src/security/tests/permissions.spec.ts    | 41 ++++++++++++++++---
 2 files changed, 38 insertions(+), 7 deletions(-)

diff --git a/packages/backend-core/src/security/permissions.ts b/packages/backend-core/src/security/permissions.ts
index dfe7988f76..6cacc12dd6 100644
--- a/packages/backend-core/src/security/permissions.ts
+++ b/packages/backend-core/src/security/permissions.ts
@@ -24,7 +24,7 @@ export enum PermissionType {
   QUERY = "query",
 }
 
-class Permission {
+export class Permission {
   type: PermissionType
   level: PermissionLevel
 
@@ -81,7 +81,7 @@ export enum BuiltinPermissionID {
   POWER = "power",
 }
 
-const BUILTIN_PERMISSIONS = {
+export const BUILTIN_PERMISSIONS = {
   PUBLIC: {
     _id: BuiltinPermissionID.PUBLIC,
     name: "Public",
diff --git a/packages/backend-core/src/security/tests/permissions.spec.ts b/packages/backend-core/src/security/tests/permissions.spec.ts
index 264e521f8b..8f6ee76c81 100644
--- a/packages/backend-core/src/security/tests/permissions.spec.ts
+++ b/packages/backend-core/src/security/tests/permissions.spec.ts
@@ -1,3 +1,4 @@
+import { cloneDeep } from "lodash"
 import {
   doesHaveBasePermission,
   getBuiltinPermissionByID,
@@ -6,7 +7,12 @@ import {
   PermissionType,
   levelToNumber,
   getAllowedLevels,
+  BuiltinPermissionID,
+  getBuiltinPermissions,
+  BUILTIN_PERMISSIONS,
+  Permission,
 } from "../permissions"
+import { BUILTIN_ROLE_IDS } from "../roles"
 
 describe("levelToNumber", () => {
   it("should return 0 for EXECUTE", () => {
@@ -66,11 +72,13 @@ describe("getAllowedLevels", () => {
 
 describe("doesHaveBasePermission", () => {
   it("should return true if base permission has the required level", () => {
-    const permType = PermissionType.APP
+    const permType = PermissionType.USER
     const permLevel = PermissionLevel.READ
     const rolesHierarchy = [
-      { roleId: "role1", permissionId: "permission1" },
-      { roleId: "role2", permissionId: "permission2" },
+      {
+        roleId: BUILTIN_ROLE_IDS.ADMIN,
+        permissionId: BuiltinPermissionID.ADMIN,
+      },
     ]
     expect(doesHaveBasePermission(permType, permLevel, rolesHierarchy)).toBe(
       true
@@ -81,8 +89,10 @@ describe("doesHaveBasePermission", () => {
     const permType = PermissionType.APP
     const permLevel = PermissionLevel.READ
     const rolesHierarchy = [
-      { roleId: "role1", permissionId: "permission1" },
-      { roleId: "role2", permissionId: "permission2" },
+      {
+        roleId: BUILTIN_ROLE_IDS.PUBLIC,
+        permissionId: BuiltinPermissionID.PUBLIC,
+      },
     ]
     expect(doesHaveBasePermission(permType, permLevel, rolesHierarchy)).toBe(
       false
@@ -99,3 +109,24 @@ describe("isPermissionLevelHigherThanRead", () => {
     expect(isPermissionLevelHigherThanRead(PermissionLevel.READ)).toBe(false)
   })
 })
+
+describe("getBuiltinPermissions", () => {
+  test("returns a clone of the builtin permissions", () => {
+    const builtins = getBuiltinPermissions()
+    expect(builtins).toEqual(cloneDeep(BUILTIN_PERMISSIONS))
+    expect(builtins).not.toBe(BUILTIN_PERMISSIONS)
+  })
+})
+
+describe("getBuiltinPermissionByID", () => {
+  test("returns correct permission object for valid ID", () => {
+    const expectedPermission = {
+      _id: BuiltinPermissionID.PUBLIC,
+      name: "Public",
+      permissions: [
+        new Permission(PermissionType.WEBHOOK, PermissionLevel.EXECUTE),
+      ],
+    }
+    expect(getBuiltinPermissionByID("public")).toEqual(expectedPermission)
+  })
+})