From 54ddb9415a846999ab746884f47e673a8ca64791 Mon Sep 17 00:00:00 2001
From: Conor_Mack <36074859+Conor-Mack@users.noreply.github.com>
Date: Wed, 4 Dec 2019 22:13:06 +0000
Subject: [PATCH] Fix for field modal infinite render loop once closed from
 click away (#42)

---
 packages/builder/src/common/Modal.svelte      | 80 +++++++++----------
 .../builder/src/database/RecordView.svelte    |  3 +-
 2 files changed, 42 insertions(+), 41 deletions(-)

diff --git a/packages/builder/src/common/Modal.svelte b/packages/builder/src/common/Modal.svelte
index 83479c7596..0f47d553a0 100644
--- a/packages/builder/src/common/Modal.svelte
+++ b/packages/builder/src/common/Modal.svelte
@@ -1,41 +1,41 @@
-<script>
-import UIkit from "uikit";
-
-export let isOpen = false;
-export let onClosed = () => {};
-export let id = "";
-
-let ukModal;
-let listenerAdded = false;
-
-$: {
-    if(ukModal && !listenerAdded) {
-        listenerAdded = true;
-        ukModal.addEventListener("hide", onClosed);
-    }
-
-    if(ukModal) {
-        if(isOpen) {
-            UIkit.modal(ukModal).show();
-        } else {
-            UIkit.modal(ukModal).hide();
-        }
-    }
-}
-
-</script>
-
-<div bind:this={ukModal} uk-modal {id}>
-    <div class="uk-modal-dialog uk-modal-body" uk-overflow-auto>
-        <slot />
-    </div>
-</div>
-
-
-<style>
-
-.uk-modal-dialog {
-    border-radius: .3rem;
-}
-
+<script>
+import UIkit from "uikit";
+
+export let isOpen = false;
+export let onClosed = () => {};
+export let id = "";
+
+let ukModal;
+let listenerAdded = false;
+
+$: {
+    if(ukModal && !listenerAdded) {
+        listenerAdded = true;
+        ukModal.addEventListener("hidden", onClosed);
+    }
+
+    if(ukModal) {
+        if(isOpen) {
+            UIkit.modal(ukModal).show();
+        } else {
+            UIkit.modal(ukModal).hide();
+        }
+    }
+}
+
+</script>
+
+<div bind:this={ukModal} uk-modal {id}>
+    <div class="uk-modal-dialog uk-modal-body" uk-overflow-auto>
+        <slot />
+    </div>
+</div>
+
+
+<style>
+
+.uk-modal-dialog {
+    border-radius: .3rem;
+}
+
 </style>
\ No newline at end of file
diff --git a/packages/builder/src/database/RecordView.svelte b/packages/builder/src/database/RecordView.svelte
index d0a8f7acdb..b6cf351b40 100644
--- a/packages/builder/src/database/RecordView.svelte
+++ b/packages/builder/src/database/RecordView.svelte
@@ -39,6 +39,7 @@ store.subscribe($store => {
         editingField = true;
     }
 
+
     onFinishedFieldEdit = (field) => {
         if(field) {
             store.saveField(field);
@@ -139,7 +140,7 @@ const nameChanged = ev => {
     {/if}
 
     {#if editingField}
-    <Modal bind:isOpen={editingField}>
+    <Modal bind:isOpen={editingField} onClosed={() => onFinishedFieldEdit(false) }>
         <FieldView field={fieldToEdit} 
                    onFinished={onFinishedFieldEdit}
                    allFields={record.fields}