MirrorSave
/
budibase
mirror of https://github.com/Budibase/budibase.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix multiple bugs with ID numbering in the event editor

This commit is contained in:
Andrew Kingston 2021-04-19 14:37:04 +01:00
parent bafe7b64bd
commit 575cb55402
1 changed files with 10 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
packages/builder/src/components/design/PropertiesPanel/PropertyControls/EventsEditor/EventEditor.svelte
View File

@ -3,6 +3,7 @@
import { dndzone } from "svelte-dnd-action" import { dndzone } from "svelte-dnd-action"
import { Button, DropdownMenu, Spacer } from "@budibase/bbui" import { Button, DropdownMenu, Spacer } from "@budibase/bbui"
import actionTypes from "./actions" import actionTypes from "./actions"
import { generate } from "shortid"
const flipDurationMs = 150 const flipDurationMs = 150
@ -11,11 +12,15 @@
export let actions export let actions
// dndzone needs an id on the array items, so this adds some temporary ones. // dndzone needs an id on the array items, so this adds some temporary ones.
$: {
if (actions) { if (actions) {
actions = actions.map((action, i) => { actions.forEach(action => {
return { ...action, id: i } if (!action.id) {
action.id = generate()
}
}) })
} }
}
let addActionButton let addActionButton
let addActionDropdown let addActionDropdown
@ -41,7 +46,7 @@
const newAction = { const newAction = {
parameters: {}, parameters: {},
[EVENT_TYPE_KEY]: actionType.name, [EVENT_TYPE_KEY]: actionType.name,
id: actions ? actions.length + 1 : 0, id: generate(),
} }
if (!actions) { if (!actions) {
actions = [] actions = []