From 5773f39659a9468043d190a542534ec45d974287 Mon Sep 17 00:00:00 2001
From: Pedro Silva <pedro@budibase.com>
Date: Mon, 12 Dec 2022 16:32:37 +0000
Subject: [PATCH] Organize user and permissions tests

---
 .../userManagement/appSpecificRoles.spec.ts   | 278 ++++++++++++++++++
 .../userManagement/userManagement.spec.ts     | 204 -------------
 2 files changed, 278 insertions(+), 204 deletions(-)
 create mode 100644 qa-core/src/tests/internal-api/userManagement/appSpecificRoles.spec.ts

diff --git a/qa-core/src/tests/internal-api/userManagement/appSpecificRoles.spec.ts b/qa-core/src/tests/internal-api/userManagement/appSpecificRoles.spec.ts
new file mode 100644
index 0000000000..3fb97cf847
--- /dev/null
+++ b/qa-core/src/tests/internal-api/userManagement/appSpecificRoles.spec.ts
@@ -0,0 +1,278 @@
+import TestConfiguration from "../../../config/internal-api/TestConfiguration"
+import { Application } from "@budibase/server/api/controllers/public/mapping/types"
+import InternalAPIClient from "../../../config/internal-api/TestConfiguration/InternalAPIClient"
+import generateApp from "../../../config/internal-api/fixtures/applications"
+import { generateUser } from "../../../config/internal-api/fixtures/userManagement"
+import { User } from "@budibase/types"
+import { generateNewColumnForTable, generateTable } from "../../../config/internal-api/fixtures/table"
+import generateScreen from "../../../config/internal-api/fixtures/screens"
+
+describe("Internal API - App Specific Roles & Permissions", () => {
+    const api = new InternalAPIClient()
+    const config = new TestConfiguration<Application>(api)
+
+    // Before each test, login as admin. Some tests will require login as a different user
+    beforeEach(async () => {
+        await config.loginAsAdmin()
+    })
+
+    afterAll(async () => {
+        await config.afterAll()
+    })
+
+    it("Add BASIC user to app", async () => {
+        const appUser = generateUser()
+        expect(appUser[0].builder?.global).toEqual(false)
+        expect(appUser[0].admin?.global).toEqual(false)
+        const [createUserResponse, createUserJson] = await config.users.addMultiple(appUser)
+
+        const app = await config.applications.create(generateApp())
+        config.applications.api.appId = app.appId
+
+        const [userInfoResponse, userInfoJson] = await config.users.getInfo(createUserJson.created.successful[0]._id)
+        const body: User = {
+            ...userInfoJson,
+            roles: {
+                [<string>app.appId]: "BASIC",
+            }
+        }
+        await config.users.updateInfo(body)
+
+        const [changedUserInfoResponse, changedUserInfoJson] = await config.users.getInfo(createUserJson.created.successful[0]._id)
+        expect(changedUserInfoJson.roles[<string>app.appId]).toBeDefined()
+        expect(changedUserInfoJson.roles[<string>app.appId]).toEqual("BASIC")
+
+    })
+
+    it("Add ADMIN user to app", async () => {
+        const adminUser = generateUser(1, "admin")
+        expect(adminUser[0].builder?.global).toEqual(true)
+        expect(adminUser[0].admin?.global).toEqual(true)
+        const [createUserResponse, createUserJson] = await config.users.addMultiple(adminUser)
+
+        const app = await config.applications.create(generateApp())
+        config.applications.api.appId = app.appId
+
+        const [userInfoResponse, userInfoJson] = await config.users.getInfo(createUserJson.created.successful[0]._id)
+        const body: User = {
+            ...userInfoJson,
+            roles: {
+                [<string>app.appId]: "ADMIN",
+            }
+        }
+        await config.users.updateInfo(body)
+
+        const [changedUserInfoResponse, changedUserInfoJson] = await config.users.getInfo(createUserJson.created.successful[0]._id)
+        expect(changedUserInfoJson.roles[<string>app.appId]).toBeDefined()
+        expect(changedUserInfoJson.roles[<string>app.appId]).toEqual("ADMIN")
+
+    })
+
+    it("Add POWER user to app", async () => {
+        const powerUser = generateUser(1, 'developer')
+        expect(powerUser[0].builder?.global).toEqual(true)
+
+        const [createUserResponse, createUserJson] = await config.users.addMultiple(powerUser)
+
+        const app = await config.applications.create(generateApp())
+        config.applications.api.appId = app.appId
+
+        const [userInfoResponse, userInfoJson] = await config.users.getInfo(createUserJson.created.successful[0]._id)
+        const body: User = {
+            ...userInfoJson,
+            roles: {
+                [<string>app.appId]: "POWER",
+            }
+        }
+        await config.users.updateInfo(body)
+
+        const [changedUserInfoResponse, changedUserInfoJson] = await config.users.getInfo(createUserJson.created.successful[0]._id)
+        expect(changedUserInfoJson.roles[<string>app.appId]).toBeDefined()
+        expect(changedUserInfoJson.roles[<string>app.appId]).toEqual("POWER")
+
+    })
+
+    describe("Check Access for default roles", () => {
+        it("Check Table access for app user", async () => {
+            const appUser = generateUser()
+            expect(appUser[0].builder?.global).toEqual(false)
+            expect(appUser[0].admin?.global).toEqual(false)
+            const [createUserResponse, createUserJson] = await config.users.addMultiple(appUser)
+
+            const app = await config.applications.create(generateApp())
+            config.applications.api.appId = app.appId
+
+            const [userInfoResponse, userInfoJson] = await config.users.getInfo(createUserJson.created.successful[0]._id)
+            const body: User = {
+                ...userInfoJson,
+                roles: {
+                    [<string>app.appId]: "BASIC",
+                }
+            }
+            await config.users.updateInfo(body)
+
+            const [changedUserInfoResponse, changedUserInfoJson] = await config.users.getInfo(createUserJson.created.successful[0]._id)
+            expect(changedUserInfoJson.roles[<string>app.appId]).toBeDefined()
+            expect(changedUserInfoJson.roles[<string>app.appId]).toEqual("BASIC")
+
+            const [createdTableResponse, createdTableData] = await config.tables.save(
+                generateTable()
+            )
+            await config.login(<string>appUser[0].email, <string>appUser[0].password)
+            const newColumn = generateNewColumnForTable(createdTableData)
+            await config.tables.forbiddenSave(
+                newColumn)
+            await config.tables.forbiddenSave(generateTable())
+        })
+
+        it("Check Table access for developer", async () => {
+            const developer = generateUser(1, 'developer')
+            expect(developer[0].builder?.global).toEqual(true)
+
+            const [createUserResponse, createUserJson] = await config.users.addMultiple(developer)
+
+            const app = await config.applications.create(generateApp())
+            config.applications.api.appId = app.appId
+
+            const [userInfoResponse, userInfoJson] = await config.users.getInfo(createUserJson.created.successful[0]._id)
+            const body: User = {
+                ...userInfoJson,
+                roles: {
+                    [<string>app.appId]: "POWER",
+                }
+            }
+            await config.users.updateInfo(body)
+
+            const [changedUserInfoResponse, changedUserInfoJson] = await config.users.getInfo(createUserJson.created.successful[0]._id)
+            expect(changedUserInfoJson.roles[<string>app.appId]).toBeDefined()
+            expect(changedUserInfoJson.roles[<string>app.appId]).toEqual("POWER")
+
+            const [createdTableResponse, createdTableData] = await config.tables.save(
+                generateTable()
+            )
+            await config.login(<string>developer[0].email, <string>developer[0].password)
+            const newColumn = generateNewColumnForTable(createdTableData)
+            const [addColumnResponse, addColumnData] = await config.tables.save(
+                newColumn,
+                true
+            )
+        })
+
+        it("Check Table access for admin", async () => {
+            const adminUser = generateUser(1, "admin")
+            expect(adminUser[0].builder?.global).toEqual(true)
+            expect(adminUser[0].admin?.global).toEqual(true)
+            const [createUserResponse, createUserJson] = await config.users.addMultiple(adminUser)
+
+            const app = await config.applications.create(generateApp())
+            config.applications.api.appId = app.appId
+
+            const [userInfoResponse, userInfoJson] = await config.users.getInfo(createUserJson.created.successful[0]._id)
+            const body: User = {
+                ...userInfoJson,
+                roles: {
+                    [<string>app.appId]: "ADMIN",
+                }
+            }
+            await config.users.updateInfo(body)
+
+            const [changedUserInfoResponse, changedUserInfoJson] = await config.users.getInfo(createUserJson.created.successful[0]._id)
+            expect(changedUserInfoJson.roles[<string>app.appId]).toBeDefined()
+            expect(changedUserInfoJson.roles[<string>app.appId]).toEqual("ADMIN")
+
+            await config.login(<string>adminUser[0].email, <string>adminUser[0].password)
+            const [createdTableResponse, createdTableData] = await config.tables.save(
+                generateTable()
+            )
+            const newColumn = generateNewColumnForTable(createdTableData)
+            const [addColumnResponse, addColumnData] = await config.tables.save(
+                newColumn,
+                true
+            )
+        })
+
+        it("Check Screen access for BASIC Role", async () => {
+            const appUser = generateUser()
+            expect(appUser[0].builder?.global).toEqual(false)
+            expect(appUser[0].admin?.global).toEqual(false)
+            const [createUserResponse, createUserJson] = await config.users.addMultiple(appUser)
+
+            const app = await config.applications.create(generateApp())
+            config.applications.api.appId = app.appId
+
+            const [userInfoResponse, userInfoJson] = await config.users.getInfo(createUserJson.created.successful[0]._id)
+            const body: User = {
+                ...userInfoJson,
+                roles: {
+                    [<string>app.appId]: "BASIC",
+                }
+            }
+            await config.users.updateInfo(body)
+
+            const [changedUserInfoResponse, changedUserInfoJson] = await config.users.getInfo(createUserJson.created.successful[0]._id)
+            expect(changedUserInfoJson.roles[<string>app.appId]).toBeDefined()
+            expect(changedUserInfoJson.roles[<string>app.appId]).toEqual("BASIC")
+
+            const [basicScreenResponse, basicScreenJson] = await config.screen.create(generateScreen("BASIC"))
+
+
+        })
+
+        it("Check Screen access for POWER role", async () => {
+            const appUser = generateUser()
+            expect(appUser[0].builder?.global).toEqual(false)
+            expect(appUser[0].admin?.global).toEqual(false)
+            const [createUserResponse, createUserJson] = await config.users.addMultiple(appUser)
+
+            const app = await config.applications.create(generateApp())
+            config.applications.api.appId = app.appId
+
+            const [userInfoResponse, userInfoJson] = await config.users.getInfo(createUserJson.created.successful[0]._id)
+            const body: User = {
+                ...userInfoJson,
+                roles: {
+                    [<string>app.appId]: "POWER",
+                }
+            }
+            await config.users.updateInfo(body)
+
+            const [changedUserInfoResponse, changedUserInfoJson] = await config.users.getInfo(createUserJson.created.successful[0]._id)
+            expect(changedUserInfoJson.roles[<string>app.appId]).toBeDefined()
+            expect(changedUserInfoJson.roles[<string>app.appId]).toEqual("POWER")
+        })
+
+        it("Check Screen access for ADMIN role", async () => {
+            const appUser = generateUser()
+            expect(appUser[0].builder?.global).toEqual(false)
+            expect(appUser[0].admin?.global).toEqual(false)
+            const [createUserResponse, createUserJson] = await config.users.addMultiple(appUser)
+
+            const app = await config.applications.create(generateApp())
+            config.applications.api.appId = app.appId
+
+            const [userInfoResponse, userInfoJson] = await config.users.getInfo(createUserJson.created.successful[0]._id)
+            const body: User = {
+                ...userInfoJson,
+                roles: {
+                    [<string>app.appId]: "ADMIN",
+                }
+            }
+            await config.users.updateInfo(body)
+
+            const [changedUserInfoResponse, changedUserInfoJson] = await config.users.getInfo(createUserJson.created.successful[0]._id)
+            expect(changedUserInfoJson.roles[<string>app.appId]).toBeDefined()
+            expect(changedUserInfoJson.roles[<string>app.appId]).toEqual("ADMIN")
+
+        })
+    })
+
+
+    describe.skip("App Access for custom roles", () => {
+        it("Custom role access for level 1 permissions", async () => { })
+        it("Custom role access for level 2 permissions", async () => { })
+        it("Custom role access for level 3 permissions", async () => { })
+        it("Custom role access for level 4 permissions", async () => { })
+        it("Custom role access for level 5 permissions", async () => { })
+    })
+
+})
\ No newline at end of file
diff --git a/qa-core/src/tests/internal-api/userManagement/userManagement.spec.ts b/qa-core/src/tests/internal-api/userManagement/userManagement.spec.ts
index 8110929b41..32820b8b7f 100644
--- a/qa-core/src/tests/internal-api/userManagement/userManagement.spec.ts
+++ b/qa-core/src/tests/internal-api/userManagement/userManagement.spec.ts
@@ -1,11 +1,8 @@
 import TestConfiguration from "../../../config/internal-api/TestConfiguration"
 import { Application } from "@budibase/server/api/controllers/public/mapping/types"
 import InternalAPIClient from "../../../config/internal-api/TestConfiguration/InternalAPIClient"
-import generateApp from "../../../config/internal-api/fixtures/applications"
 import { generateUser } from "../../../config/internal-api/fixtures/userManagement"
 import { User } from "@budibase/types"
-import { generateNewColumnForTable, generateTable } from "../../../config/internal-api/fixtures/table"
-import generateScreen from "../../../config/internal-api/fixtures/screens"
 
 describe("Internal API - User Management & Permissions", () => {
     const api = new InternalAPIClient()
@@ -88,207 +85,6 @@ describe("Internal API - User Management & Permissions", () => {
         expect(changedUserInfoJson.builder?.global).toEqual(true)
     })
 
-    it("Add BASIC user to app", async () => {
-        const appUser = generateUser()
-        expect(appUser[0].builder?.global).toEqual(false)
-        expect(appUser[0].admin?.global).toEqual(false)
-        const [createUserResponse, createUserJson] = await config.users.addMultiple(appUser)
 
-        const app = await config.applications.create(generateApp())
-        config.applications.api.appId = app.appId
-
-        const [userInfoResponse, userInfoJson] = await config.users.getInfo(createUserJson.created.successful[0]._id)
-        const body: User = {
-            ...userInfoJson,
-            roles: {
-                [<string>app.appId]: "BASIC",
-            }
-        }
-        await config.users.updateInfo(body)
-
-        const [changedUserInfoResponse, changedUserInfoJson] = await config.users.getInfo(createUserJson.created.successful[0]._id)
-        expect(changedUserInfoJson.roles[<string>app.appId]).toBeDefined()
-        expect(changedUserInfoJson.roles[<string>app.appId]).toEqual("BASIC")
-
-    })
-
-    it("Add ADMIN user to app", async () => {
-        const adminUser = generateUser(1, "admin")
-        expect(adminUser[0].builder?.global).toEqual(true)
-        expect(adminUser[0].admin?.global).toEqual(true)
-        const [createUserResponse, createUserJson] = await config.users.addMultiple(adminUser)
-
-        const app = await config.applications.create(generateApp())
-        config.applications.api.appId = app.appId
-
-        const [userInfoResponse, userInfoJson] = await config.users.getInfo(createUserJson.created.successful[0]._id)
-        const body: User = {
-            ...userInfoJson,
-            roles: {
-                [<string>app.appId]: "ADMIN",
-            }
-        }
-        await config.users.updateInfo(body)
-
-        const [changedUserInfoResponse, changedUserInfoJson] = await config.users.getInfo(createUserJson.created.successful[0]._id)
-        expect(changedUserInfoJson.roles[<string>app.appId]).toBeDefined()
-        expect(changedUserInfoJson.roles[<string>app.appId]).toEqual("ADMIN")
-
-    })
-
-    it("Add POWER user to app", async () => {
-        const powerUser = generateUser(1, 'developer')
-        expect(powerUser[0].builder?.global).toEqual(true)
-
-        const [createUserResponse, createUserJson] = await config.users.addMultiple(powerUser)
-
-        const app = await config.applications.create(generateApp())
-        config.applications.api.appId = app.appId
-
-        const [userInfoResponse, userInfoJson] = await config.users.getInfo(createUserJson.created.successful[0]._id)
-        const body: User = {
-            ...userInfoJson,
-            roles: {
-                [<string>app.appId]: "POWER",
-            }
-        }
-        await config.users.updateInfo(body)
-
-        const [changedUserInfoResponse, changedUserInfoJson] = await config.users.getInfo(createUserJson.created.successful[0]._id)
-        expect(changedUserInfoJson.roles[<string>app.appId]).toBeDefined()
-        expect(changedUserInfoJson.roles[<string>app.appId]).toEqual("POWER")
-
-    })
-
-    it("Check Table access for app user", async () => {
-        const appUser = generateUser()
-        expect(appUser[0].builder?.global).toEqual(false)
-        expect(appUser[0].admin?.global).toEqual(false)
-        const [createUserResponse, createUserJson] = await config.users.addMultiple(appUser)
-
-        const app = await config.applications.create(generateApp())
-        config.applications.api.appId = app.appId
-
-        const [userInfoResponse, userInfoJson] = await config.users.getInfo(createUserJson.created.successful[0]._id)
-        const body: User = {
-            ...userInfoJson,
-            roles: {
-                [<string>app.appId]: "BASIC",
-            }
-        }
-        await config.users.updateInfo(body)
-
-        const [changedUserInfoResponse, changedUserInfoJson] = await config.users.getInfo(createUserJson.created.successful[0]._id)
-        expect(changedUserInfoJson.roles[<string>app.appId]).toBeDefined()
-        expect(changedUserInfoJson.roles[<string>app.appId]).toEqual("BASIC")
-
-        const [createdTableResponse, createdTableData] = await config.tables.save(
-            generateTable()
-        )
-        await config.login(<string>appUser[0].email, <string>appUser[0].password)
-        const newColumn = generateNewColumnForTable(createdTableData)
-        await config.tables.forbiddenSave(
-            newColumn)
-        await config.tables.forbiddenSave(generateTable())
-    })
-    //Incomplete Test
-    it("Check Screen access for app user", async () => {
-        const appUser = generateUser()
-        expect(appUser[0].builder?.global).toEqual(false)
-        expect(appUser[0].admin?.global).toEqual(false)
-        const [createUserResponse, createUserJson] = await config.users.addMultiple(appUser)
-
-        const app = await config.applications.create(generateApp())
-        config.applications.api.appId = app.appId
-
-        const [userInfoResponse, userInfoJson] = await config.users.getInfo(createUserJson.created.successful[0]._id)
-        const body: User = {
-            ...userInfoJson,
-            roles: {
-                [<string>app.appId]: "BASIC",
-            }
-        }
-        await config.users.updateInfo(body)
-
-        const [changedUserInfoResponse, changedUserInfoJson] = await config.users.getInfo(createUserJson.created.successful[0]._id)
-        expect(changedUserInfoJson.roles[<string>app.appId]).toBeDefined()
-        expect(changedUserInfoJson.roles[<string>app.appId]).toEqual("BASIC")
-
-        const [basicScreenResponse, basicScreenJson] = await config.screen.create(generateScreen("BASIC"))
-    })
-
-    it("Check Table access for developer", async () => {
-        const developer = generateUser(1, 'developer')
-        expect(developer[0].builder?.global).toEqual(true)
-
-        const [createUserResponse, createUserJson] = await config.users.addMultiple(developer)
-
-        const app = await config.applications.create(generateApp())
-        config.applications.api.appId = app.appId
-
-        const [userInfoResponse, userInfoJson] = await config.users.getInfo(createUserJson.created.successful[0]._id)
-        const body: User = {
-            ...userInfoJson,
-            roles: {
-                [<string>app.appId]: "POWER",
-            }
-        }
-        await config.users.updateInfo(body)
-
-        const [changedUserInfoResponse, changedUserInfoJson] = await config.users.getInfo(createUserJson.created.successful[0]._id)
-        expect(changedUserInfoJson.roles[<string>app.appId]).toBeDefined()
-        expect(changedUserInfoJson.roles[<string>app.appId]).toEqual("POWER")
-
-        const [createdTableResponse, createdTableData] = await config.tables.save(
-            generateTable()
-        )
-        await config.login(<string>developer[0].email, <string>developer[0].password)
-        const newColumn = generateNewColumnForTable(createdTableData)
-        const [addColumnResponse, addColumnData] = await config.tables.save(
-            newColumn,
-            true
-        )
-    })
-
-    it("Check Screen access for developer", async () => {
-
-    })
-
-    it("Check Table access for admin", async () => {
-        const adminUser = generateUser(1, "admin")
-        expect(adminUser[0].builder?.global).toEqual(true)
-        expect(adminUser[0].admin?.global).toEqual(true)
-        const [createUserResponse, createUserJson] = await config.users.addMultiple(adminUser)
-
-        const app = await config.applications.create(generateApp())
-        config.applications.api.appId = app.appId
-
-        const [userInfoResponse, userInfoJson] = await config.users.getInfo(createUserJson.created.successful[0]._id)
-        const body: User = {
-            ...userInfoJson,
-            roles: {
-                [<string>app.appId]: "ADMIN",
-            }
-        }
-        await config.users.updateInfo(body)
-
-        const [changedUserInfoResponse, changedUserInfoJson] = await config.users.getInfo(createUserJson.created.successful[0]._id)
-        expect(changedUserInfoJson.roles[<string>app.appId]).toBeDefined()
-        expect(changedUserInfoJson.roles[<string>app.appId]).toEqual("ADMIN")
-
-        await config.login(<string>adminUser[0].email, <string>adminUser[0].password)
-        const [createdTableResponse, createdTableData] = await config.tables.save(
-            generateTable()
-        )
-        const newColumn = generateNewColumnForTable(createdTableData)
-        const [addColumnResponse, addColumnData] = await config.tables.save(
-            newColumn,
-            true
-        )
-    })
-
-    it("Check Screen access for admin", async () => {
-
-    })
 
 })