From 2ca4dec7005ba48daf4df6b50e8f7315c69516a5 Mon Sep 17 00:00:00 2001
From: Adria Navarro <adria@budibase.com>
Date: Thu, 19 Dec 2024 17:15:28 +0100
Subject: [PATCH 1/5] Clean code

---
 packages/builder/src/stores/builder/tables.ts | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/packages/builder/src/stores/builder/tables.ts b/packages/builder/src/stores/builder/tables.ts
index 31b3a64b5b..d7eb7d89f2 100644
--- a/packages/builder/src/stores/builder/tables.ts
+++ b/packages/builder/src/stores/builder/tables.ts
@@ -141,9 +141,6 @@ export class TableStore extends DerivedBudiStore<
   }
 
   async delete(table: { _id: string; _rev: string }) {
-    if (!table?._id) {
-      return
-    }
     await API.deleteTable(table._id, table._rev)
     this.replaceTable(table._id, null)
   }

From 59a98ec0cb05da9cbe7798e731b116f472a3c17a Mon Sep 17 00:00:00 2001
From: andz-bb <andrew.thompson@budibase.com>
Date: Thu, 19 Dec 2024 16:24:21 +0000
Subject: [PATCH 2/5] support placeholder values in datasource config fields

---
 .../backend/Datasources/ConfigEditor/ConfigInput.svelte        | 2 ++
 .../backend/Datasources/ConfigEditor/fields/LongForm.svelte    | 3 ++-
 .../backend/Datasources/ConfigEditor/fields/Select.svelte      | 2 ++
 .../backend/Datasources/ConfigEditor/fields/String.svelte      | 2 ++
 .../components/backend/Datasources/ConfigEditor/index.svelte   | 3 ++-
 .../backend/Datasources/ConfigEditor/stores/validatedConfig.js | 1 +
 packages/types/src/sdk/datasources.ts                          | 1 +
 7 files changed, 12 insertions(+), 2 deletions(-)

diff --git a/packages/builder/src/components/backend/Datasources/ConfigEditor/ConfigInput.svelte b/packages/builder/src/components/backend/Datasources/ConfigEditor/ConfigInput.svelte
index 70f2ffef46..569f77d5ce 100644
--- a/packages/builder/src/components/backend/Datasources/ConfigEditor/ConfigInput.svelte
+++ b/packages/builder/src/components/backend/Datasources/ConfigEditor/ConfigInput.svelte
@@ -12,6 +12,7 @@
   export let name
   export let config
   export let showModal = () => {}
+  export let placeholder
 
   const selectComponent = type => {
     if (type === "object") {
@@ -40,6 +41,7 @@
   {name}
   {config}
   {showModal}
+  {placeholder}
   on:blur
   on:change
 />
diff --git a/packages/builder/src/components/backend/Datasources/ConfigEditor/fields/LongForm.svelte b/packages/builder/src/components/backend/Datasources/ConfigEditor/fields/LongForm.svelte
index efbeb007e8..6b366a882e 100644
--- a/packages/builder/src/components/backend/Datasources/ConfigEditor/fields/LongForm.svelte
+++ b/packages/builder/src/components/backend/Datasources/ConfigEditor/fields/LongForm.svelte
@@ -5,11 +5,12 @@
   export let name
   export let value
   export let error
+  export let placeholder
 </script>
 
 <div class="form-row">
   <Label>{name}</Label>
-  <TextArea on:blur on:change {type} {value} {error} />
+  <TextArea on:blur on:change {type} {value} {error} {placeholder} />
 </div>
 
 <style>
diff --git a/packages/builder/src/components/backend/Datasources/ConfigEditor/fields/Select.svelte b/packages/builder/src/components/backend/Datasources/ConfigEditor/fields/Select.svelte
index 3185a6c22c..6caf3f25b6 100644
--- a/packages/builder/src/components/backend/Datasources/ConfigEditor/fields/Select.svelte
+++ b/packages/builder/src/components/backend/Datasources/ConfigEditor/fields/Select.svelte
@@ -6,6 +6,7 @@
   export let value
   export let error
   export let config
+  export let placeholder
 </script>
 
 <div class="form-row">
@@ -17,6 +18,7 @@
     {type}
     value={value || undefined}
     {error}
+    {placeholder}
   />
 </div>
 
diff --git a/packages/builder/src/components/backend/Datasources/ConfigEditor/fields/String.svelte b/packages/builder/src/components/backend/Datasources/ConfigEditor/fields/String.svelte
index 1940488819..556c5eb6c1 100644
--- a/packages/builder/src/components/backend/Datasources/ConfigEditor/fields/String.svelte
+++ b/packages/builder/src/components/backend/Datasources/ConfigEditor/fields/String.svelte
@@ -6,6 +6,7 @@
   export let name
   export let value
   export let error
+  export let placeholder
   export let showModal = () => {}
 
   async function handleUpgradePanel() {
@@ -22,6 +23,7 @@
     type={type === "port" ? "string" : type}
     {value}
     {error}
+    {placeholder}
     variables={$environment.variables}
     environmentVariablesEnabled={$licensing.environmentVariablesEnabled}
     {showModal}
diff --git a/packages/builder/src/components/backend/Datasources/ConfigEditor/index.svelte b/packages/builder/src/components/backend/Datasources/ConfigEditor/index.svelte
index 14191868b6..5e825d9704 100644
--- a/packages/builder/src/components/backend/Datasources/ConfigEditor/index.svelte
+++ b/packages/builder/src/components/backend/Datasources/ConfigEditor/index.svelte
@@ -85,7 +85,7 @@
     />
   {/if}
 
-  {#each $configStore.validatedConfig as { type, key, value, error, name, hidden, config }}
+  {#each $configStore.validatedConfig as { type, key, value, error, name, hidden, config, placeholder }}
     {#if hidden === undefined || !eval(processStringSync(hidden, $configStore.config))}
       <ConfigInput
         {type}
@@ -93,6 +93,7 @@
         {error}
         {name}
         {config}
+        {placeholder}
         showModal={() =>
           showModal(newValue => configStore.updateFieldValue(key, newValue))}
         on:blur={() => configStore.markFieldActive(key)}
diff --git a/packages/builder/src/components/backend/Datasources/ConfigEditor/stores/validatedConfig.js b/packages/builder/src/components/backend/Datasources/ConfigEditor/stores/validatedConfig.js
index edd39cc49f..47479be69f 100644
--- a/packages/builder/src/components/backend/Datasources/ConfigEditor/stores/validatedConfig.js
+++ b/packages/builder/src/components/backend/Datasources/ConfigEditor/stores/validatedConfig.js
@@ -114,6 +114,7 @@ export const createValidatedConfigStore = (integration, config) => {
           value: getValue(),
           error: $errorsStore[key],
           name: capitalise(properties.display || key),
+          placeholder: properties.placeholder,
           type: properties.type,
           hidden: properties.hidden,
           config: properties.config,
diff --git a/packages/types/src/sdk/datasources.ts b/packages/types/src/sdk/datasources.ts
index 8b0574bd7c..1f2a4d2127 100644
--- a/packages/types/src/sdk/datasources.ts
+++ b/packages/types/src/sdk/datasources.ts
@@ -119,6 +119,7 @@ interface DatasourceBasicFieldConfig {
   default?: any
   deprecated?: boolean
   hidden?: string
+  placeholder?: string
 }
 
 interface DatasourceSelectFieldConfig extends DatasourceBasicFieldConfig {

From 2d7ef6cee47b60db71426b6c0bcc1b30fc1cc9fa Mon Sep 17 00:00:00 2001
From: andz-bb <andrew.thompson@budibase.com>
Date: Thu, 19 Dec 2024 16:24:55 +0000
Subject: [PATCH 3/5] allow users to select firestore databases other than the
 default

---
 packages/server/src/integrations/firebase.ts | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/packages/server/src/integrations/firebase.ts b/packages/server/src/integrations/firebase.ts
index 3f03f295a9..f96817616d 100644
--- a/packages/server/src/integrations/firebase.ts
+++ b/packages/server/src/integrations/firebase.ts
@@ -12,6 +12,7 @@ interface FirebaseConfig {
   email: string
   privateKey: string
   projectId: string
+  databaseId?: string
 }
 
 const SCHEMA: Integration = {
@@ -30,12 +31,21 @@ const SCHEMA: Integration = {
     },
     privateKey: {
       type: DatasourceFieldType.STRING,
+      display: "Private Key",
       required: true,
     },
     projectId: {
       type: DatasourceFieldType.STRING,
+      display: "Project ID",
       required: true,
     },
+    databaseId: {
+      type: DatasourceFieldType.STRING,
+      display: "Database ID",
+      required: false,
+      default: "(default)",
+      placeholder: "(default)",
+    },
   },
   query: {
     create: {
@@ -97,6 +107,7 @@ class FirebaseIntegration implements IntegrationBase {
     this.config = config
     this.client = new Firestore({
       projectId: config.projectId,
+      databaseId: config.databaseId || "(default)",
       credentials: {
         client_email: config.email,
         private_key: config.privateKey?.replace(/\\n/g, "\n"),

From e00002757e9e48eaf7c14f41496b44ba31af1108 Mon Sep 17 00:00:00 2001
From: Adria Navarro <adria@budibase.com>
Date: Fri, 20 Dec 2024 11:10:06 +0100
Subject: [PATCH 4/5] Fix types

---
 .../builder/src/stores/builder/viewsV2.ts     | 31 ++++++++++---------
 1 file changed, 17 insertions(+), 14 deletions(-)

diff --git a/packages/builder/src/stores/builder/viewsV2.ts b/packages/builder/src/stores/builder/viewsV2.ts
index ed1bdeb008..07cb606eaf 100644
--- a/packages/builder/src/stores/builder/viewsV2.ts
+++ b/packages/builder/src/stores/builder/viewsV2.ts
@@ -11,7 +11,7 @@ interface BuilderViewV2Store {
 
 interface DerivedViewV2Store extends BuilderViewV2Store {
   list: ViewV2[]
-  selected: ViewV2
+  selected?: ViewV2
 }
 
 export class ViewV2Store extends DerivedBudiStore<
@@ -20,20 +20,23 @@ export class ViewV2Store extends DerivedBudiStore<
 > {
   constructor() {
     const makeDerivedStore = (store: Writable<BuilderViewV2Store>) => {
-      return derived([store, tables], ([$store, $tables]) => {
-        let list: ViewV2[] = []
-        $tables.list?.forEach(table => {
-          const views = Object.values(table?.views || {}).filter(
-            helpers.views.isV2
-          )
-          list = list.concat(views)
-        })
-        return {
-          ...$store,
-          list,
-          selected: list.find(view => view.id === $store.selectedViewId),
+      return derived(
+        [store, tables],
+        ([$store, $tables]): DerivedViewV2Store => {
+          let list: ViewV2[] = []
+          $tables.list?.forEach(table => {
+            const views = Object.values(table?.views || {}).filter(
+              helpers.views.isV2
+            )
+            list = list.concat(views)
+          })
+          return {
+            ...$store,
+            list,
+            selected: list.find(view => view.id === $store.selectedViewId),
+          }
         }
-      })
+      )
     }
 
     super(

From 15ad884ac8e832053e2fe7ebf5204e59c9e11e59 Mon Sep 17 00:00:00 2001
From: Adria Navarro <adria@budibase.com>
Date: Fri, 20 Dec 2024 11:21:25 +0100
Subject: [PATCH 5/5] Fix test order

---
 packages/server/src/sdk/app/views/index.ts | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/packages/server/src/sdk/app/views/index.ts b/packages/server/src/sdk/app/views/index.ts
index ad3399d54b..7fc78b9085 100644
--- a/packages/server/src/sdk/app/views/index.ts
+++ b/packages/server/src/sdk/app/views/index.ts
@@ -324,7 +324,9 @@ export async function update(
   return pickApi(tableId).update(tableId, view)
 }
 
-export const isV2 = helpers.views.isV2
+export function isV2(view: View | ViewV2) {
+  return helpers.views.isV2(view)
+}
 
 export async function remove(viewId: string): Promise<ViewV2> {
   const { tableId } = utils.extractViewInfoFromID(viewId)