Various fixes for update self behaviour

packages/builder/src/components/portal/onboarding/tours.js

@@ -3,6 +3,7 @@ import { store } from "builderStore"
 import { users, auth } from "stores/portal"
 import analytics from "analytics"
 import { OnboardingData, OnboardingDesign, OnboardingPublish } from "./steps"
+import { API } from "api"
 const ONBOARDING_EVENT_PREFIX = "onboarding"
 
 export const TOUR_STEP_KEYS = {
@@ -83,8 +84,7 @@ const getTours = () => {
           // Mark the users onboarding as complete
           // Clear all tour related state
           if (get(auth).user) {
-            await users.save({
+            await API.updateSelf({
-              ...get(auth).user,
               onboardedAt: new Date().toISOString(),
             })
 
@@ -114,8 +114,7 @@ const getTours = () => {
         onComplete: async () => {
           // Push the onboarding forward
           if (get(auth).user) {
-            await users.save({
+            await API.updateSelf({
-              ...get(auth).user,
               onboardedAt: new Date().toISOString(),
             })
 

packages/builder/src/components/settings/ProfileModal.svelte

@@ -13,6 +13,7 @@
       await auth.updateSelf($values)
       notifications.success("Information updated successfully")
     } catch (error) {
+      console.error(error)
       notifications.error("Failed to update information")
     }
   }

packages/builder/src/stores/portal/auth.js

@@ -154,9 +154,14 @@ export function createAuthStore() {
       await setInitInfo({})
     },
     updateSelf: async fields => {
-      const newUser = { ...get(auth).user, ...fields }
+      await API.updateSelf({ ...fields })
-      await API.updateSelf(newUser)
+      // Refetch to enrich after update.
-      setUser(newUser)
+      try {
+        const user = await API.fetchBuilderSelf()
+        setUser(user)
+      } catch (error) {
+        setUser(null)
+      }
     },
     forgotPassword: async email => {
       const tenantId = get(store).tenantId

packages/types/src/api/web/auth.ts

@@ -17,6 +17,7 @@ export interface UpdateSelfRequest {
   lastName?: string
   password?: string
   forceResetPassword?: boolean
+  onboardedAt?: string
 }
 
 export interface UpdateSelfResponse {

packages/types/src/sdk/user.ts

@@ -3,6 +3,7 @@ export interface UpdateSelf {
   lastName?: string
   password?: string
   forceResetPassword?: boolean
+  onboardedAt?: string
 }
 
 export interface SaveUserOpts {

packages/worker/src/api/controllers/global/self.ts

@@ -123,11 +123,12 @@ export async function updateSelf(
   ctx: UserCtx<UpdateSelfRequest, UpdateSelfResponse>
 ) {
   const body = ctx.request.body
-  const update: UpdateSelf = {
+
-    firstName: body.firstName,
+  const update: UpdateSelf = {}
-    lastName: body.lastName,
+  for (let [key, value] of Object.entries(body)) {
-    password: body.password,
+    if (value) {
-    forceResetPassword: body.forceResetPassword,
+      update[key as keyof UpdateSelf] = value
+    }
   }
 
   const user = await userSdk.updateSelf(ctx.user._id!, update)

packages/worker/src/api/routes/global/self.ts

@@ -11,7 +11,7 @@ router
   .get("/api/global/self", controller.getSelf)
   .post(
     "/api/global/self",
-    users.buildUserSaveValidation(true),
+    users.buildSelfSaveValidation(),
     controller.updateSelf
   )
 

packages/worker/src/api/routes/validation/users.ts

@@ -17,13 +17,22 @@ let schema: any = {
   roles: Joi.object().pattern(/.*/, Joi.string()).required().unknown(true),
 }
 
-export const buildUserSaveValidation = (isSelf = false) => {
+export const buildSelfSaveValidation = () => {
-  if (!isSelf) {
+  schema = {
-    schema = {
+    password: Joi.string().allow(null, ""),
-      ...schema,
+    forceResetPassword: Joi.boolean().optional(),
-      _id: Joi.string(),
+    firstName: Joi.string().allow(null, ""),
-      _rev: Joi.string(),
+    lastName: Joi.string().allow(null, ""),
-    }
+    onboardedAt: Joi.string().allow(null, ""),
+  }
+  return auth.joiValidator.body(Joi.object(schema).required().unknown(false))
+}
+
+export const buildUserSaveValidation = () => {
+  schema = {
+    ...schema,
+    _id: Joi.string(),
+    _rev: Joi.string(),
   }
   return auth.joiValidator.body(Joi.object(schema).required().unknown(true))
 }

packages/worker/src/sdk/users/users.ts

@@ -233,7 +233,7 @@ export async function updateSelf(id: string, data: UpdateSelf) {
     ...user,
     ...data,
   }
-  return save(user)
+  return save(user, { requirePassword: false })
 }
 
 export const save = async (