diff --git a/packages/bbui/src/Actions/position_dropdown.js b/packages/bbui/src/Actions/position_dropdown.js index 01d0ec4553..9bf5a40a67 100644 --- a/packages/bbui/src/Actions/position_dropdown.js +++ b/packages/bbui/src/Actions/position_dropdown.js @@ -48,11 +48,11 @@ export default function positionDropdown(element, { anchor, align }) { element.style.left = `${calcLeftPosition(dimensions).toFixed(0)}px` const resizeObserver = new ResizeObserver(entries => { - for (let entry of entries) { + entries.forEach(() => { dimensions = getDimensions() element.style[positionSide] = `${dimensions[positionSide]}px` element.style.left = `${calcLeftPosition(dimensions).toFixed(0)}px` - } + }) }) resizeObserver.observe(anchor) diff --git a/packages/bbui/src/Stores/notifications.js b/packages/bbui/src/Stores/notifications.js index 481fb812e4..520e5c97b2 100644 --- a/packages/bbui/src/Stores/notifications.js +++ b/packages/bbui/src/Stores/notifications.js @@ -11,8 +11,6 @@ const createNotificationStore = () => { }) } - let timers = [] - const notifications = derived(_notifications, ($_notifications, set) => { set($_notifications) if ($_notifications.length > 0) { diff --git a/packages/builder/cypress/integration/createView.spec.js b/packages/builder/cypress/integration/createView.spec.js index a34f68422a..2d4bd121cb 100644 --- a/packages/builder/cypress/integration/createView.spec.js +++ b/packages/builder/cypress/integration/createView.spec.js @@ -109,15 +109,17 @@ context("Create a View", () => { .find(".ag-cell") .then($values => { const values = Array.from($values).map(value => value.textContent) - expect(values.sort()).to.deep.eq([ - "Students", - "23.333333333333332", - "1650", - "3", - "25", - "20", - "70", - ].sort()) + expect(values.sort()).to.deep.eq( + [ + "Students", + "23.333333333333332", + "1650", + "3", + "25", + "20", + "70", + ].sort() + ) }) }) diff --git a/packages/builder/cypress/support/commands.js b/packages/builder/cypress/support/commands.js index 4a8d0b39d3..7ac317142d 100644 --- a/packages/builder/cypress/support/commands.js +++ b/packages/builder/cypress/support/commands.js @@ -57,9 +57,9 @@ Cypress.Commands.add("createApp", name => { Cypress.Commands.add("deleteApp", name => { cy.visit(`localhost:${Cypress.env("PORT")}/builder`) - cy.get("body").then($body => { + cy.get(".apps").then($apps => { cy.wait(1000) - if ($body.find(`[data-cy="app-${name}"]`).length) { + if ($apps.find(`[data-cy="app-${name}"]`).length) { cy.get(`[data-cy="app-${name}"] a`).click() cy.get("[data-cy=settings-icon]").click() cy.get(".modal-content").within(() => { diff --git a/packages/builder/src/components/backend/DataTable/popovers/CreateViewPopover.svelte b/packages/builder/src/components/backend/DataTable/popovers/CreateViewPopover.svelte index ab4aa9ecae..93ca7bb211 100644 --- a/packages/builder/src/components/backend/DataTable/popovers/CreateViewPopover.svelte +++ b/packages/builder/src/components/backend/DataTable/popovers/CreateViewPopover.svelte @@ -26,7 +26,7 @@ notifier.success(`View ${name} created`) onClosed() analytics.captureEvent("View Created", { name }) - $goto(`../../../view/${name}`) + $goto(`../../view/${name}`) } diff --git a/packages/builder/src/pages/builder/[application]/_reset.svelte b/packages/builder/src/pages/builder/[application]/_reset.svelte index 3be1942e44..2c066d28a5 100644 --- a/packages/builder/src/pages/builder/[application]/_reset.svelte +++ b/packages/builder/src/pages/builder/[application]/_reset.svelte @@ -45,65 +45,71 @@ } -
Something went wrong: {error.message}
- {/await} -Something went wrong: {error.message}
+{/await}