From 6b306266b5e322e5f3728a8392e7c55d5e82cd47 Mon Sep 17 00:00:00 2001
From: Sam Rose <hello@samwho.dev>
Date: Thu, 29 Feb 2024 11:09:39 +0000
Subject: [PATCH] Only show stack traces if you ask for them.

---
 .../src/middleware/errorHandling.ts           | 26 +++++++++----------
 .../server/src/tests/utilities/api/base.ts    |  6 ++++-
 2 files changed, 17 insertions(+), 15 deletions(-)

diff --git a/packages/backend-core/src/middleware/errorHandling.ts b/packages/backend-core/src/middleware/errorHandling.ts
index ae5373a2e0..2b8f7195ed 100644
--- a/packages/backend-core/src/middleware/errorHandling.ts
+++ b/packages/backend-core/src/middleware/errorHandling.ts
@@ -15,21 +15,19 @@ export async function errorHandling(ctx: any, next: any) {
       console.error(err)
     }
 
-    if (environment.isTest()) {
-      ctx.body = {
-        message: err.message,
-        status: status,
-        error: errors.getPublicError(err),
-        stack: err.stack,
-      }
-    } else {
-      ctx.body = {
-        message: err.message,
-        status: status,
-        validationErrors: err.validation,
-        error: errors.getPublicError(err),
-      }
+    let error: APIError = {
+      message: err.message,
+      status: status,
+      validationErrors: err.validation,
+      error: errors.getPublicError(err),
     }
+
+    if (environment.isTest() && ctx.headers["x-budibase-include-stacktrace"]) {
+      // @ts-ignore
+      error.stack = err.stack
+    }
+
+    ctx.body = error
   }
 }
 
diff --git a/packages/server/src/tests/utilities/api/base.ts b/packages/server/src/tests/utilities/api/base.ts
index 42911628fd..19fc7ed1f5 100644
--- a/packages/server/src/tests/utilities/api/base.ts
+++ b/packages/server/src/tests/utilities/api/base.ts
@@ -96,7 +96,11 @@ export abstract class TestAPI {
       url += `?${queryParams.join("&")}`
     }
 
-    let request = this.request[method](url).set(this.config.defaultHeaders())
+    let request = this.request[method](url).set(
+      this.config.defaultHeaders({
+        "x-budibase-include-stacktrace": "true",
+      })
+    )
     if (headers) {
       request = request.set(headers)
     }