Change query defaulting behaviour

packages/frontend-core/src/fetch/DataFetch.js

@@ -177,16 +177,11 @@ export default class DataFetch {
       }
     }
 
-    let defaultQuery = {
-      logicalOperator: FilterGroupLogicalOperator.ALL,
-      groups: [],
-    }
-
     // Build the query
     let query = this.options.query
 
     if (!query && this.features.supportsSearch) {
-      query = buildQuery(filter || defaultQuery)
+      query = buildQuery(filter)
     }
 
     // Update store

packages/shared-core/src/filters.ts

@@ -574,12 +574,7 @@ export const buildQueryLegacy = (
 export const buildQuery = (
   filter?: SearchFilterGroup | SearchFilter[]
 ): SearchFilters | undefined => {
-  const parsedFilter: SearchFilterGroup | undefined =
+  const parsedFilter: SearchFilterGroup = processSearchFilters(filter)
-    processSearchFilters(filter)
-
-  if (!parsedFilter) {
-    return
-  }
 
   const operatorMap: { [key in FilterGroupLogicalOperator]: LogicalOperator } =
     {

packages/shared-core/src/utils.ts

@@ -98,16 +98,17 @@ export function trimOtherProps(object: any, allowedProps: string[]) {
  */
 export const processSearchFilters = (
   filters: SearchFilter[] | SearchFilterGroup | undefined
-): SearchFilterGroup | undefined => {
+): SearchFilterGroup => {
-  if (!filters) {
+  // Base search config.
-    return
-  }
   const defaultCfg: SearchFilterGroup = {
     logicalOperator: FilterGroupLogicalOperator.ALL,
-    onEmptyFilter: EmptyFilterOption.RETURN_NONE,
     groups: [],
   }
 
+  if (!filters) {
+    return defaultCfg
+  }
+
   const filterWhitelistKeys = [
     "field",
     "operator",
@@ -182,7 +183,7 @@ export const processSearchFilters = (
 
     return migratedSetting
   } else if (!filters?.groups) {
-    return
+    return defaultCfg
   }
   return filters
 }