MirrorSave
/
budibase
mirror of https://github.com/Budibase/budibase.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #6735 from Budibase/fix/dom-children 

Replace incorrect usages of element.childNodes with element.children
This commit is contained in:
Andrew Kingston 2022-07-21 09:24:47 +01:00 committed by GitHub
parent 5185696b62 c9ee465507
commit 6b9898f9ad
5 changed files with 6 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/builder/src/pages/builder/app/[application]/design/[screenId]/components/[componentId]/_components/navigation/DNDPositionIndicator.svelte
View File

@ -16,7 +16,7 @@
// Get root li element // Get root li element
const el = document.getElementById(`component-${component?._id}`) const el = document.getElementById(`component-${component?._id}`)
// Get inner nav item content element // Get inner nav item content element
const child = el?.childNodes[0]?.childNodes[0] const child = el?.children[0]?.children[0]
if (!el) { if (!el) {
return return
} }

2
packages/client/src/components/Component.svelte
View File

@ -401,7 +401,7 @@
} }
const scrollIntoView = () => { const scrollIntoView = () => {
const node = document.getElementsByClassName(id)?.[0]?.childNodes[0] const node = document.getElementsByClassName(id)?.[0]?.children[0]
if (!node) { if (!node) {
return return
} }

4
packages/client/src/components/preview/DNDHandler.svelte
View File

@ -35,8 +35,8 @@
const getDOMNodeForComponent = component => { const getDOMNodeForComponent = component => {
const parent = component.closest(".component") const parent = component.closest(".component")
const children = Array.from(parent.childNodes) const children = Array.from(parent.children)
return children?.find(node => node?.nodeType === 1) return children[0]
} }
// Callback when initially starting a drag on a draggable component // Callback when initially starting a drag on a draggable component

3
packages/client/src/components/preview/IndicatorSet.svelte
View File

@ -71,8 +71,7 @@
// Extract valid children // Extract valid children
// Sanity limit of 100 active indicators // Sanity limit of 100 active indicators
const children = Array.from(parents) const children = Array.from(parents)
.map(parent => parent?.childNodes?.[0]) .map(parent => parent?.children?.[0])
.filter(node => node?.nodeType === 1)
.slice(0, 100) .slice(0, 100)
// If there aren't any nodes then reset // If there aren't any nodes then reset

2
packages/client/src/components/preview/SettingsBar.svelte
View File

@ -37,7 +37,7 @@
} }
const id = $builderStore.selectedComponentId const id = $builderStore.selectedComponentId
const parent = document.getElementsByClassName(id)?.[0] const parent = document.getElementsByClassName(id)?.[0]
const element = parent?.childNodes?.[0] const element = parent?.children?.[0]
// The settings bar is higher in the dom tree than the selection indicators // The settings bar is higher in the dom tree than the selection indicators
// as we want to be able to render the settings bar wider than the screen, // as we want to be able to render the settings bar wider than the screen,