MirrorSave
/
budibase
mirror of https://github.com/Budibase/budibase.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Properly remove window event listener when unmounting component preview

This commit is contained in:
Andrew Kingston 2022-03-07 10:17:05 +00:00
parent 89e4c59e3c
commit 6e439c7eb5
2 changed files with 2691 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
packages/builder/src/components/design/AppPreview/CurrentItemPreview.svelte
View File

@ -134,8 +134,9 @@
// Remove all iframe event listeners on component destroy // Remove all iframe event listeners on component destroy
onDestroy(() => { onDestroy(() => {
window.removeEventListener("message", receiveMessage)
if (iframe.contentWindow) { if (iframe.contentWindow) {
window.removeEventListener("message", receiveMessage)
if (!$store.clientFeatures.messagePassing) { if (!$store.clientFeatures.messagePassing) {
// Legacy - remove in later versions of BB // Legacy - remove in later versions of BB
iframe.contentWindow.removeEventListener( iframe.contentWindow.removeEventListener(

2689
packages/client/stats.html Normal file
View File

File diff suppressed because one or more lines are too long