Properly remove window event listener when unmounting component preview

2022-03-07 10:17:05 +00:00 · 2022-03-07 10:17:05 +00:00 · 6e439c7eb5
parent 89e4c59e3c
commit 6e439c7eb5
2 changed files with 2691 additions and 1 deletions
--- a/packages/builder/src/components/design/AppPreview/CurrentItemPreview.svelte
+++ b/packages/builder/src/components/design/AppPreview/CurrentItemPreview.svelte
@ -134,8 +134,9 @@

  // Remove all iframe event listeners on component destroy
  onDestroy(() => {
+    window.removeEventListener("message", receiveMessage)
+
    if (iframe.contentWindow) {
-      window.removeEventListener("message", receiveMessage)
      if (!$store.clientFeatures.messagePassing) {
        // Legacy - remove in later versions of BB
        iframe.contentWindow.removeEventListener(
--- a/packages/client/stats.html
+++ b/packages/client/stats.html