From 703092505d2ab8c50a80551feebd1abd53904731 Mon Sep 17 00:00:00 2001 From: Sam Rose Date: Fri, 3 May 2024 15:08:21 +0100 Subject: [PATCH] Respond to PR feedback. --- packages/server/src/utilities/rowProcessor/index.ts | 4 +--- packages/types/src/documents/app/table/schema.ts | 12 ------------ 2 files changed, 1 insertion(+), 15 deletions(-) diff --git a/packages/server/src/utilities/rowProcessor/index.ts b/packages/server/src/utilities/rowProcessor/index.ts index d072802522..7da61ebcb6 100644 --- a/packages/server/src/utilities/rowProcessor/index.ts +++ b/packages/server/src/utilities/rowProcessor/index.ts @@ -9,8 +9,6 @@ import { Row, RowAttachment, Table, - isAutoColumnField, - isAutoColumnNumberField, } from "@budibase/types" import { cloneDeep } from "lodash/fp" import { @@ -41,7 +39,7 @@ async function getNextAutoId( const db = context.getAppDB() for (let attempt = 0; attempt < 5; attempt++) { const schema = table.schema[column] - if (!isAutoColumnField(schema) && !isAutoColumnNumberField(schema)) { + if (schema.type !== FieldType.NUMBER && schema.type !== FieldType.AUTO) { throw new Error(`Column ${column} is not an auto column`) } schema.lastID = (schema.lastID || 0) + 1 diff --git a/packages/types/src/documents/app/table/schema.ts b/packages/types/src/documents/app/table/schema.ts index d9fb405ff5..18fbeae719 100644 --- a/packages/types/src/documents/app/table/schema.ts +++ b/packages/types/src/documents/app/table/schema.ts @@ -219,15 +219,3 @@ export function isAttachmentField( ): field is AttachmentFieldMetadata { return field.type === FieldType.ATTACHMENTS } - -export function isAutoColumnField( - field: FieldSchema -): field is AutoColumnFieldMetadata { - return field.type === FieldType.AUTO -} - -export function isAutoColumnNumberField( - field: FieldSchema -): field is NumberFieldMetadata { - return field.type === FieldType.NUMBER -}