From 72028b57ec8b6d7a737fc875f5f5791c55a395bf Mon Sep 17 00:00:00 2001
From: Dean <deanhannigan@gmail.com>
Date: Mon, 24 Oct 2022 16:31:58 +0100
Subject: [PATCH] Don't attempt to render the internal chart until a type has
 been set

---
 .../components/app/blocks/ChartBlock.svelte   | 60 ++++++++++---------
 1 file changed, 31 insertions(+), 29 deletions(-)

diff --git a/packages/client/src/components/app/blocks/ChartBlock.svelte b/packages/client/src/components/app/blocks/ChartBlock.svelte
index cc2d156129..92151ad9c0 100644
--- a/packages/client/src/components/app/blocks/ChartBlock.svelte
+++ b/packages/client/src/components/app/blocks/ChartBlock.svelte
@@ -64,34 +64,36 @@
       limit,
     }}
   >
-    <BlockComponent
-      type={chartType}
-      props={{
-        dataProvider: `{{ literal ${safe(dataProviderId)} }}`,
-        height,
-        width,
-        title: chartTitle,
-        labelColumn,
-        valueColumn,
-        valueColumns,
-        palette,
-        dataLabels,
-        legend,
-        animate,
-        ...colors,
-        yAxisUnits,
-        yAxisLabel,
-        xAxisLabel,
-        stacked,
-        horizontal,
-        curve,
-        gradient, //issue?
-        closeColumn,
-        openColumn,
-        highColumn,
-        lowColumn,
-        dateColumn,
-      }}
-    />
+    {#if dataProviderId && chartType}
+      <BlockComponent
+        type={chartType}
+        props={{
+          dataProvider: `{{ literal ${safe(dataProviderId)} }}`,
+          height,
+          width,
+          title: chartTitle,
+          labelColumn,
+          valueColumn,
+          valueColumns,
+          palette,
+          dataLabels,
+          legend,
+          animate,
+          ...colors,
+          yAxisUnits,
+          yAxisLabel,
+          xAxisLabel,
+          stacked,
+          horizontal,
+          curve,
+          gradient, //issue?
+          closeColumn,
+          openColumn,
+          highColumn,
+          lowColumn,
+          dateColumn,
+        }}
+      />
+    {/if}
   </BlockComponent>
 </Block>